svn commit: r910097 - /ofbiz/trunk/framework/base/src/org/ofbiz/base/conversion/Converters.java

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

svn commit: r910097 - /ofbiz/trunk/framework/base/src/org/ofbiz/base/conversion/Converters.java

doogie-3
Author: doogie
Date: Sun Feb 14 22:35:13 2010
New Revision: 910097

URL: http://svn.apache.org/viewvc?rev=910097&view=rev
Log:
Remove checkExtendsImplements; in actuality, each converter should
handle this itself.

Modified:
    ofbiz/trunk/framework/base/src/org/ofbiz/base/conversion/Converters.java

Modified: ofbiz/trunk/framework/base/src/org/ofbiz/base/conversion/Converters.java
URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/base/src/org/ofbiz/base/conversion/Converters.java?rev=910097&r1=910096&r2=910097&view=diff
==============================================================================
--- ofbiz/trunk/framework/base/src/org/ofbiz/base/conversion/Converters.java (original)
+++ ofbiz/trunk/framework/base/src/org/ofbiz/base/conversion/Converters.java Sun Feb 14 22:35:13 2010
@@ -97,11 +97,6 @@
                     continue OUTER;
                 }
             }
-            result = checkExtendsImplements(sourceClass, targetClass);
-            if (result != null) {
-                converterMap.putIfAbsent(key, result);
-                continue;
-            }
             // Null converter must be checked last
             if (nullConverter.canConvert(sourceClass, targetClass)) {
                 Converter passThruConverter = new PassThruConverter<S>(sourceClass);
@@ -118,37 +113,6 @@
         } while (true);
     }
 
-    private static <S, T> Converter<S, T> checkExtendsImplements(Class<S> sourceClass, Class<T> targetClass) throws ClassNotFoundException {
-        if (targetClass == null || sourceClass == null) {
-            return null;
-        }
-        String key = sourceClass.getName().concat(DELIMITER).concat(targetClass.getName());
-        Converter<?, ?> result = converterMap.get(key);
-        if (result == null) {
-            result = checkExtendsImplements(sourceClass, targetClass.getSuperclass());
-            if (result == null) {
-                for (Class<?> intf: targetClass.getInterfaces()) {
-                    result = checkExtendsImplements(sourceClass, intf);
-                    if (result != null) {
-                        break;
-                    }
-                }
-                if (result == null) {
-                    result = checkExtendsImplements(sourceClass.getSuperclass(), targetClass);
-                    if (result == null) {
-                        for (Class<?> intf: sourceClass.getInterfaces()) {
-                            result = checkExtendsImplements(intf, targetClass);
-                            if (result != null) {
-                                break;
-                            }
-                        }
-                    }
-                }
-            }
-        }
-        return UtilGenerics.cast(result);
-    }
-
     /** Load all classes that implement <code>Converter</code> and are
      * contained in <code>containerClass</code>.
      *