svn commit: r907178 - in /ofbiz/trunk/applications/product: script/org/ofbiz/product/test/InventoryTests.xml testdef/FacilityTest.xml

[mor-2]

Author: mor
Date: Sat Feb  6 06:46:07 2010
New Revision: 907178

URL: http://svn.apache.org/viewvc?rev=907178&view=rev
Log:
Minor cleanup. Removed unnecessary log statements, improved test case name etc.

Modified:
    ofbiz/trunk/applications/product/script/org/ofbiz/product/test/InventoryTests.xml
    ofbiz/trunk/applications/product/testdef/FacilityTest.xml

Modified: ofbiz/trunk/applications/product/script/org/ofbiz/product/test/InventoryTests.xml
URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/script/org/ofbiz/product/test/InventoryTests.xml?rev=907178&r1=907177&r2=907178&view=diff
==============================================================================
--- ofbiz/trunk/applications/product/script/org/ofbiz/product/test/InventoryTests.xml (original)
+++ ofbiz/trunk/applications/product/script/org/ofbiz/product/test/InventoryTests.xml Sat Feb  6 06:46:07 2010
@@ -22,22 +22,17 @@
         xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/simple-methods.xsd">
 
     <!-- Test Physical Inventory Adjustment -->
-    <simple-method method-name="testPhysicalInventoryAdjustment" short-description="Test to create physical inventory and variance" login-required="false">
-        <log level="info" message="====================Create physical inventory and variance test case================================"/>
-        <set field="createPhysicalInventoryAndVarianceMap.inventoryItemId" value="9024"/>
-        <set field="createPhysicalInventoryAndVarianceMap.varianceReasonId" value="VAR_LOST"/>
-        <entity-one entity-name="UserLogin" value-field="createPhysicalInventoryAndVarianceMap.userLogin">
+    <simple-method method-name="testCreatePhysicalInventoryAndVariance" short-description="Test to create physical inventory and variance" login-required="false">
+        <set field="serviceCtx.inventoryItemId" value="9024"/>
+        <set field="serviceCtx.varianceReasonId" value="VAR_LOST"/>
+        <entity-one entity-name="UserLogin" value-field="serviceCtx.userLogin">
             <field-map field-name="userLoginId" value="system"/>
         </entity-one>
-        <call-service service-name="createPhysicalInventoryAndVariance" in-map-name="createPhysicalInventoryAndVarianceMap">
+        <call-service service-name="createPhysicalInventoryAndVariance" in-map-name="serviceCtx">
             <result-to-field result-name="physicalInventoryId" field="physicalInventoryId"/>
         </call-service>
         <assert>
-            <not>
-                <if-empty field="physicalInventoryId">
-                    <log level="info" message="========physicalInventoryId ${physicalInventoryId} found null============================"/>
-                </if-empty>
-            </not>
+            <not><if-empty field="physicalInventoryId"/></not>
         </assert>
         <check-errors/>
     </simple-method>

Modified: ofbiz/trunk/applications/product/testdef/FacilityTest.xml
URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/testdef/FacilityTest.xml?rev=907178&r1=907177&r2=907178&view=diff
==============================================================================
--- ofbiz/trunk/applications/product/testdef/FacilityTest.xml (original)
+++ ofbiz/trunk/applications/product/testdef/FacilityTest.xml Sat Feb  6 06:46:07 2010
@@ -28,8 +28,8 @@
         <junit-test-suite class-name="org.ofbiz.product.test.InventoryItemTransferTest"/>
     </test-case>
     <!-- Physical Inventory Adjustment test -->
-    <test-case case-name="physicalInventoryAdjustment-test">
-        <simple-method-test location="component://product/script/org/ofbiz/product/test/InventoryTests.xml" name="testPhysicalInventoryAdjustment"/>
+    <test-case case-name="inventory-tests">
+        <simple-method-test location="component://product/script/org/ofbiz/product/test/InventoryTests.xml"/>
     </test-case>
 
     <test-case case-name="shipment-tests">