svn commit: r904982 - /ofbiz/trunk/framework/service/src/org/ofbiz/service/ServiceUtil.java

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

svn commit: r904982 - /ofbiz/trunk/framework/service/src/org/ofbiz/service/ServiceUtil.java

doogie-3
Author: doogie
Date: Sun Jan 31 06:25:04 2010
New Revision: 904982

URL: http://svn.apache.org/viewvc?rev=904982&view=rev
Log:
Fix closing of job list iterator if an exception happens.

Modified:
    ofbiz/trunk/framework/service/src/org/ofbiz/service/ServiceUtil.java

Modified: ofbiz/trunk/framework/service/src/org/ofbiz/service/ServiceUtil.java
URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/service/src/org/ofbiz/service/ServiceUtil.java?rev=904982&r1=904981&r2=904982&view=diff
==============================================================================
--- ofbiz/trunk/framework/service/src/org/ofbiz/service/ServiceUtil.java (original)
+++ ofbiz/trunk/framework/service/src/org/ofbiz/service/ServiceUtil.java Sun Jan 31 06:25:04 2010
@@ -414,8 +414,11 @@
                     beganTx1 = TransactionUtil.begin();
 
                     EntityListIterator foundJobs = delegator.find("JobSandbox", mainCond, null, null, null, findOptions);
-                    curList = foundJobs.getPartialList(1, 1000);
-                    foundJobs.close();
+                    try {
+                        curList = foundJobs.getPartialList(1, 1000);
+                    } finally {
+                        foundJobs.close();
+                    }
 
                 } catch (GenericEntityException e) {
                     Debug.logError(e, "Cannot obtain job data from datasource", module);