svn commit: r904020 - /ofbiz/trunk/applications/product/src/org/ofbiz/shipment/shipment/ShipmentServices.java

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

svn commit: r904020 - /ofbiz/trunk/applications/product/src/org/ofbiz/shipment/shipment/ShipmentServices.java

jacopoc
Author: jacopoc
Date: Thu Jan 28 09:52:23 2010
New Revision: 904020

URL: http://svn.apache.org/viewvc?rev=904020&view=rev
Log:
Commented out code that was attempting to remove QuantityBreak records after the deletion of a ShipmentEstimate. QuantityBreak shouldn't be automatically removed because they can represent ranges that are used in different contexts.
Based on comments from Abdullah Shaikh.

Modified:
    ofbiz/trunk/applications/product/src/org/ofbiz/shipment/shipment/ShipmentServices.java

Modified: ofbiz/trunk/applications/product/src/org/ofbiz/shipment/shipment/ShipmentServices.java
URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/src/org/ofbiz/shipment/shipment/ShipmentServices.java?rev=904020&r1=904019&r2=904020&view=diff
==============================================================================
--- ofbiz/trunk/applications/product/src/org/ofbiz/shipment/shipment/ShipmentServices.java (original)
+++ ofbiz/trunk/applications/product/src/org/ofbiz/shipment/shipment/ShipmentServices.java Thu Jan 28 09:52:23 2010
@@ -139,6 +139,7 @@
             Debug.logError(e, module);
             return ServiceUtil.returnError("Problem removing entity or related entities (" + e.toString() + ")");
         }
+        /* Commented out this code because QuantityBreak may be used by other records
         try {
             if (estimate.get("weightBreakId") != null) {
                 delegator.removeRelated("WeightQuantityBreak", estimate);
@@ -160,6 +161,7 @@
         } catch (GenericEntityException e) {
             Debug.logInfo("Not removing PriceQuantityBreak records related to ShipmentCostEstimate [" + shipmentCostEstimateId + "] because they are used by other entities.", module);
         }
+        */
         return ServiceUtil.returnSuccess();
     }