Author: jacopoc
Date: Fri Jan 15 16:33:51 2010
New Revision: 899689
URL:
http://svn.apache.org/viewvc?rev=899689&view=revLog:
Based on feedback from Adam Heath and Adrian Crum, the loop operation now breaks the execution of the method if the count variable is negative.
Modified:
ofbiz/trunk/framework/minilang/src/org/ofbiz/minilang/method/envops/Loop.java
Modified: ofbiz/trunk/framework/minilang/src/org/ofbiz/minilang/method/envops/Loop.java
URL:
http://svn.apache.org/viewvc/ofbiz/trunk/framework/minilang/src/org/ofbiz/minilang/method/envops/Loop.java?rev=899689&r1=899688&r2=899689&view=diff==============================================================================
--- ofbiz/trunk/framework/minilang/src/org/ofbiz/minilang/method/envops/Loop.java (original)
+++ ofbiz/trunk/framework/minilang/src/org/ofbiz/minilang/method/envops/Loop.java Fri Jan 15 16:33:51 2010
@@ -73,8 +73,8 @@
}
if (count < 0) {
- Debug.logWarning("Count is less than zero, not doing anything: " + rawString(), module);
- return true;
+ Debug.logWarning("Unable to execute loop operation because the count variable is negative: " + rawString(), module);
+ return false;
}
for (int i = 0; i < count; i++) {