[jira] [Updated] (OFBIZ-5257) Method isInvoiceInForeignCurrency in InvoiceServices.xml is named wrong

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-5257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Pierre Smits updated OFBIZ-5257:
--------------------------------

    Attachment: OFBIZ-5257-ACCTG-WrongMethodNaming.patch

This patch fixes the issue.
               

> Method isInvoiceInForeignCurrency in InvoiceServices.xml is named wrong
> -----------------------------------------------------------------------
>
>                 Key: OFBIZ-5257
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-5257
>             Project: OFBiz
>          Issue Type: Bug
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Pierre Smits
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-5257-ACCTG-WrongMethodNaming.patch
>
>
> The name of this method in accounting services doesn't tell what it does.
> You have to go into the description what the functionality of the method is, namely checking whether an invoice is a foreign currency.
> Best practice is to have the name of the function reflect the functionality.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira