[jira] [Created] (OFBIZ-5205) method-name="deleteRateAmount" used for delete rate amount but method definiton is wrong because this method definition is used for create rateamount

[Nicolas Malin (Jira)]

Dhiraj Gupta created OFBIZ-5205:
-----------------------------------

             Summary:   method-name="deleteRateAmount"  used for  delete rate amount but method definiton is wrong because this method  definition is used for create rateamount
                 Key: OFBIZ-5205
                 URL: https://issues.apache.org/jira/browse/OFBIZ-5205
             Project: OFBiz
          Issue Type: Test
          Components: accounting, humanres
    Affects Versions: Release 10.04, Release Branch 11.04, SVN trunk, Release 11.04.01, Release Branch 12.04
            Reporter: Dhiraj Gupta



 Hi all,
The deleteRateAmount  service is used for update/create a rate amount value
not for delete rate amount please fix this bug.


<service name="deleteRateAmount" default-entity-name="RateAmount" engine="simple" auth="true"
        location="component://accounting/script/org/ofbiz/accounting/rate/RateServices.xml" invoke="deleteRateAmount">
        <description>Delete (expire) Rate Amount</description>
        <auto-attributes include="pk" mode="IN" optional="true"/>
        <override name="rateTypeId" optional="false"/>
        <override name="fromDate" optional="false"/>
    </service>


 <simple-method method-name="deleteRateAmount" short-description="update/create a rate amount value">
        <set value="_CREATE" field="securityAction"/>
        <check-permission permission="ACCOUNTING" action="${securityAction}"><fail-property resource="AccountingUiLabels" property="AccountingPermissionError"/></check-permission>
        <check-errors/>

        <!-- set defaults -->
        <if-empty field="parameters.rateCurrencyUomId">
            <property-to-field resource="general.properties" property="currency.uom.id.default" field="parameters.rateCurrencyUomId"/>
        </if-empty>
        <if-empty field="parameters.periodTypeId">
            <set field="parameters.periodTypeId" value="RATE_HOUR"/>
        </if-empty>
        <if-empty field="parameters.emplPositionTypeId">
            <set field="parameters.emplPositionTypeId" value="_NA_"/>
        </if-empty>
        <if-empty field="parameters.partyId">
            <set field="parameters.partyId" value="_NA_"/>
        </if-empty>
        <if-empty field="parameters.workEffortId">
            <set field="parameters.workEffortId" value="_NA_"/>
        </if-empty>

        <entity-one entity-name="RateAmount" value-field="rateAmount"/>
                <if-not-empty field="rateAmount">
            <now-timestamp field="rateAmount.thruDate"/>
            <store-value value-field="rateAmount"/>
            <else>
                <add-error><fail-message message="could not find record to be deleted"/></add-error>
            </else>
        </if-not-empty>
</simple-method>

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira