[jira] [Created] (OFBIZ-5048) Multi Part Input Parameters not Available in Groovy Event

[Nicolas Malin (Jira)]

Vikramjit Singh created OFBIZ-5048:
--------------------------------------

             Summary: Multi Part Input Parameters not Available in Groovy Event
                 Key: OFBIZ-5048
                 URL: https://issues.apache.org/jira/browse/OFBIZ-5048
             Project: OFBiz
          Issue Type: New Feature
          Components: ALL COMPONENTS
    Affects Versions: Release Branch 11.04
            Reporter: Vikramjit Singh
             Fix For: Release Branch 11.04


If form is of type enctype="multipart/form-data" and we are handling it's submission through Groovy Event then in the parameters Map Ofbiz does not set the multipart input parameters from request parameters.

The same are available when multipart form submission is handled through service.

The reason being the code that sets the multipart parameters in request attribute is only available in ServiceEventHandler.java and in GroovyEventHandler the multipart are never set.

So I have created a method getMultiPartParameterMap in the class UtilHttp.java and put the common logic in that method so that when getCombinedMap method is called from the GroovEventHandler the method also call getMultiPartParameterMap and in the ServiceEventHandler I have written a call for getMultiPartParameterMap method.

I am attaching the Patch Kindly Verify the same.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-5048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vikramjit Singh updated OFBIZ-5048:
-----------------------------------

    Attachment: GroovyEventMultipartParametes.patch

Patch for making Multi Part Parameters available in the Groovy Event Too.
               

> Multi Part Input Parameters not Available in Groovy Event
> ---------------------------------------------------------
>
>                 Key: OFBIZ-5048
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-5048
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: ALL COMPONENTS
>    Affects Versions: Release Branch 11.04
>            Reporter: Vikramjit Singh
>             Fix For: Release Branch 11.04
>
>         Attachments: GroovyEventMultipartParametes.patch
>
>
> If form is of type enctype="multipart/form-data" and we are handling it's submission through Groovy Event then in the parameters Map Ofbiz does not set the multipart input parameters from request parameters.
> The same are available when multipart form submission is handled through service.
> The reason being the code that sets the multipart parameters in request attribute is only available in ServiceEventHandler.java and in GroovyEventHandler the multipart are never set.
> So I have created a method getMultiPartParameterMap in the class UtilHttp.java and put the common logic in that method so that when getCombinedMap method is called from the GroovEventHandler the method also call getMultiPartParameterMap and in the ServiceEventHandler I have written a call for getMultiPartParameterMap method.
> I am attaching the Patch Kindly Verify the same.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-5048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux reassigned OFBIZ-5048:
--------------------------------------

    Assignee: Jacques Le Roux
   

> Multi Part Input Parameters not Available in Groovy Event
> ---------------------------------------------------------
>
>                 Key: OFBIZ-5048
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-5048
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: ALL COMPONENTS
>    Affects Versions: Release Branch 11.04
>            Reporter: Vikramjit Singh
>            Assignee: Jacques Le Roux
>             Fix For: Release Branch 11.04
>
>         Attachments: GroovyEventMultipartParametes.patch
>
>
> If form is of type enctype="multipart/form-data" and we are handling it's submission through Groovy Event then in the parameters Map Ofbiz does not set the multipart input parameters from request parameters.
> The same are available when multipart form submission is handled through service.
> The reason being the code that sets the multipart parameters in request attribute is only available in ServiceEventHandler.java and in GroovyEventHandler the multipart are never set.
> So I have created a method getMultiPartParameterMap in the class UtilHttp.java and put the common logic in that method so that when getCombinedMap method is called from the GroovEventHandler the method also call getMultiPartParameterMap and in the ServiceEventHandler I have written a call for getMultiPartParameterMap method.
> I am attaching the Patch Kindly Verify the same.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-5048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux updated OFBIZ-5048:
-----------------------------------

    Affects Version/s:     (was: Release Branch 11.04)
                       SVN trunk
        Fix Version/s:     (was: Release Branch 11.04)
   

> Multi Part Input Parameters not Available in Groovy Event
> ---------------------------------------------------------
>
>                 Key: OFBIZ-5048
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-5048
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Vikramjit Singh
>            Assignee: Jacques Le Roux
>         Attachments: GroovyEventMultipartParametes.patch
>
>
> If form is of type enctype="multipart/form-data" and we are handling it's submission through Groovy Event then in the parameters Map Ofbiz does not set the multipart input parameters from request parameters.
> The same are available when multipart form submission is handled through service.
> The reason being the code that sets the multipart parameters in request attribute is only available in ServiceEventHandler.java and in GroovyEventHandler the multipart are never set.
> So I have created a method getMultiPartParameterMap in the class UtilHttp.java and put the common logic in that method so that when getCombinedMap method is called from the GroovEventHandler the method also call getMultiPartParameterMap and in the ServiceEventHandler I have written a call for getMultiPartParameterMap method.
> I am attaching the Patch Kindly Verify the same.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-5048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13494896#comment-13494896 ]

Jacques Le Roux commented on OFBIZ-5048:
----------------------------------------

This is not a bug fix, hence can only get applied to trunk. I just checked and the patch does not apply to trunk. Please provide a trunk version, thanks
               

> Multi Part Input Parameters not Available in Groovy Event
> ---------------------------------------------------------
>
>                 Key: OFBIZ-5048
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-5048
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Vikramjit Singh
>            Assignee: Jacques Le Roux
>         Attachments: GroovyEventMultipartParametes.patch
>
>
> If form is of type enctype="multipart/form-data" and we are handling it's submission through Groovy Event then in the parameters Map Ofbiz does not set the multipart input parameters from request parameters.
> The same are available when multipart form submission is handled through service.
> The reason being the code that sets the multipart parameters in request attribute is only available in ServiceEventHandler.java and in GroovyEventHandler the multipart are never set.
> So I have created a method getMultiPartParameterMap in the class UtilHttp.java and put the common logic in that method so that when getCombinedMap method is called from the GroovEventHandler the method also call getMultiPartParameterMap and in the ServiceEventHandler I have written a call for getMultiPartParameterMap method.
> I am attaching the Patch Kindly Verify the same.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira