[jira] [Created] (OFBIZ-5038) Internal notes and shipping notes are lost when input an order

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Created] (OFBIZ-5038) Internal notes and shipping notes are lost when input an order

Nicolas Malin (Jira)
Leon created OFBIZ-5038:
---------------------------

             Summary: Internal notes and shipping notes are lost when input an order
                 Key: OFBIZ-5038
                 URL: https://issues.apache.org/jira/browse/OFBIZ-5038
             Project: OFBiz
          Issue Type: Bug
          Components: order
    Affects Versions: SVN trunk
            Reporter: Leon
            Priority: Minor
             Fix For: SVN trunk


when we try to create an order, we can input internal note and shipping note in "option" form. But those information is lost when we come back to "option" setting form or when we create the order at last.

The estimated delivery before/after date are not correctly set either in "option" form.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (OFBIZ-5038) Internal notes and shipping notes are lost when input an order

Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-5038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Leon updated OFBIZ-5038:
------------------------

    Attachment: OFBIZ-5038.patch

1. submit internal notes and shipping notes to order cart
2. display estimated shipping before and after date
3. avoid adding internal notes and shipping notes multiple times if submit options repeatedly
4. make it possible to empty internal note or shipping note
               

> Internal notes and shipping notes are lost when input an order
> --------------------------------------------------------------
>
>                 Key: OFBIZ-5038
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-5038
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Leon
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-5038.patch
>
>
> when we try to create an order, we can input internal note and shipping note in "option" form. But those information is lost when we come back to "option" setting form or when we create the order at last.
> The estimated delivery before/after date are not correctly set either in "option" form.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (OFBIZ-5038) Internal notes and shipping notes are lost when input an order

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-5038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13471691#comment-13471691 ]

Jacques Le Roux commented on OFBIZ-5038:
----------------------------------------

HI Leon,

This works well, why did you add?
{code}
Index: applications/order/src/org/ofbiz/order/shoppingcart/CheckOutEvents.java
===================================================================
--- applications/order/src/org/ofbiz/order/shoppingcart/CheckOutEvents.java (revision 4830)
+++ applications/order/src/org/ofbiz/order/shoppingcart/CheckOutEvents.java (working copy)
@@ -828,7 +828,8 @@
                     if (UtilValidate.isNotEmpty(request.getParameter(shipGroupIndex + "_ship_estimate"))) {
                         shipEstimate = new BigDecimal(request.getParameter(shipGroupIndex + "_ship_estimate"));
                     }
-                    
+                    cart.clearOrderNotes();
+                    cart.clearInternalOrderNotes();
{code}

               

> Internal notes and shipping notes are lost when input an order
> --------------------------------------------------------------
>
>                 Key: OFBIZ-5038
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-5038
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Leon
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-5038.patch
>
>
> when we try to create an order, we can input internal note and shipping note in "option" form. But those information is lost when we come back to "option" setting form or when we create the order at last.
> The estimated delivery before/after date are not correctly set either in "option" form.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
Reply | Threaded
Open this post in threaded view
|

[jira] [Assigned] (OFBIZ-5038) Internal notes and shipping notes are lost when input an order

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-5038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux reassigned OFBIZ-5038:
--------------------------------------

    Assignee: Jacques Le Roux
   

> Internal notes and shipping notes are lost when input an order
> --------------------------------------------------------------
>
>                 Key: OFBIZ-5038
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-5038
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Leon
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-5038.patch
>
>
> when we try to create an order, we can input internal note and shipping note in "option" form. But those information is lost when we come back to "option" setting form or when we create the order at last.
> The estimated delivery before/after date are not correctly set either in "option" form.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (OFBIZ-5038) Internal notes and shipping notes are lost when input an order

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-5038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13472254#comment-13472254 ]

Leon commented on OFBIZ-5038:
-----------------------------

3. avoid adding internal notes and shipping notes multiple times if submit options repeatedly

These two lines code will clear notes buffer before new notes added. Otherwise, if you go back and forth between "options" tab and other tabs, you will get more than one internal notes and shipping notes at last.

               

> Internal notes and shipping notes are lost when input an order
> --------------------------------------------------------------
>
>                 Key: OFBIZ-5038
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-5038
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Leon
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-5038.patch
>
>
> when we try to create an order, we can input internal note and shipping note in "option" form. But those information is lost when we come back to "option" setting form or when we create the order at last.
> The estimated delivery before/after date are not correctly set either in "option" form.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
Reply | Threaded
Open this post in threaded view
|

[jira] [Closed] (OFBIZ-5038) Internal notes and shipping notes are lost when input an order

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-5038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-5038.
----------------------------------

       Resolution: Fixed
    Fix Version/s: Release Branch 12.04
                   Release Branch 11.04

Thanks Leon,

For my question, I thought so but wanted to be sure there will be no side-effects. Since it's only in finalizeOrderEntry, it should be ok.

Your patch is in
trunk r1395953  
R12.04 r1395959
R11.04 r1395966

R10.04 got conflicts, I did not merge

               

> Internal notes and shipping notes are lost when input an order
> --------------------------------------------------------------
>
>                 Key: OFBIZ-5038
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-5038
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Leon
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: Release Branch 11.04, SVN trunk, Release Branch 12.04
>
>         Attachments: OFBIZ-5038.patch
>
>
> when we try to create an order, we can input internal note and shipping note in "option" form. But those information is lost when we come back to "option" setting form or when we create the order at last.
> The estimated delivery before/after date are not correctly set either in "option" form.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira