[jira] [Created] (OFBIZ-4970) correct "javascript:void();" to "javascript:void(0);" to make it syntax valid

[Nicolas Malin (Jira)]

Leon created OFBIZ-4970:
---------------------------

             Summary: correct "javascript:void();" to "javascript:void(0);" to make it syntax valid
                 Key: OFBIZ-4970
                 URL: https://issues.apache.org/jira/browse/OFBIZ-4970
             Project: OFBiz
          Issue Type: Bug
          Components: framework
    Affects Versions: SVN trunk
            Reporter: Leon
            Priority: Trivial
             Fix For: SVN trunk
         Attachments: OFBIZ-4970.patch

Firefox will throw syntax error if you call javascript void function without parameter.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Leon updated OFBIZ-4970:
------------------------

    Attachment: OFBIZ-4970.patch
   

> correct "javascript:void();" to "javascript:void(0);" to make it syntax valid
> -----------------------------------------------------------------------------
>
>                 Key: OFBIZ-4970
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4970
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Leon
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-4970.patch
>
>
> Firefox will throw syntax error if you call javascript void function without parameter.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13419767#comment-13419767 ]

Jacques Le Roux commented on OFBIZ-4970:
----------------------------------------

I'd have appreciated an use case to quickly test
               

> correct "javascript:void();" to "javascript:void(0);" to make it syntax valid
> -----------------------------------------------------------------------------
>
>                 Key: OFBIZ-4970
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4970
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Leon
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-4970.patch
>
>
> Firefox will throw syntax error if you call javascript void function without parameter.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Leon updated OFBIZ-4970:
------------------------

    Attachment: screenshot-1.jpg

<lookup> field now supports "clear" function, but if you try to "clear", you will get syntax error.
               

> correct "javascript:void();" to "javascript:void(0);" to make it syntax valid
> -----------------------------------------------------------------------------
>
>                 Key: OFBIZ-4970
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4970
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Leon
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-4970.patch, screenshot-1.jpg
>
>
> Firefox will throw syntax error if you call javascript void function without parameter.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux reassigned OFBIZ-4970:
--------------------------------------

    Assignee: Jacques Le Roux
   

> correct "javascript:void();" to "javascript:void(0);" to make it syntax valid
> -----------------------------------------------------------------------------
>
>                 Key: OFBIZ-4970
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4970
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Leon
>            Assignee: Jacques Le Roux
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-4970.patch, screenshot-1.jpg
>
>
> Firefox will throw syntax error if you call javascript void function without parameter.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13427247#comment-13427247 ]

Jacques Le Roux commented on OFBIZ-4970:
----------------------------------------

I found another issue, I'm working on...
               

> correct "javascript:void();" to "javascript:void(0);" to make it syntax valid
> -----------------------------------------------------------------------------
>
>                 Key: OFBIZ-4970
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4970
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Leon
>            Assignee: Jacques Le Roux
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-4970.patch, screenshot-1.jpg
>
>
> Firefox will throw syntax error if you call javascript void function without parameter.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-4970.
----------------------------------

    Resolution: Fixed

Thanks for report Leon,

Actually "clear" is not a new function. I found some other cases so I fixed them all in :
trunk r1369555
R12.04 r1369556
R11.04 r1369557

               

> correct "javascript:void();" to "javascript:void(0);" to make it syntax valid
> -----------------------------------------------------------------------------
>
>                 Key: OFBIZ-4970
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4970
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Leon
>            Assignee: Jacques Le Roux
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-4970.patch, screenshot-1.jpg
>
>
> Firefox will throw syntax error if you call javascript void function without parameter.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux updated OFBIZ-4970:
-----------------------------------

    Fix Version/s: Release Branch 12.04
                   Release Branch 11.04
   

> correct "javascript:void();" to "javascript:void(0);" to make it syntax valid
> -----------------------------------------------------------------------------
>
>                 Key: OFBIZ-4970
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4970
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Leon
>            Assignee: Jacques Le Roux
>            Priority: Trivial
>             Fix For: Release Branch 11.04, SVN trunk, Release Branch 12.04
>
>         Attachments: OFBIZ-4970.patch, screenshot-1.jpg
>
>
> Firefox will throw syntax error if you call javascript void function without parameter.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13428836#comment-13428836 ]

Jacques Le Roux commented on OFBIZ-4970:
----------------------------------------

About the bugs I talked about see
trunk r1369561  
R12.04 r1369562
R11.04 r1369563



               

> correct "javascript:void();" to "javascript:void(0);" to make it syntax valid
> -----------------------------------------------------------------------------
>
>                 Key: OFBIZ-4970
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4970
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Leon
>            Assignee: Jacques Le Roux
>            Priority: Trivial
>             Fix For: Release Branch 11.04, SVN trunk, Release Branch 12.04
>
>         Attachments: OFBIZ-4970.patch, screenshot-1.jpg
>
>
> Firefox will throw syntax error if you call javascript void function without parameter.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira