[jira] [Created] (OFBIZ-4844) Fields in extended entity do not override attribute enable-audit-log

[Nicolas Malin (Jira)]

Adam Kozak created OFBIZ-4844:
---------------------------------

             Summary: Fields in extended entity do not override attribute enable-audit-log
                 Key: OFBIZ-4844
                 URL: https://issues.apache.org/jira/browse/OFBIZ-4844
             Project: OFBiz
          Issue Type: Bug
          Components: framework
    Affects Versions: Release 11.04.01
         Environment: n/a
            Reporter: Adam Kozak
            Priority: Trivial


When extending existing entity and overriding fields attribute 'enable-audit-log' is not overriden. Suggested patch in ModelEntity.java:

    if (UtilValidate.isNotEmpty(field.getDescription())) {
        existingField.setDescription(field.getDescription());
    }
+   existingField.enableAuditLog = UtilXml.checkBoolean(fieldElement.getAttribute("enable-audit-log"), existingField.enableAuditLog);
} else {

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13262440#comment-13262440 ]

Pierre Smits commented on OFBIZ-4844:
-------------------------------------

I believe this is not a 'minor' bug.
               

> Fields in extended entity do not override attribute enable-audit-log
> --------------------------------------------------------------------
>
>                 Key: OFBIZ-4844
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4844
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release 11.04.01
>         Environment: n/a
>            Reporter: Adam Kozak
>            Priority: Trivial
>   Original Estimate: 10m
>  Remaining Estimate: 10m
>
> When extending existing entity and overriding fields attribute 'enable-audit-log' is not overriden. Suggested patch in ModelEntity.java:
>     if (UtilValidate.isNotEmpty(field.getDescription())) {
>         existingField.setDescription(field.getDescription());
>     }
> +   existingField.enableAuditLog = UtilXml.checkBoolean(fieldElement.getAttribute("enable-audit-log"), existingField.enableAuditLog);
> } else {

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adam Kozak updated OFBIZ-4844:
------------------------------

    Priority: Major  (was: Trivial)
   

> Fields in extended entity do not override attribute enable-audit-log
> --------------------------------------------------------------------
>
>                 Key: OFBIZ-4844
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4844
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release 11.04.01
>         Environment: n/a
>            Reporter: Adam Kozak
>   Original Estimate: 10m
>  Remaining Estimate: 10m
>
> When extending existing entity and overriding fields attribute 'enable-audit-log' is not overriden. Suggested patch in ModelEntity.java:
>     if (UtilValidate.isNotEmpty(field.getDescription())) {
>         existingField.setDescription(field.getDescription());
>     }
> +   existingField.enableAuditLog = UtilXml.checkBoolean(fieldElement.getAttribute("enable-audit-log"), existingField.enableAuditLog);
> } else {

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13262451#comment-13262451 ]

Adam Kozak commented on OFBIZ-4844:
-----------------------------------

OK, it's major then ;)
               

> Fields in extended entity do not override attribute enable-audit-log
> --------------------------------------------------------------------
>
>                 Key: OFBIZ-4844
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4844
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release 11.04.01
>         Environment: n/a
>            Reporter: Adam Kozak
>   Original Estimate: 10m
>  Remaining Estimate: 10m
>
> When extending existing entity and overriding fields attribute 'enable-audit-log' is not overriden. Suggested patch in ModelEntity.java:
>     if (UtilValidate.isNotEmpty(field.getDescription())) {
>         existingField.setDescription(field.getDescription());
>     }
> +   existingField.enableAuditLog = UtilXml.checkBoolean(fieldElement.getAttribute("enable-audit-log"), existingField.enableAuditLog);
> } else {

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux reassigned OFBIZ-4844:
--------------------------------------

    Assignee: Jacques Le Roux
   

> Fields in extended entity do not override attribute enable-audit-log
> --------------------------------------------------------------------
>
>                 Key: OFBIZ-4844
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4844
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release 11.04.01
>         Environment: n/a
>            Reporter: Adam Kozak
>            Assignee: Jacques Le Roux
>   Original Estimate: 10m
>  Remaining Estimate: 10m
>
> When extending existing entity and overriding fields attribute 'enable-audit-log' is not overriden. Suggested patch in ModelEntity.java:
>     if (UtilValidate.isNotEmpty(field.getDescription())) {
>         existingField.setDescription(field.getDescription());
>     }
> +   existingField.enableAuditLog = UtilXml.checkBoolean(fieldElement.getAttribute("enable-audit-log"), existingField.enableAuditLog);
> } else {

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux updated OFBIZ-4844:
-----------------------------------

    Affects Version/s:     (was: Release 11.04.01)
                       SVN trunk
           Issue Type: Improvement  (was: Bug)

This is an improvement (nothing fails). They get only to trunk.
               

> Fields in extended entity do not override attribute enable-audit-log
> --------------------------------------------------------------------
>
>                 Key: OFBIZ-4844
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4844
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>         Environment: n/a
>            Reporter: Adam Kozak
>            Assignee: Jacques Le Roux
>   Original Estimate: 10m
>  Remaining Estimate: 10m
>
> When extending existing entity and overriding fields attribute 'enable-audit-log' is not overriden. Suggested patch in ModelEntity.java:
>     if (UtilValidate.isNotEmpty(field.getDescription())) {
>         existingField.setDescription(field.getDescription());
>     }
> +   existingField.enableAuditLog = UtilXml.checkBoolean(fieldElement.getAttribute("enable-audit-log"), existingField.enableAuditLog);
> } else {

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chatree Srichart updated OFBIZ-4844:
------------------------------------

    Attachment: audit_log.patch

I attached a patch file to enable the extended entity to be able to override the enable-audit-log field.
               

> Fields in extended entity do not override attribute enable-audit-log
> --------------------------------------------------------------------
>
>                 Key: OFBIZ-4844
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4844
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>         Environment: n/a
>            Reporter: Adam Kozak
>            Assignee: Jacques Le Roux
>         Attachments: audit_log.patch
>
>   Original Estimate: 10m
>  Remaining Estimate: 10m
>
> When extending existing entity and overriding fields attribute 'enable-audit-log' is not overriden. Suggested patch in ModelEntity.java:
>     if (UtilValidate.isNotEmpty(field.getDescription())) {
>         existingField.setDescription(field.getDescription());
>     }
> +   existingField.enableAuditLog = UtilXml.checkBoolean(fieldElement.getAttribute("enable-audit-log"), existingField.enableAuditLog);
> } else {

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-4844.
----------------------------------

       Resolution: Fixed
    Fix Version/s: SVN trunk

Thanks Chatree,

Your patch in trunk at revision: 1381559  

Tested with NoteData.noteParty

               

> Fields in extended entity do not override attribute enable-audit-log
> --------------------------------------------------------------------
>
>                 Key: OFBIZ-4844
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4844
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>         Environment: n/a
>            Reporter: Adam Kozak
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: audit_log.patch
>
>   Original Estimate: 10m
>  Remaining Estimate: 10m
>
> When extending existing entity and overriding fields attribute 'enable-audit-log' is not overriden. Suggested patch in ModelEntity.java:
>     if (UtilValidate.isNotEmpty(field.getDescription())) {
>         existingField.setDescription(field.getDescription());
>     }
> +   existingField.enableAuditLog = UtilXml.checkBoolean(fieldElement.getAttribute("enable-audit-log"), existingField.enableAuditLog);
> } else {

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira