[jira] [Created] (OFBIZ-4669) sessionAttributes doesn't work from screen widget

[Nicolas Malin (Jira)]

sessionAttributes doesn't work from screen widget
-------------------------------------------------

                 Key: OFBIZ-4669
                 URL: https://issues.apache.org/jira/browse/OFBIZ-4669
             Project: OFBiz
          Issue Type: Bug
          Components: framework
    Affects Versions: Release Branch 11.04, SVN trunk
            Reporter: Kiran Gawde


In the screen widget, add a set action that refers to sessionAttributes, it doesn't work.

e.g: Following doesn't work:
<set field="titleProperty" value="${sessionAttributes.autoName}"/>

Following works:
 <set field="titleProperty" from-field="autoName" from-scope="user"/>

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13193291#comment-13193291 ]

Erwan de FERRIERES commented on OFBIZ-4669:
-------------------------------------------

Hi Kira,

what do you want to say with this issue ?

Regards,
               

> sessionAttributes doesn't work from screen widget
> -------------------------------------------------
>
>                 Key: OFBIZ-4669
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4669
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release Branch 11.04, SVN trunk
>            Reporter: Kiran Gawde
>
> In the screen widget, add a set action that refers to sessionAttributes, it doesn't work.
> e.g: Following doesn't work:
> <set field="titleProperty" value="${sessionAttributes.autoName}"/>
> Following works:
>  <set field="titleProperty" from-field="autoName" from-scope="user"/>

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13193327#comment-13193327 ]

Kiran Gawde commented on OFBIZ-4669:
------------------------------------

Hello Erwan,

Seems like sessionAttributes doesn't work in screen widget. But I see
reference to it in few other places:

e.g: In ProfileScreens.xml
<set field="previousParams" from-field=
"sessionAttributes._PREVIOUS_PARAMS_"/>

So, I either we get sessionAttributes working or replace the references.

Regards,
Kiran Gawde

               

> sessionAttributes doesn't work from screen widget
> -------------------------------------------------
>
>                 Key: OFBIZ-4669
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4669
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release Branch 11.04, SVN trunk
>            Reporter: Kiran Gawde
>
> In the screen widget, add a set action that refers to sessionAttributes, it doesn't work.
> e.g: Following doesn't work:
> <set field="titleProperty" value="${sessionAttributes.autoName}"/>
> Following works:
>  <set field="titleProperty" from-field="autoName" from-scope="user"/>

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13195691#comment-13195691 ]

Jacques Le Roux commented on OFBIZ-4669:
----------------------------------------

Erwan, Jiran,

It seems, at least, the one used in Party component is useless (or I don't see its use). To be more clear I mean
{code}
<form name="NewUser" type="single" target="${target}${previousParams}"
{code}
               

> sessionAttributes doesn't work from screen widget
> -------------------------------------------------
>
>                 Key: OFBIZ-4669
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4669
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release Branch 11.04, SVN trunk
>            Reporter: Kiran Gawde
>
> In the screen widget, add a set action that refers to sessionAttributes, it doesn't work.
> e.g: Following doesn't work:
> <set field="titleProperty" value="${sessionAttributes.autoName}"/>
> Following works:
>  <set field="titleProperty" from-field="autoName" from-scope="user"/>

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13236400#comment-13236400 ]

Jacques Le Roux commented on OFBIZ-4669:
----------------------------------------

Bump... A patch?
               

> sessionAttributes doesn't work from screen widget
> -------------------------------------------------
>
>                 Key: OFBIZ-4669
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4669
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release Branch 11.04, SVN trunk
>            Reporter: Kiran Gawde
>
> In the screen widget, add a set action that refers to sessionAttributes, it doesn't work.
> e.g: Following doesn't work:
> <set field="titleProperty" value="${sessionAttributes.autoName}"/>
> Following works:
>  <set field="titleProperty" from-field="autoName" from-scope="user"/>

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13195691#comment-13195691 ]

Jacques Le Roux edited comment on OFBIZ-4669 at 4/22/12 7:56 PM:
-----------------------------------------------------------------

Erwan, Kiran,

It seems, at least, the one used in Party component is useless (or I don't see its use). To be more clear I mean
{code}
<form name="NewUser" type="single" target="${target}${previousParams}"
{code}
               
      was (Author: jacques.le.roux):
    Erwan, Jiran,

It seems, at least, the one used in Party component is useless (or I don't see its use). To be more clear I mean
{code}
<form name="NewUser" type="single" target="${target}${previousParams}"
{code}
                 

> sessionAttributes doesn't work from screen widget
> -------------------------------------------------
>
>                 Key: OFBIZ-4669
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4669
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release Branch 11.04, SVN trunk
>            Reporter: Kiran Gawde
>
> In the screen widget, add a set action that refers to sessionAttributes, it doesn't work.
> e.g: Following doesn't work:
> <set field="titleProperty" value="${sessionAttributes.autoName}"/>
> Following works:
>  <set field="titleProperty" from-field="autoName" from-scope="user"/>

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux updated OFBIZ-4669:
-----------------------------------

    Comment: was deleted

(was: Bump... A patch?)
   

> sessionAttributes doesn't work from screen widget
> -------------------------------------------------
>
>                 Key: OFBIZ-4669
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4669
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release Branch 11.04, SVN trunk
>            Reporter: Kiran Gawde
>
> In the screen widget, add a set action that refers to sessionAttributes, it doesn't work.
> e.g: Following doesn't work:
> <set field="titleProperty" value="${sessionAttributes.autoName}"/>
> Following works:
>  <set field="titleProperty" from-field="autoName" from-scope="user"/>

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259233#comment-13259233 ]

Jacques Le Roux commented on OFBIZ-4669:
----------------------------------------

BTW it seems that this is known for a moment, also for requestAttributes.

<!-- TODO/NOTE DEJ20070223: for some reason this isn't working, doing an assign within the FTL file which does work: <set field="productCategoryLink" from-field="requestAttributes.productCategoryLink"/> -->

They are both represented by a freemarker.ext.servlet.HttpSessionHashMode
sessionAttributes = freemarker.ext.servlet.HttpSessionHashModel@4559a
requestAttributes = freemarker.ext.servlet.HttpRequestHashModel@902aea

               

> sessionAttributes doesn't work from screen widget
> -------------------------------------------------
>
>                 Key: OFBIZ-4669
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4669
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release Branch 11.04, SVN trunk
>            Reporter: Kiran Gawde
>
> In the screen widget, add a set action that refers to sessionAttributes, it doesn't work.
> e.g: Following doesn't work:
> <set field="titleProperty" value="${sessionAttributes.autoName}"/>
> Following works:
>  <set field="titleProperty" from-field="autoName" from-scope="user"/>

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259685#comment-13259685 ]

Daniel Riquelme commented on OFBIZ-4669:
----------------------------------------

I guess it's because freemarker.ext.servlet.HttpSessionHashModel and freemarker.ext.servlet.HttpRequestHashModel are only intended to work in ftl.

org.ofbiz.widget.screen.ScreenRenderer has the following:
line: 240

// these ones are FreeMarker specific and will only work in FTL templates, mainly here for backward compatibility
BeansWrapper wrapper = BeansWrapper.getDefaultInstance();
context.put("sessionAttributes", new HttpSessionHashModel(session, wrapper));
context.put("requestAttributes", new HttpRequestHashModel(request, wrapper));


               

> sessionAttributes doesn't work from screen widget
> -------------------------------------------------
>
>                 Key: OFBIZ-4669
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4669
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release Branch 11.04, SVN trunk
>            Reporter: Kiran Gawde
>
> In the screen widget, add a set action that refers to sessionAttributes, it doesn't work.
> e.g: Following doesn't work:
> <set field="titleProperty" value="${sessionAttributes.autoName}"/>
> Following works:
>  <set field="titleProperty" from-field="autoName" from-scope="user"/>

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13261045#comment-13261045 ]

Jacques Le Roux commented on OFBIZ-4669:
----------------------------------------

OK,let's keep it seimple, like Kiran suggested I propose to replace the instances
               

> sessionAttributes doesn't work from screen widget
> -------------------------------------------------
>
>                 Key: OFBIZ-4669
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4669
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release Branch 11.04, SVN trunk
>            Reporter: Kiran Gawde
>
> In the screen widget, add a set action that refers to sessionAttributes, it doesn't work.
> e.g: Following doesn't work:
> <set field="titleProperty" value="${sessionAttributes.autoName}"/>
> Following works:
>  <set field="titleProperty" from-field="autoName" from-scope="user"/>

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Riquelme updated OFBIZ-4669:
-----------------------------------

    Attachment: OFBIZ-4669_sessionAttributesScreenWidget.patch

Here is a patch that fixes all instances of sessionAttributes in Screens. The Screens affected are:

applications/commonext/widget/ofbizsetup/ProfileScreens.xml

applications/commonext/widget/ofbizsetup/SetupScreens.xml

applications/party/widget/partymgr/PartyScreens.xml

No occurrences of sessionAttributes where found in Forms

               

> sessionAttributes doesn't work from screen widget
> -------------------------------------------------
>
>                 Key: OFBIZ-4669
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4669
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release Branch 11.04, SVN trunk
>            Reporter: Kiran Gawde
>         Attachments: OFBIZ-4669_sessionAttributesScreenWidget.patch
>
>
> In the screen widget, add a set action that refers to sessionAttributes, it doesn't work.
> e.g: Following doesn't work:
> <set field="titleProperty" value="${sessionAttributes.autoName}"/>
> Following works:
>  <set field="titleProperty" from-field="autoName" from-scope="user"/>

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-4669.
----------------------------------

       Resolution: Fixed
    Fix Version/s: Release Branch 12.04
                   SVN trunk
                   Release Branch 11.04
                   Release Branch 10.04
         Assignee: Jacques Le Roux

Thanks Kiran, Daniel,

Daniel your patch is in
trunk r1340821  
R12.04 r1340822
R11.04 r1340823
R10.04 r1340824


               

> sessionAttributes doesn't work from screen widget
> -------------------------------------------------
>
>                 Key: OFBIZ-4669
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4669
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release Branch 11.04, SVN trunk
>            Reporter: Kiran Gawde
>            Assignee: Jacques Le Roux
>             Fix For: Release Branch 10.04, Release Branch 11.04, SVN trunk, Release Branch 12.04
>
>         Attachments: OFBIZ-4669_sessionAttributesScreenWidget.patch
>
>
> In the screen widget, add a set action that refers to sessionAttributes, it doesn't work.
> e.g: Following doesn't work:
> <set field="titleProperty" value="${sessionAttributes.autoName}"/>
> Following works:
>  <set field="titleProperty" from-field="autoName" from-scope="user"/>

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira