[jira] [Created] (OFBIZ-4543) minilanguage does not remeber a variable type but uses the default string type

[Nicolas Malin (Jira)]

minilanguage does not remeber a variable type but uses the default string type
------------------------------------------------------------------------------

                 Key: OFBIZ-4543
                 URL: https://issues.apache.org/jira/browse/OFBIZ-4543
             Project: OFBiz
          Issue Type: Improvement
          Components: framework
    Affects Versions: SVN trunk
            Reporter: Hans Bakker
            Priority: Minor


the following example code:

                        <set field="actual" value="true" type="Boolean"/>
                         <call-class-method method-name="getPaymentNotApplied" class-name="org.ofbiz.accounting.payment.PaymentWorker" ret-field="notAppliedPayment">
                             <field field="payment" type="GenericValue"/>
-                            <field field="actual"/>
+                            <field field="actual" type="Boolean"/>
                         </call-class-method>

if this diff file is not applied the java class getPaymentNotApplied will not be found because the minilanguage will use the 'string' type for the actual variable.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hans Bakker updated OFBIZ-4543:
-------------------------------

    Description:
the following example code:

{code}
    <set field="actual" value="true" type="Boolean"/>
    <call-class-method method-name="getPaymentNotApplied" classname="org.ofbiz.accounting.payment.PaymentWorker" ret-field="notAppliedPayment">
              <field field="payment" type="GenericValue"/>
-                            <field field="actual"/>
+                            <field field="actual" type="Boolean"/>
                         </call-class-method>
{code}
if this diff file is not applied the java class getPaymentNotApplied will not be found because the minilanguage will use the 'string' type for the actual variable.

  was:
the following example code:

                        <set field="actual" value="true" type="Boolean"/>
                         <call-class-method method-name="getPaymentNotApplied" class-name="org.ofbiz.accounting.payment.PaymentWorker" ret-field="notAppliedPayment">
                             <field field="payment" type="GenericValue"/>
-                            <field field="actual"/>
+                            <field field="actual" type="Boolean"/>
                         </call-class-method>

if this diff file is not applied the java class getPaymentNotApplied will not be found because the minilanguage will use the 'string' type for the actual variable.

   

> minilanguage does not remeber a variable type but uses the default string type
> ------------------------------------------------------------------------------
>
>                 Key: OFBIZ-4543
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4543
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Hans Bakker
>            Priority: Minor
>
> the following example code:
> {code}
>     <set field="actual" value="true" type="Boolean"/>
>     <call-class-method method-name="getPaymentNotApplied" classname="org.ofbiz.accounting.payment.PaymentWorker" ret-field="notAppliedPayment">
>               <field field="payment" type="GenericValue"/>
> -                            <field field="actual"/>
> +                            <field field="actual" type="Boolean"/>
>                          </call-class-method>
> {code}
> if this diff file is not applied the java class getPaymentNotApplied will not be found because the minilanguage will use the 'string' type for the actual variable.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum reassigned OFBIZ-4543:
----------------------------------

    Assignee: Adrian Crum
   

> minilanguage does not remeber a variable type but uses the default string type
> ------------------------------------------------------------------------------
>
>                 Key: OFBIZ-4543
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4543
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Hans Bakker
>            Assignee: Adrian Crum
>            Priority: Minor
>
> the following example code:
> {code}
>     <set field="actual" value="true" type="Boolean"/>
>     <call-class-method method-name="getPaymentNotApplied" classname="org.ofbiz.accounting.payment.PaymentWorker" ret-field="notAppliedPayment">
>               <field field="payment" type="GenericValue"/>
> -                            <field field="actual"/>
> +                            <field field="actual" type="Boolean"/>
>                          </call-class-method>
> {code}
> if this diff file is not applied the java class getPaymentNotApplied will not be found because the minilanguage will use the 'string' type for the actual variable.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum closed OFBIZ-4543.
------------------------------

    Resolution: Won't Fix

That is the intended behavior. The type attribute declares the Java class that the method signature is expecting, and that declaration is explicit. You cannot assume a variable's type will match the method parameter type.

               

> minilanguage does not remeber a variable type but uses the default string type
> ------------------------------------------------------------------------------
>
>                 Key: OFBIZ-4543
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4543
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Hans Bakker
>            Assignee: Adrian Crum
>            Priority: Minor
>
> the following example code:
> {code}
>     <set field="actual" value="true" type="Boolean"/>
>     <call-class-method method-name="getPaymentNotApplied" classname="org.ofbiz.accounting.payment.PaymentWorker" ret-field="notAppliedPayment">
>               <field field="payment" type="GenericValue"/>
> -                            <field field="actual"/>
> +                            <field field="actual" type="Boolean"/>
>                          </call-class-method>
> {code}
> if this diff file is not applied the java class getPaymentNotApplied will not be found because the minilanguage will use the 'string' type for the actual variable.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira