OFBiz › OFBiz - Dev

[jira] [Created] (OFBIZ-4291) No method to remove a promo code from the shopping cart

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

7 messages Options

Nicolas Malin (Jira)

[jira] [Created] (OFBIZ-4291) No method to remove a promo code from the shopping cart

No method to remove a promo code from the shopping cart
-------------------------------------------------------

Key: OFBIZ-4291
URL: https://issues.apache.org/jira/browse/OFBIZ-4291
Project: OFBiz
Issue Type: Improvement
Components: order
Affects Versions: Release Branch 10.04
Reporter: Glyton Camilleri
Fix For: SVN trunk

Hi,

When working with promotions and promo codes in the shopping cart, it seems not possible to remove _one_ specific promo code from the cart neither through the ShoppingCart and its helpers and services, nor through the ProductPromoWorker.
ShoppingCart has the method

{{addProductPromoCode(String productPromoCodeId, LocalDispatcher dispatcher)}}

but no method to remove the added PromoCode. Is there any other worker, service or event that can be called to do this? And if not, is there a specifc reason (maybe relating to promotions application rules) for not implementing this?

Any response is appreciated.

Thanks

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Nicolas Malin (Jira)

[jira] [Updated] (OFBIZ-4291) No method to remove a promo code from the shopping cart

[ https://issues.apache.org/jira/browse/OFBIZ-4291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Glyton Camilleri updated OFBIZ-4291:
------------------------------------

Fix Version/s: (was: SVN trunk)

> No method to remove a promo code from the shopping cart
> -------------------------------------------------------
>
> Key: OFBIZ-4291
> URL: https://issues.apache.org/jira/browse/OFBIZ-4291
> Project: OFBiz
> Issue Type: Improvement
> Components: order
> Affects Versions: Release Branch 10.04
> Reporter: Glyton Camilleri
>
> Hi,
> When working with promotions and promo codes in the shopping cart, it seems not possible to remove _one_ specific promo code from the cart neither through the ShoppingCart and its helpers and services, nor through the ProductPromoWorker.
> ShoppingCart has the method
> {{addProductPromoCode(String productPromoCodeId, LocalDispatcher dispatcher)}}
> but no method to remove the added PromoCode. Is there any other worker, service or event that can be called to do this? And if not, is there a specifc reason (maybe relating to promotions application rules) for not implementing this?
> Any response is appreciated.
> Thanks

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Nicolas Malin (Jira)

[jira] [Commented] (OFBIZ-4291) No method to remove a promo code from the shopping cart

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13039566#comment-13039566 ]

Frank Kootte commented on OFBIZ-4291:
-------------------------------------

Current provided method of dealing with removal of promotions is a so called brute force approach where removing all and adding not to be removed promotions again. Unless there is a good reason to not expose functionality to offer removal of a single promotions I would like to push the addition of such to trunk.

@Glyton - do you have a patch against trunk to do so perhaps ?

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Nicolas Malin (Jira)

[jira] [Updated] (OFBIZ-4291) No method to remove a promo code from the shopping cart

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Nandani Aggarwal updated OFBIZ-4291:
------------------------------------

Attachment: unapplyPromotion.txt

UnapplyPromotion function will solve your problem.This function will remove particular promo from cart .

> No method to remove a promo code from the shopping cart
> -------------------------------------------------------
>
> Key: OFBIZ-4291
> URL: https://issues.apache.org/jira/browse/OFBIZ-4291
> Project: OFBiz
> Issue Type: Improvement
> Components: order
> Affects Versions: Release Branch 10.04
> Reporter: Glyton Camilleri
> Attachments: unapplyPromotion.txt
>
>
> Hi,
> When working with promotions and promo codes in the shopping cart, it seems not possible to remove _one_ specific promo code from the cart neither through the ShoppingCart and its helpers and services, nor through the ProductPromoWorker.
> ShoppingCart has the method
> {{addProductPromoCode(String productPromoCodeId, LocalDispatcher dispatcher)}}
> but no method to remove the added PromoCode. Is there any other worker, service or event that can be called to do this? And if not, is there a specifc reason (maybe relating to promotions application rules) for not implementing this?
> Any response is appreciated.
> Thanks

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

Nicolas Malin (Jira)

[jira] [Comment Edited] (OFBIZ-4291) No method to remove a promo code from the shopping cart

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13289133#comment-13289133 ]

Nandani Aggarwal edited comment on OFBIZ-4291 at 6/5/12 4:10 AM:
-----------------------------------------------------------------

Attached file conatins UnapplyPromotion function, which will solve your problem.This function will remove particular promo from cart .In ofbiz , at present no method or service exist which can remove particular promo from cart.The attached function can be used for this purpose.

was (Author: [hidden email]):
UnapplyPromotion function will solve your problem.This function will remove particular promo from cart .

> No method to remove a promo code from the shopping cart
> -------------------------------------------------------
>
> Key: OFBIZ-4291
> URL: https://issues.apache.org/jira/browse/OFBIZ-4291
> Project: OFBiz
> Issue Type: Improvement
> Components: order
> Affects Versions: Release Branch 10.04
> Reporter: Glyton Camilleri
> Attachments: unapplyPromotion.txt
>
>
> Hi,
> When working with promotions and promo codes in the shopping cart, it seems not possible to remove _one_ specific promo code from the cart neither through the ShoppingCart and its helpers and services, nor through the ProductPromoWorker.
> ShoppingCart has the method
> {{addProductPromoCode(String productPromoCodeId, LocalDispatcher dispatcher)}}
> but no method to remove the added PromoCode. Is there any other worker, service or event that can be called to do this? And if not, is there a specifc reason (maybe relating to promotions application rules) for not implementing this?
> Any response is appreciated.
> Thanks

Nicolas Malin (Jira)

[jira] [Updated] (OFBIZ-4291) No method to remove a promo code from the shopping cart

In reply to this post by Nicolas Malin (Jira)

> No method to remove a promo code from the shopping cart
> -------------------------------------------------------
>
> Key: OFBIZ-4291
> URL: https://issues.apache.org/jira/browse/OFBIZ-4291
> Project: OFBiz
> Issue Type: Improvement
> Components: order
> Affects Versions: Release Branch 10.04
> Reporter: Glyton Camilleri
> Attachments: unapplyPromotion.txt
>
>
> Hi,
> When working with promotions and promo codes in the shopping cart, it seems not possible to remove _one_ specific promo code from the cart neither through the ShoppingCart and its helpers and services, nor through the ProductPromoWorker.
> ShoppingCart has the method
> {{addProductPromoCode(String productPromoCodeId, LocalDispatcher dispatcher)}}
> but no method to remove the added PromoCode. Is there any other worker, service or event that can be called to do this? And if not, is there a specifc reason (maybe relating to promotions application rules) for not implementing this?
> Any response is appreciated.
> Thanks

Nicolas Malin (Jira)

[jira] [Updated] (OFBIZ-4291) No method to remove a promo code from the shopping cart

In reply to this post by Nicolas Malin (Jira)

> No method to remove a promo code from the shopping cart
> -------------------------------------------------------
>
> Key: OFBIZ-4291
> URL: https://issues.apache.org/jira/browse/OFBIZ-4291
> Project: OFBiz
> Issue Type: Improvement
> Components: order
> Affects Versions: Release Branch 10.04
> Reporter: Glyton Camilleri
> Attachments: unapplyPromotion.txt
>
>
> Hi,
> When working with promotions and promo codes in the shopping cart, it seems not possible to remove _one_ specific promo code from the cart neither through the ShoppingCart and its helpers and services, nor through the ProductPromoWorker.
> ShoppingCart has the method
> {{addProductPromoCode(String productPromoCodeId, LocalDispatcher dispatcher)}}
> but no method to remove the added PromoCode. Is there any other worker, service or event that can be called to do this? And if not, is there a specifc reason (maybe relating to promotions application rules) for not implementing this?
> Any response is appreciated.
> Thanks