[jira] Created: (OFBIZ-4022) Collapse all broken if hyperlink in pane

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (OFBIZ-4022) Collapse all broken if hyperlink in pane

Nicolas Malin (Jira)
Collapse all broken if hyperlink in pane
----------------------------------------

                 Key: OFBIZ-4022
                 URL: https://issues.apache.org/jira/browse/OFBIZ-4022
             Project: OFBiz
          Issue Type: Bug
          Components: framework
    Affects Versions: SVN trunk
         Environment: Rev 1035845
            Reporter: Anne Jessel
            Priority: Minor


To reproduce the bug:

- edit the EditProduct form in applications/product/widget/catalog/ProductForms.xml

- add a new field with a hyperlink sub-element.

- refer to this new field in the first, non-collapsible field-group in the sort-order

- go to this page in the UI (edit a product in the catalog)

- the Expand All and Collapse All buttons do not work properly

The problem is caused by the javascript finding the added hyperlink field in the first field-group, and incorrectly assuming it is
the expand/collapse link for the field-group. This causes the javascript to crash when it gets a null reference to an enclosing li element.

It is not specific to the EditProduct form, but applies to any group of collapsible panes where one contains a hyperlink.

The attached patch simply checks that the li element actually exists.


--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-4022) Collapse all broken if hyperlink in pane

Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-4022?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Anne Jessel updated OFBIZ-4022:
-------------------------------

    Attachment: OFBIZ-4022_collapse-all-broken.patch

> Collapse all broken if hyperlink in pane
> ----------------------------------------
>
>                 Key: OFBIZ-4022
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4022
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>         Environment: Rev 1035845
>            Reporter: Anne Jessel
>            Priority: Minor
>         Attachments: OFBIZ-4022_collapse-all-broken.patch
>
>   Original Estimate: 0.33h
>  Remaining Estimate: 0.33h
>
> To reproduce the bug:
> - edit the EditProduct form in applications/product/widget/catalog/ProductForms.xml
> - add a new field with a hyperlink sub-element.
> - refer to this new field in the first, non-collapsible field-group in the sort-order
> - go to this page in the UI (edit a product in the catalog)
> - the Expand All and Collapse All buttons do not work properly
> The problem is caused by the javascript finding the added hyperlink field in the first field-group, and incorrectly assuming it is
> the expand/collapse link for the field-group. This causes the javascript to crash when it gets a null reference to an enclosing li element.
> It is not specific to the EditProduct form, but applies to any group of collapsible panes where one contains a hyperlink.
> The attached patch simply checks that the li element actually exists.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Closed: (OFBIZ-4022) Collapse all broken if hyperlink in pane

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-4022?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-4022.
----------------------------------

       Resolution: Fixed
    Fix Version/s: SVN trunk
                   jQuery
                   Release Branch 10.04
                   Release Branch 09.04
         Assignee: Jacques Le Roux

Thanks Anne,

Your patch is in trunk at r1042348, R10.04 at r1042358, R9.04 at r1042357, jQuery at r1042349

Please don't forget to use spaces instead of tabs in your patch, not a big deal anyway


> Collapse all broken if hyperlink in pane
> ----------------------------------------
>
>                 Key: OFBIZ-4022
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4022
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>         Environment: Rev 1035845
>            Reporter: Anne Jessel
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: Release Branch 09.04, Release Branch 10.04, jQuery, SVN trunk
>
>         Attachments: OFBIZ-4022_collapse-all-broken.patch
>
>   Original Estimate: 0.33h
>  Remaining Estimate: 0.33h
>
> To reproduce the bug:
> - edit the EditProduct form in applications/product/widget/catalog/ProductForms.xml
> - add a new field with a hyperlink sub-element.
> - refer to this new field in the first, non-collapsible field-group in the sort-order
> - go to this page in the UI (edit a product in the catalog)
> - the Expand All and Collapse All buttons do not work properly
> The problem is caused by the javascript finding the added hyperlink field in the first field-group, and incorrectly assuming it is
> the expand/collapse link for the field-group. This causes the javascript to crash when it gets a null reference to an enclosing li element.
> It is not specific to the EditProduct form, but applies to any group of collapsible panes where one contains a hyperlink.
> The attached patch simply checks that the li element actually exists.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.