[jira] Created: (OFBIZ-3414) Work Effort Appliaction Is Broken In Trunk

[Nicolas Malin (Jira)]

Work Effort Appliaction Is Broken In Trunk
------------------------------------------

                 Key: OFBIZ-3414
                 URL: https://issues.apache.org/jira/browse/OFBIZ-3414
             Project: OFBiz
          Issue Type: Bug
          Components: workeffort
    Affects Versions: SVN trunk
            Reporter: Adrian Crum


The work effort application has become useless. There has been a major regression since R 9.04. See comments for details.


--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12801305#action_12801305 ]

Adrian Crum commented on OFBIZ-3414:
------------------------------------

Issue #1: The Find Work Efforts screen doesn't work.

Click on the Find button in the 9.04 demo (https://demo904.ofbiz.org/workeffort/control/FindWorkEffort). All work efforts are displayed.

Click on the Find button in the trunk demo (https://demo.ofbiz.org/workeffort/control/FindWorkEffort). Only some work efforts are displayed.

> Work Effort Appliaction Is Broken In Trunk
> ------------------------------------------
>
>                 Key: OFBIZ-3414
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3414
>             Project: OFBiz
>          Issue Type: Bug
>          Components: workeffort
>    Affects Versions: SVN trunk
>            Reporter: Adrian Crum
>
> The work effort application has become useless. There has been a major regression since R 9.04. See comments for details.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12801308#action_12801308 ]

Adrian Crum commented on OFBIZ-3414:
------------------------------------

Issue #2: Create/Edit Work Effort in Calendar screen doesn't work properly.

Go to the Calendar screen in the 9.04 demo (https://demo904.ofbiz.org/workeffort/control/day). Click on one of the Add New links. An Edit Work Effort screen appears that allows you to enter any type of work effort.

Go to the Calendar screen in the trunk demo (https://demo.ofbiz.org/workeffort/control/calendar). Click on one of the Add New links. A screen appears that only lets you enter very limited information, and only for an event. There is no way to enter another type of work effort.

> Work Effort Appliaction Is Broken In Trunk
> ------------------------------------------
>
>                 Key: OFBIZ-3414
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3414
>             Project: OFBiz
>          Issue Type: Bug
>          Components: workeffort
>    Affects Versions: SVN trunk
>            Reporter: Adrian Crum
>
> The work effort application has become useless. There has been a major regression since R 9.04. See comments for details.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum updated OFBIZ-3414:
-------------------------------

    Description:
The work effort application has become unusable. There has been a major regression since R 9.04. See comments for details.


  was:
The work effort application has become useless. There has been a major regression since R 9.04. See comments for details.

> Work Effort Appliaction Is Broken In Trunk
> ------------------------------------------
>
>                 Key: OFBIZ-3414
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3414
>             Project: OFBiz
>          Issue Type: Bug
>          Components: workeffort
>    Affects Versions: SVN trunk
>            Reporter: Adrian Crum
>
> The work effort application has become unusable. There has been a major regression since R 9.04. See comments for details.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum updated OFBIZ-3414:
-------------------------------

    Summary: Work Effort Application Is Broken In Trunk  (was: Work Effort Appliaction Is Broken In Trunk)

> Work Effort Application Is Broken In Trunk
> ------------------------------------------
>
>                 Key: OFBIZ-3414
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3414
>             Project: OFBiz
>          Issue Type: Bug
>          Components: workeffort
>    Affects Versions: SVN trunk
>            Reporter: Adrian Crum
>
> The work effort application has become unusable. There has been a major regression since R 9.04. See comments for details.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12801332#action_12801332 ]

Adrian Crum commented on OFBIZ-3414:
------------------------------------

Issue #3: The temporal expression demo doesn't work in either version.

Log into Work Efforts application as admin. Go to Calendar and select Month View. A staff meeting should appear on the first Monday of the month.

> Work Effort Application Is Broken In Trunk
> ------------------------------------------
>
>                 Key: OFBIZ-3414
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3414
>             Project: OFBiz
>          Issue Type: Bug
>          Components: workeffort
>    Affects Versions: SVN trunk
>            Reporter: Adrian Crum
>
> The work effort application has become unusable. There has been a major regression since R 9.04. See comments for details.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12801334#action_12801334 ]

Adrian Crum commented on OFBIZ-3414:
------------------------------------

Issue # 4: The iCalendar demo doesn't work (probably related to #3).

Using an iCalendar client, view this R 9.04 calendar:

https://demo904.ofbiz.org/iCalendar/CALENDAR_PUB_DEMO/test.ics

The staff meeting appears.

Using an iCalendar client, view this trunk calendar:

https://demo.ofbiz.org/iCalendar/CALENDAR_PUB_DEMO/test.ics

The calendar requires authentication. After logging in, no calendar appears.

> Work Effort Application Is Broken In Trunk
> ------------------------------------------
>
>                 Key: OFBIZ-3414
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3414
>             Project: OFBiz
>          Issue Type: Bug
>          Components: workeffort
>    Affects Versions: SVN trunk
>            Reporter: Adrian Crum
>
> The work effort application has become unusable. There has been a major regression since R 9.04. See comments for details.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12801353#action_12801353 ]

Jacques Le Roux commented on OFBIZ-3414:
----------------------------------------

Hi Adrian,

In order to better follow the status of each issue, I'd recomment to the commiters who will take care of them to create subtasks

Thanks

> Work Effort Application Is Broken In Trunk
> ------------------------------------------
>
>                 Key: OFBIZ-3414
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3414
>             Project: OFBiz
>          Issue Type: Bug
>          Components: workeffort
>    Affects Versions: SVN trunk
>            Reporter: Adrian Crum
>
> The work effort application has become unusable. There has been a major regression since R 9.04. See comments for details.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12801515#action_12801515 ]

Adrian Crum commented on OFBIZ-3414:
------------------------------------

Issue # 5: When editing a work effort, after clicking Save, you are taken to a calendar screen. This issue appears when certain steps are followed in order:

Go to the Calendar screen and click on any work effort that appears there. The limited edit work effort screen appears. Leave the work effort as-is and click on the application's Work Effort tab (the one that takes you to the Find Work Efforts screen). Click Find and select any work effort. Click Save on the Edit Work Effort screen. You are taken to a calendar screen after the work effort is saved. What should happen is you stay on the Edit Work Effort screen.

> Work Effort Application Is Broken In Trunk
> ------------------------------------------
>
>                 Key: OFBIZ-3414
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3414
>             Project: OFBiz
>          Issue Type: Bug
>          Components: workeffort
>    Affects Versions: SVN trunk
>            Reporter: Adrian Crum
>
> The work effort application has become unusable. There has been a major regression since R 9.04. See comments for details.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12801516#action_12801516 ]

Adrian Crum commented on OFBIZ-3414:
------------------------------------

Jacques,

I put all these issues in one Jira issue because they were all caused by one person, and my hope is that person will step up to the plate and fix the things they broke.

> Work Effort Application Is Broken In Trunk
> ------------------------------------------
>
>                 Key: OFBIZ-3414
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3414
>             Project: OFBiz
>          Issue Type: Bug
>          Components: workeffort
>    Affects Versions: SVN trunk
>            Reporter: Adrian Crum
>
> The work effort application has become unusable. There has been a major regression since R 9.04. See comments for details.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12801531#action_12801531 ]

Jacques Le Roux commented on OFBIZ-3414:
----------------------------------------

Ho, I see! Anyway, it might be helpful for this person to use subtasks ;)

> Work Effort Application Is Broken In Trunk
> ------------------------------------------
>
>                 Key: OFBIZ-3414
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3414
>             Project: OFBiz
>          Issue Type: Bug
>          Components: workeffort
>    Affects Versions: SVN trunk
>            Reporter: Adrian Crum
>
> The work effort application has become unusable. There has been a major regression since R 9.04. See comments for details.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hans Bakker reassigned OFBIZ-3414:
----------------------------------

    Assignee: Hans Bakker

> Work Effort Application Is Broken In Trunk
> ------------------------------------------
>
>                 Key: OFBIZ-3414
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3414
>             Project: OFBiz
>          Issue Type: Bug
>          Components: workeffort
>    Affects Versions: SVN trunk
>            Reporter: Adrian Crum
>            Assignee: Hans Bakker
>
> The work effort application has become unusable. There has been a major regression since R 9.04. See comments for details.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hans Bakker updated OFBIZ-3414:
-------------------------------

    Priority: Minor  (was: Major)

> Work Effort Application Is Broken In Trunk
> ------------------------------------------
>
>                 Key: OFBIZ-3414
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3414
>             Project: OFBiz
>          Issue Type: Bug
>          Components: workeffort
>    Affects Versions: SVN trunk
>            Reporter: Adrian Crum
>            Assignee: Hans Bakker
>            Priority: Minor
>
> The work effort application has become unusable. There has been a major regression since R 9.04. See comments for details.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12802021#action_12802021 ]

Hans Bakker commented on OFBIZ-3414:
------------------------------------

Thank you Adrian for finding these problems. It shows that the workeffort on itself is not much used however very much in projectmanagement, assetmaintanence, manufacturing, myportal and sfa where it is functions pretty well.
We will try fix it as quick as possible.

Regards,
Hans

> Work Effort Application Is Broken In Trunk
> ------------------------------------------
>
>                 Key: OFBIZ-3414
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3414
>             Project: OFBiz
>          Issue Type: Bug
>          Components: workeffort
>    Affects Versions: SVN trunk
>            Reporter: Adrian Crum
>            Assignee: Hans Bakker
>
> The work effort application has become unusable. There has been a major regression since R 9.04. See comments for details.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12802094#action_12802094 ]

Adrian Crum commented on OFBIZ-3414:
------------------------------------

Hans,

Thank you very much for taking care of this. My employer uses the Work Effort application out of the box, so it does get used.

> Work Effort Application Is Broken In Trunk
> ------------------------------------------
>
>                 Key: OFBIZ-3414
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3414
>             Project: OFBiz
>          Issue Type: Bug
>          Components: workeffort
>    Affects Versions: SVN trunk
>            Reporter: Adrian Crum
>            Assignee: Hans Bakker
>            Priority: Minor
>
> The work effort application has become unusable. There has been a major regression since R 9.04. See comments for details.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12802655#action_12802655 ]

Hans Bakker commented on OFBIZ-3414:
------------------------------------

Adrian,

i looked at you first problem, it is showing only the first few work efforts and the pagination is missing
add
      <set field="viewSize" value="100" type="Integer"/>
to the actions tag in the ListWorkEfforts form.

then it will show all workefforts. That it not shows the pagination is probably caused by the conversion from a list iterator to a list in the ListWorkEfforts form?

Regards,
Hans

> Work Effort Application Is Broken In Trunk
> ------------------------------------------
>
>                 Key: OFBIZ-3414
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3414
>             Project: OFBiz
>          Issue Type: Bug
>          Components: workeffort
>    Affects Versions: SVN trunk
>            Reporter: Adrian Crum
>            Assignee: Hans Bakker
>            Priority: Minor
>
> The work effort application has become unusable. There has been a major regression since R 9.04. See comments for details.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12802669#action_12802669 ]

Adrian Crum commented on OFBIZ-3414:
------------------------------------

The pagination works fine for me - but not all of the work efforts appear. I don't think the problem is in the form, I think it is in the method of finding all work efforts - some of them are being excluded.

> Work Effort Application Is Broken In Trunk
> ------------------------------------------
>
>                 Key: OFBIZ-3414
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3414
>             Project: OFBiz
>          Issue Type: Bug
>          Components: workeffort
>    Affects Versions: SVN trunk
>            Reporter: Adrian Crum
>            Assignee: Hans Bakker
>            Priority: Minor
>
> The work effort application has become unusable. There has been a major regression since R 9.04. See comments for details.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12802672#action_12802672 ]

Adrian Crum commented on OFBIZ-3414:
------------------------------------

Okay, that's odd. I had 35 work efforts appear on the Find screen. I created a new work effort event, and saved it. Now only a handful of work efforts appear on the Find screen. Something very strange is going on there.

> Work Effort Application Is Broken In Trunk
> ------------------------------------------
>
>                 Key: OFBIZ-3414
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3414
>             Project: OFBiz
>          Issue Type: Bug
>          Components: workeffort
>    Affects Versions: SVN trunk
>            Reporter: Adrian Crum
>            Assignee: Hans Bakker
>            Priority: Minor
>
> The work effort application has become unusable. There has been a major regression since R 9.04. See comments for details.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12802676#action_12802676 ]

Adrian Crum commented on OFBIZ-3414:
------------------------------------

Hans,

I don't have a lot of time to help you investigate, but I can give you some clues that might help. I had to fix the Find screen in revision 794327. The Find screen was listing a lot of duplicate work efforts - something it didn't do before. So, something broke between R 9.04 and trunk rev 794327.

> Work Effort Application Is Broken In Trunk
> ------------------------------------------
>
>                 Key: OFBIZ-3414
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3414
>             Project: OFBiz
>          Issue Type: Bug
>          Components: workeffort
>    Affects Versions: SVN trunk
>            Reporter: Adrian Crum
>            Assignee: Hans Bakker
>            Priority: Minor
>
> The work effort application has become unusable. There has been a major regression since R 9.04. See comments for details.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12802682#action_12802682 ]

Hans Bakker commented on OFBIZ-3414:
------------------------------------

Adrian,

this form is just using performFind which provides the list of the first
20 work efforts, then a duplicate workeffort service is included which
deletes the duplicates and convert it into a list

I did not touch this part of the system ever....

Regards,
Hans

> Work Effort Application Is Broken In Trunk
> ------------------------------------------
>
>                 Key: OFBIZ-3414
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3414
>             Project: OFBiz
>          Issue Type: Bug
>          Components: workeffort
>    Affects Versions: SVN trunk
>            Reporter: Adrian Crum
>            Assignee: Hans Bakker
>            Priority: Minor
>
> The work effort application has become unusable. There has been a major regression since R 9.04. See comments for details.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.