[jira] Created: (OFBIZ-3317) Update and correction for the visual HTML editor

[Nicolas Malin (Jira)]

Update and correction for the visual HTML editor
------------------------------------------------

                 Key: OFBIZ-3317
                 URL: https://issues.apache.org/jira/browse/OFBIZ-3317
             Project: OFBiz
          Issue Type: Improvement
          Components: content
    Affects Versions: SVN trunk
            Reporter: Erwan de FERRIERES
             Fix For: SVN trunk
         Attachments: OFBIZ-3317.diff, WhizzywigToolbar.png

the visual editor is using this line to fix a minimum height for the textarea box.
 if (!o(idTa).rows < 5) o(idTa).rows='15';//IE won't use % from style

No matter the size we give it, it stays at 15. So I commented the line in the .js file. While I was at it, I updated whizzywig.js to the last version (55i ->59) and put the new toolbar icons system

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Erwan de FERRIERES updated OFBIZ-3317:
--------------------------------------

    Attachment: WhizzywigToolbar.png
                OFBIZ-3317.diff

the patch and the new toolbar

> Update and correction for the visual HTML editor
> ------------------------------------------------
>
>                 Key: OFBIZ-3317
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3317
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: content
>    Affects Versions: SVN trunk
>            Reporter: Erwan de FERRIERES
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3317.diff, WhizzywigToolbar.png
>
>
> the visual editor is using this line to fix a minimum height for the textarea box.
>  if (!o(idTa).rows < 5) o(idTa).rows='15';//IE won't use % from style
> No matter the size we give it, it stays at 15. So I commented the line in the .js file. While I was at it, I updated whizzywig.js to the last version (55i ->59) and put the new toolbar icons system

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12788041#action_12788041 ]

Jacques Le Roux commented on OFBIZ-3317:
----------------------------------------

Erwan,

Don't we need the image files ? Also did you check that this has no side-effects in IE ([at least IE6, 7, 8|http://gs.statcounter.com/#browser_version-ww-monthly-200811-200912])

> Update and correction for the visual HTML editor
> ------------------------------------------------
>
>                 Key: OFBIZ-3317
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3317
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: content
>    Affects Versions: SVN trunk
>            Reporter: Erwan de FERRIERES
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3317.diff, WhizzywigToolbar.png
>
>
> the visual editor is using this line to fix a minimum height for the textarea box.
>  if (!o(idTa).rows < 5) o(idTa).rows='15';//IE won't use % from style
> No matter the size we give it, it stays at 15. So I commented the line in the .js file. While I was at it, I updated whizzywig.js to the last version (55i ->59) and put the new toolbar icons system

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12788044#action_12788044 ]

Erwan de FERRIERES commented on OFBIZ-3317:
-------------------------------------------

Jacques,

for the images, no need, it has been replaced by the toolbar. For IE testing, I'll see what I can do, but over here, finding a windows computer is too hard and would be the 13th  labour of Hercules !!

> Update and correction for the visual HTML editor
> ------------------------------------------------
>
>                 Key: OFBIZ-3317
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3317
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: content
>    Affects Versions: SVN trunk
>            Reporter: Erwan de FERRIERES
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3317.diff, WhizzywigToolbar.png
>
>
> the visual editor is using this line to fix a minimum height for the textarea box.
>  if (!o(idTa).rows < 5) o(idTa).rows='15';//IE won't use % from style
> No matter the size we give it, it stays at 15. So I commented the line in the .js file. While I was at it, I updated whizzywig.js to the last version (55i ->59) and put the new toolbar icons system

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Erwan de FERRIERES updated OFBIZ-3317:
--------------------------------------

    Attachment: ie6.png

you are so lucky ! Tested with IE6 and working

> Update and correction for the visual HTML editor
> ------------------------------------------------
>
>                 Key: OFBIZ-3317
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3317
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: content
>    Affects Versions: SVN trunk
>            Reporter: Erwan de FERRIERES
>             Fix For: SVN trunk
>
>         Attachments: ie6.png, OFBIZ-3317.diff, WhizzywigToolbar.png
>
>
> the visual editor is using this line to fix a minimum height for the textarea box.
>  if (!o(idTa).rows < 5) o(idTa).rows='15';//IE won't use % from style
> No matter the size we give it, it stays at 15. So I commented the line in the .js file. While I was at it, I updated whizzywig.js to the last version (55i ->59) and put the new toolbar icons system

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12788331#action_12788331 ]

Jacques Le Roux commented on OFBIZ-3317:
----------------------------------------

Thanks Erwan,

About the images: then why there are references to images in your patch, should we remove them?

> Update and correction for the visual HTML editor
> ------------------------------------------------
>
>                 Key: OFBIZ-3317
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3317
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: content
>    Affects Versions: SVN trunk
>            Reporter: Erwan de FERRIERES
>             Fix For: SVN trunk
>
>         Attachments: ie6.png, OFBIZ-3317.diff, WhizzywigToolbar.png
>
>
> the visual editor is using this line to fix a minimum height for the textarea box.
>  if (!o(idTa).rows < 5) o(idTa).rows='15';//IE won't use % from style
> No matter the size we give it, it stays at 15. So I commented the line in the .js file. While I was at it, I updated whizzywig.js to the last version (55i ->59) and put the new toolbar icons system

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12788339#action_12788339 ]

Erwan de FERRIERES commented on OFBIZ-3317:
-------------------------------------------

Yes we have ! the images are no more needed with this editor's version as we replace them with the toolbar

> Update and correction for the visual HTML editor
> ------------------------------------------------
>
>                 Key: OFBIZ-3317
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3317
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: content
>    Affects Versions: SVN trunk
>            Reporter: Erwan de FERRIERES
>             Fix For: SVN trunk
>
>         Attachments: ie6.png, OFBIZ-3317.diff, WhizzywigToolbar.png
>
>
> the visual editor is using this line to fix a minimum height for the textarea box.
>  if (!o(idTa).rows < 5) o(idTa).rows='15';//IE won't use % from style
> No matter the size we give it, it stays at 15. So I commented the line in the .js file. While I was at it, I updated whizzywig.js to the last version (55i ->59) and put the new toolbar icons system

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12788357#action_12788357 ]

Jacques Le Roux commented on OFBIZ-3317:
----------------------------------------

Oops, sorry did to see the attached file :(

> Update and correction for the visual HTML editor
> ------------------------------------------------
>
>                 Key: OFBIZ-3317
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3317
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: content
>    Affects Versions: SVN trunk
>            Reporter: Erwan de FERRIERES
>             Fix For: SVN trunk
>
>         Attachments: ie6.png, OFBIZ-3317.diff, WhizzywigToolbar.png
>
>
> the visual editor is using this line to fix a minimum height for the textarea box.
>  if (!o(idTa).rows < 5) o(idTa).rows='15';//IE won't use % from style
> No matter the size we give it, it stays at 15. So I commented the line in the .js file. While I was at it, I updated whizzywig.js to the last version (55i ->59) and put the new toolbar icons system

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12788355#action_12788355 ]

Jacques Le Roux commented on OFBIZ-3317:
----------------------------------------

Erwan

Sorry but I do need  (at least WhizzywigToolbar.png). There are 42 images in framework/images/webapp/images/htmledit, so from your files it seems ok to remiove them all (I counted 42)

> Update and correction for the visual HTML editor
> ------------------------------------------------
>
>                 Key: OFBIZ-3317
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3317
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: content
>    Affects Versions: SVN trunk
>            Reporter: Erwan de FERRIERES
>             Fix For: SVN trunk
>
>         Attachments: ie6.png, OFBIZ-3317.diff, WhizzywigToolbar.png
>
>
> the visual editor is using this line to fix a minimum height for the textarea box.
>  if (!o(idTa).rows < 5) o(idTa).rows='15';//IE won't use % from style
> No matter the size we give it, it stays at 15. So I commented the line in the .js file. While I was at it, I updated whizzywig.js to the last version (55i ->59) and put the new toolbar icons system

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12788369#action_12788369 ]

Jacques Le Roux commented on OFBIZ-3317:
----------------------------------------

Oops,

On Windows XP with FF3.5.5, just typing (1st key) to edit at https://localhost:58443/content/control/findForumMessages?forumGroupId=WebStoreFORUM&forumId=ASK I got  (I removed the addons line, I have plenty of them, 56 actually)

BuildID: 20091102152451
CrashTime: 1260398779
Email: [hidden email]
InstallTime: 1257495660
ProductName: Firefox
SecondsSinceLastCrash: 34262
StartupTime: 1260367077
Theme: classic/1.0
Throttleable: 1
URL: https://localhost:58443/content/control/findForumMessages?forumGroupId=WebStoreFORUM&forumId=ASK
Vendor: Mozilla
Version: 3.5.5

Ce rapport contient également des informations techniques sur l'état de l'application lors du plantage.

> Update and correction for the visual HTML editor
> ------------------------------------------------
>
>                 Key: OFBIZ-3317
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3317
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: content
>    Affects Versions: SVN trunk
>            Reporter: Erwan de FERRIERES
>             Fix For: SVN trunk
>
>         Attachments: ie6.png, OFBIZ-3317.diff, WhizzywigToolbar.png
>
>
> the visual editor is using this line to fix a minimum height for the textarea box.
>  if (!o(idTa).rows < 5) o(idTa).rows='15';//IE won't use % from style
> No matter the size we give it, it stays at 15. So I commented the line in the .js file. While I was at it, I updated whizzywig.js to the last version (55i ->59) and put the new toolbar icons system

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12788372#action_12788372 ]

Jacques Le Roux commented on OFBIZ-3317:
----------------------------------------

I was not able to reproducen, maybe not related... I will commit soon. I got another error in eCommerce while looking at the message created in forum
Also the html area is used for new message creation in backend (Content) but not for existing messages where plain text is show. Too much for me tonight...

> Update and correction for the visual HTML editor
> ------------------------------------------------
>
>                 Key: OFBIZ-3317
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3317
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: content
>    Affects Versions: SVN trunk
>            Reporter: Erwan de FERRIERES
>             Fix For: SVN trunk
>
>         Attachments: ie6.png, OFBIZ-3317.diff, WhizzywigToolbar.png
>
>
> the visual editor is using this line to fix a minimum height for the textarea box.
>  if (!o(idTa).rows < 5) o(idTa).rows='15';//IE won't use % from style
> No matter the size we give it, it stays at 15. So I commented the line in the .js file. While I was at it, I updated whizzywig.js to the last version (55i ->59) and put the new toolbar icons system

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-3317.
----------------------------------

    Resolution: Fixed
      Assignee: Jacques Le Roux

Thanks Erwan,

Your patch is in trunk at r889014  

> Update and correction for the visual HTML editor
> ------------------------------------------------
>
>                 Key: OFBIZ-3317
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3317
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: content
>    Affects Versions: SVN trunk
>            Reporter: Erwan de FERRIERES
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: ie6.png, OFBIZ-3317.diff, WhizzywigToolbar.png
>
>
> the visual editor is using this line to fix a minimum height for the textarea box.
>  if (!o(idTa).rows < 5) o(idTa).rows='15';//IE won't use % from style
> No matter the size we give it, it stays at 15. So I commented the line in the .js file. While I was at it, I updated whizzywig.js to the last version (55i ->59) and put the new toolbar icons system

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12788561#action_12788561 ]

Jacques Le Roux commented on OFBIZ-3317:
----------------------------------------

I forgot the image, Completed: At revision: 889122  

> Update and correction for the visual HTML editor
> ------------------------------------------------
>
>                 Key: OFBIZ-3317
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3317
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: content
>    Affects Versions: SVN trunk
>            Reporter: Erwan de FERRIERES
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: ie6.png, OFBIZ-3317.diff, WhizzywigToolbar.png
>
>
> the visual editor is using this line to fix a minimum height for the textarea box.
>  if (!o(idTa).rows < 5) o(idTa).rows='15';//IE won't use % from style
> No matter the size we give it, it stays at 15. So I commented the line in the .js file. While I was at it, I updated whizzywig.js to the last version (55i ->59) and put the new toolbar icons system

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.