[jira] Created: (OFBIZ-3307) Error in product attributes page.

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (OFBIZ-3307) Error in product attributes page.

Nicolas Malin (Jira)
Error in product attributes page.
---------------------------------

                 Key: OFBIZ-3307
                 URL: https://issues.apache.org/jira/browse/OFBIZ-3307
             Project: OFBiz
          Issue Type: Bug
    Affects Versions: SVN trunk
         Environment: Linux Fedora Core 9, Postgres.
            Reporter: Rohit Sureka
             Fix For: SVN trunk


The 'Add Product Attribute' has a drop down list for attribute name. if the product does not already have a existing product, its not possible to add a new attribute, since the attribute field is a required field but which is blank. This problem does not exist in R9.04 where it was not a dropdown but a simple text field .

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Assigned: (OFBIZ-3307) Error in product attributes page.

Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-3307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Scott Gray reassigned OFBIZ-3307:
---------------------------------

    Assignee: Hans Bakker

Assigning to Hans so that he can explain to Rohit how a user might introduce new product attributes since his changes in r830846.

The changes removed some functionality that was previously available to the user and IMO should either be reverted or improved.

> Error in product attributes page.
> ---------------------------------
>
>                 Key: OFBIZ-3307
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3307
>             Project: OFBiz
>          Issue Type: Bug
>    Affects Versions: SVN trunk
>         Environment: Linux Fedora Core 9, Postgres.
>            Reporter: Rohit Sureka
>            Assignee: Hans Bakker
>             Fix For: SVN trunk
>
>
> The 'Add Product Attribute' has a drop down list for attribute name. if the product does not already have a existing product, its not possible to add a new attribute, since the attribute field is a required field but which is blank. This problem does not exist in R9.04 where it was not a dropdown but a simple text field .

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-3307) Error in product attributes page.

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-3307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12802012#action_12802012 ]

Hans Bakker commented on OFBIZ-3307:
------------------------------------

we found that although a table of available attributes is present the assigned attributes were not validated against that table. We needed this for a customer, however it is currently not used here anymore.

Please feel free to revert the change if you think that is better.

Regards,
Hans

> Error in product attributes page.
> ---------------------------------
>
>                 Key: OFBIZ-3307
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3307
>             Project: OFBiz
>          Issue Type: Bug
>    Affects Versions: SVN trunk
>         Environment: Linux Fedora Core 9, Postgres.
>            Reporter: Rohit Sureka
>            Assignee: Hans Bakker
>             Fix For: SVN trunk
>
>
> The 'Add Product Attribute' has a drop down list for attribute name. if the product does not already have a existing product, its not possible to add a new attribute, since the attribute field is a required field but which is blank. This problem does not exist in R9.04 where it was not a dropdown but a simple text field .

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Assigned: (OFBIZ-3307) Error in product attributes page.

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-3307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Scott Gray reassigned OFBIZ-3307:
---------------------------------

    Assignee: Scott Gray  (was: Hans Bakker)

Thanks for the info Hans.

I think the problem is that while ProductTypeAttr can be used in this way, it shouldn't be enforced unless the data model is also enforcing this constraint.  The other problem is that I think there is no way currently to add ProductTypeAttr records, which means that with these changes no new attributes can be created via the UI.

> Error in product attributes page.
> ---------------------------------
>
>                 Key: OFBIZ-3307
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3307
>             Project: OFBiz
>          Issue Type: Bug
>    Affects Versions: SVN trunk
>         Environment: Linux Fedora Core 9, Postgres.
>            Reporter: Rohit Sureka
>            Assignee: Scott Gray
>             Fix For: SVN trunk
>
>
> The 'Add Product Attribute' has a drop down list for attribute name. if the product does not already have a existing product, its not possible to add a new attribute, since the attribute field is a required field but which is blank. This problem does not exist in R9.04 where it was not a dropdown but a simple text field .

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-3307) Error in product attributes page.

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-3307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12802035#action_12802035 ]

Hans Bakker commented on OFBIZ-3307:
------------------------------------

Hi Scott,

we considered the attribute similar to saleschannel, that it will be
maintained in webtools. If you could add this, if you need this, would
make this part of the product maintenance more perfect....

Regards,
Hans




> Error in product attributes page.
> ---------------------------------
>
>                 Key: OFBIZ-3307
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3307
>             Project: OFBiz
>          Issue Type: Bug
>    Affects Versions: SVN trunk
>         Environment: Linux Fedora Core 9, Postgres.
>            Reporter: Rohit Sureka
>            Assignee: Scott Gray
>             Fix For: SVN trunk
>
>
> The 'Add Product Attribute' has a drop down list for attribute name. if the product does not already have a existing product, its not possible to add a new attribute, since the attribute field is a required field but which is blank. This problem does not exist in R9.04 where it was not a dropdown but a simple text field .

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-3307) Error in product attributes page.

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-3307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12802341#action_12802341 ]

Scott Gray commented on OFBIZ-3307:
-----------------------------------

Hi Hans,

As I mentioned in my previous comment, I don't believe that ProductTypeAttr was intended as being the only way to manage ProductAttribute records, if it were then foreign keys would enforce the relationship and not allow for arbitrary attrNames.

I'm not sure what you mean by maintaining SalesChannel and ProductTypeAttr records in webtools, do you mean that the user should just manually enter the records using the entity data maintenance tools?  If so I don't think that is an ideal solution for either entity.

IMO the best solution would be to add a screen to the catalog app for maintaining ProductTypeAttr records and then also add another form to the Product -> Attributes screen so that the user has a choice of either creating a record based on a predefined ProductTypeAttr or to create a new arbitrary ProductAttribute record.

I have no desire to implement these features and was merely trying to resolve some bugs in my spare time.  My preference would be revert the current change simply because it removed functionality that was previously available to users.  It has obviously had a negative effect or otherwise this issue would never have been created.

> Error in product attributes page.
> ---------------------------------
>
>                 Key: OFBIZ-3307
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3307
>             Project: OFBiz
>          Issue Type: Bug
>    Affects Versions: SVN trunk
>         Environment: Linux Fedora Core 9, Postgres.
>            Reporter: Rohit Sureka
>            Assignee: Scott Gray
>             Fix For: SVN trunk
>
>
> The 'Add Product Attribute' has a drop down list for attribute name. if the product does not already have a existing product, its not possible to add a new attribute, since the attribute field is a required field but which is blank. This problem does not exist in R9.04 where it was not a dropdown but a simple text field .

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

Re: [jira] Commented: (OFBIZ-3307) Error in product attributes page.

hans_bakker
Scott, whatever you think is best.

Regards,
Hans

On Tue, 2010-01-19 at 17:13 +0000, Scott Gray (JIRA) wrote:

> [ https://issues.apache.org/jira/browse/OFBIZ-3307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12802341#action_12802341 ]
>
> Scott Gray commented on OFBIZ-3307:
> -----------------------------------
>
> Hi Hans,
>
> As I mentioned in my previous comment, I don't believe that ProductTypeAttr was intended as being the only way to manage ProductAttribute records, if it were then foreign keys would enforce the relationship and not allow for arbitrary attrNames.
>
> I'm not sure what you mean by maintaining SalesChannel and ProductTypeAttr records in webtools, do you mean that the user should just manually enter the records using the entity data maintenance tools?  If so I don't think that is an ideal solution for either entity.
>
> IMO the best solution would be to add a screen to the catalog app for maintaining ProductTypeAttr records and then also add another form to the Product -> Attributes screen so that the user has a choice of either creating a record based on a predefined ProductTypeAttr or to create a new arbitrary ProductAttribute record.
>
> I have no desire to implement these features and was merely trying to resolve some bugs in my spare time.  My preference would be revert the current change simply because it removed functionality that was previously available to users.  It has obviously had a negative effect or otherwise this issue would never have been created.
>
> > Error in product attributes page.
> > ---------------------------------
> >
> >                 Key: OFBIZ-3307
> >                 URL: https://issues.apache.org/jira/browse/OFBIZ-3307
> >             Project: OFBiz
> >          Issue Type: Bug
> >    Affects Versions: SVN trunk
> >         Environment: Linux Fedora Core 9, Postgres.
> >            Reporter: Rohit Sureka
> >            Assignee: Scott Gray
> >             Fix For: SVN trunk
> >
> >
> > The 'Add Product Attribute' has a drop down list for attribute name. if the product does not already have a existing product, its not possible to add a new attribute, since the attribute field is a required field but which is blank. This problem does not exist in R9.04 where it was not a dropdown but a simple text field .
>
--
Antwebsystems.com: Quality OFBiz services for competitive rates

Reply | Threaded
Open this post in threaded view
|

[jira] Closed: (OFBIZ-3307) Error in product attributes page.

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-3307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Scott Gray closed OFBIZ-3307.
-----------------------------

    Resolution: Fixed

Fixed via revert in r900992.  Thanks Rohit for the report and Hans for your input.

> Error in product attributes page.
> ---------------------------------
>
>                 Key: OFBIZ-3307
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3307
>             Project: OFBiz
>          Issue Type: Bug
>    Affects Versions: SVN trunk
>         Environment: Linux Fedora Core 9, Postgres.
>            Reporter: Rohit Sureka
>            Assignee: Scott Gray
>             Fix For: SVN trunk
>
>
> The 'Add Product Attribute' has a drop down list for attribute name. if the product does not already have a existing product, its not possible to add a new attribute, since the attribute field is a required field but which is blank. This problem does not exist in R9.04 where it was not a dropdown but a simple text field .

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.