[jira] Created: (OFBIZ-3289) FinAccountReconciliation - Reconcilie finAccountTrans which are in created state only.

[Nicolas Malin (Jira)]

FinAccountReconciliation - Reconcilie finAccountTrans which are in created state only.
--------------------------------------------------------------------------------------

                 Key: OFBIZ-3289
                 URL: https://issues.apache.org/jira/browse/OFBIZ-3289
             Project: OFBiz
          Issue Type: Improvement
          Components: accounting
            Reporter: Sumit Pandit
            Priority: Minor
             Fix For: SVN trunk


For reconciliation FinAccountTrans need to be in CREATED status. Ignore any finAccountTransaction which is in Approved or Canceled status and associate to GlReconciliation.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sumit Pandit updated OFBIZ-3289:
--------------------------------

    Attachment: OFBIZ-3289.patch

Patch for issue.

> FinAccountReconciliation - Reconcilie finAccountTrans which are in created state only.
> --------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-3289
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3289
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Sumit Pandit
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3289.patch
>
>
> For reconciliation FinAccountTrans need to be in CREATED status. Ignore any finAccountTransaction which is in Approved or Canceled status and associate to GlReconciliation.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Anil K Patel reassigned OFBIZ-3289:
-----------------------------------

    Assignee: Anil K Patel

> FinAccountReconciliation - Reconcilie finAccountTrans which are in created state only.
> --------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-3289
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3289
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Sumit Pandit
>            Assignee: Anil K Patel
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3289.patch
>
>
> For reconciliation FinAccountTrans need to be in CREATED status. Ignore any finAccountTransaction which is in Approved or Canceled status and associate to GlReconciliation.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12785080#action_12785080 ]

Anil K Patel commented on OFBIZ-3289:
-------------------------------------

What if Transaction is not in FINACT_TRNS_CREATED status?

I think you should return error.

> FinAccountReconciliation - Reconcilie finAccountTrans which are in created state only.
> --------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-3289
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3289
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Sumit Pandit
>            Assignee: Anil K Patel
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3289.patch
>
>
> For reconciliation FinAccountTrans need to be in CREATED status. Ignore any finAccountTransaction which is in Approved or Canceled status and associate to GlReconciliation.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12785137#action_12785137 ]

Sumit Pandit commented on OFBIZ-3289:
-------------------------------------

Thanks Anil for your comment here, It can be considered as business process according to which - A reconciliationid can't reconciled if its any transaction have Canceled status.
Is that right?

> FinAccountReconciliation - Reconcilie finAccountTrans which are in created state only.
> --------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-3289
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3289
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Sumit Pandit
>            Assignee: Anil K Patel
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3289.patch
>
>
> For reconciliation FinAccountTrans need to be in CREATED status. Ignore any finAccountTransaction which is in Approved or Canceled status and associate to GlReconciliation.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12785144#action_12785144 ]

Anil K Patel commented on OFBIZ-3289:
-------------------------------------

It depends, One important issue I see is, with this patch we are silently ignoring transactions that are not in FINACT_TRNS_CREATED. This cannot be done. User processes should be notified about the action. Based on how many valid status can a financial transaction have while also be part of reconciliation, you may decide different strategy for checks and return message.

> FinAccountReconciliation - Reconcilie finAccountTrans which are in created state only.
> --------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-3289
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3289
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Sumit Pandit
>            Assignee: Anil K Patel
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3289.patch
>
>
> For reconciliation FinAccountTrans need to be in CREATED status. Ignore any finAccountTransaction which is in Approved or Canceled status and associate to GlReconciliation.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12791071#action_12791071 ]

Sumit Pandit commented on OFBIZ-3289:
-------------------------------------

For a scenario when reconciliation's transactions are in canceled or approved status, can't reconciled until its all transactions doesn't come in created status.
In such case Canceled -> Created or Approved -> Created is not valid change for finAccountTrans. So here it is required to make sure that, at an instance all transactions of a  reconciliation must be in created status. It can be achieve by restrict user to update the status of any transaction if it is associated to reconciliation.
By doing so we won't have any case where reconciliation have transactions other then CREATED status.
Your thoughts and guidance would be helpful.

> FinAccountReconciliation - Reconcilie finAccountTrans which are in created state only.
> --------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-3289
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3289
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Sumit Pandit
>            Assignee: Anil K Patel
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3289.patch
>
>
> For reconciliation FinAccountTrans need to be in CREATED status. Ignore any finAccountTransaction which is in Approved or Canceled status and associate to GlReconciliation.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12791148#action_12791148 ]

Anil K Patel commented on OFBIZ-3289:
-------------------------------------

I agree with your above comments.
We should write a service that will check if FinAccountTrans is added to reconciliation. If it is then its status change should not be allowed.

> FinAccountReconciliation - Reconcilie finAccountTrans which are in created state only.
> --------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-3289
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3289
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Sumit Pandit
>            Assignee: Anil K Patel
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3289.patch
>
>
> For reconciliation FinAccountTrans need to be in CREATED status. Ignore any finAccountTransaction which is in Approved or Canceled status and associate to GlReconciliation.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sumit Pandit updated OFBIZ-3289:
--------------------------------

    Attachment: OFBIZ_3289_2.patch

Thanks Anil for your comment, Please find the patch for fix.

> FinAccountReconciliation - Reconcilie finAccountTrans which are in created state only.
> --------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-3289
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3289
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Sumit Pandit
>            Assignee: Anil K Patel
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3289.patch, OFBIZ_3289_2.patch
>
>
> For reconciliation FinAccountTrans need to be in CREATED status. Ignore any finAccountTransaction which is in Approved or Canceled status and associate to GlReconciliation.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.