[jira] Created: (OFBIZ-3254) Setting viewSize and viewIndex in screen context for List Forms do not work

[Nicolas Malin (Jira)]

Setting viewSize and viewIndex in screen context for List Forms do not work
---------------------------------------------------------------------------

                 Key: OFBIZ-3254
                 URL: https://issues.apache.org/jira/browse/OFBIZ-3254
             Project: OFBiz
          Issue Type: Bug
          Components: framework
    Affects Versions: Release Branch 9.04, SVN trunk
            Reporter: Mridul Pathak
             Fix For: Release Branch 9.04, SVN trunk


With the support of multi pagination in Form Widgets, following piece of code which has several occurrences across the framework is not functional anymore:
{code:xml}
<set field="viewIndex" from-field="parameters.VIEW_INDEX" default-value="0">
<set field="viewSize" from-field="parameters.VIEW_SIZE" default-value="some-value">
{code}
The above can be tested at https://demo.ofbiz.org/accounting/control/globalGLSettings, where in screen default viewSize has been set to 50, but the list is rendered with viewSize 20.

The reason is that when fetching these values from screen context, the paginator number is appended to paginateSizeField and DEFAULT_PAGE_SIZE_FIELD.  To set the default value in screen context, you will need to set viewSize_${paginatorNumber} (for a screen with single list form it would be viewSize_1).
With multiple list forms in a screen, this becomes more complex to set the global view size multiple times, which is ok in some cases.  But the support to set viewSize and viewIndex globally with no paginator number must exist.  If the support is added back, all the occurrences of above code will be automatically functional again.

The code should work in following fashion; check for ${paginateSizeField}_paginatorNumber or ${DEFAULT_PAGE_SIZE_FIELD}_paginatorNumber in context, if it is null check for these fields with no paginatorNumber appended.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mridul Pathak updated OFBIZ-3254:
---------------------------------

    Attachment: OFBIZ-3254.patch

Here is the patch for the fix.

> Setting viewSize and viewIndex in screen context for List Forms do not work
> ---------------------------------------------------------------------------
>
>                 Key: OFBIZ-3254
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3254
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release Branch 9.04, SVN trunk
>            Reporter: Mridul Pathak
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: OFBIZ-3254.patch
>
>
> With the support of multi pagination in Form Widgets, following piece of code which has several occurrences across the framework is not functional anymore:
> {code:xml}
> <set field="viewIndex" from-field="parameters.VIEW_INDEX" default-value="0">
> <set field="viewSize" from-field="parameters.VIEW_SIZE" default-value="some-value">
> {code}
> The above can be tested at https://demo.ofbiz.org/accounting/control/globalGLSettings, where in screen default viewSize has been set to 50, but the list is rendered with viewSize 20.
> The reason is that when fetching these values from screen context, the paginator number is appended to paginateSizeField and DEFAULT_PAGE_SIZE_FIELD.  To set the default value in screen context, you will need to set viewSize_${paginatorNumber} (for a screen with single list form it would be viewSize_1).
> With multiple list forms in a screen, this becomes more complex to set the global view size multiple times, which is ok in some cases.  But the support to set viewSize and viewIndex globally with no paginator number must exist.  If the support is added back, all the occurrences of above code will be automatically functional again.
> The code should work in following fashion; check for ${paginateSizeField}_paginatorNumber or ${DEFAULT_PAGE_SIZE_FIELD}_paginatorNumber in context, if it is null check for these fields with no paginatorNumber appended.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bilgin Ibryam reassigned OFBIZ-3254:
------------------------------------

    Assignee: Bilgin Ibryam

> Setting viewSize and viewIndex in screen context for List Forms do not work
> ---------------------------------------------------------------------------
>
>                 Key: OFBIZ-3254
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3254
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release Branch 9.04, SVN trunk
>            Reporter: Mridul Pathak
>            Assignee: Bilgin Ibryam
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: OFBIZ-3254.patch
>
>
> With the support of multi pagination in Form Widgets, following piece of code which has several occurrences across the framework is not functional anymore:
> {code:xml}
> <set field="viewIndex" from-field="parameters.VIEW_INDEX" default-value="0">
> <set field="viewSize" from-field="parameters.VIEW_SIZE" default-value="some-value">
> {code}
> The above can be tested at https://demo.ofbiz.org/accounting/control/globalGLSettings, where in screen default viewSize has been set to 50, but the list is rendered with viewSize 20.
> The reason is that when fetching these values from screen context, the paginator number is appended to paginateSizeField and DEFAULT_PAGE_SIZE_FIELD.  To set the default value in screen context, you will need to set viewSize_${paginatorNumber} (for a screen with single list form it would be viewSize_1).
> With multiple list forms in a screen, this becomes more complex to set the global view size multiple times, which is ok in some cases.  But the support to set viewSize and viewIndex globally with no paginator number must exist.  If the support is added back, all the occurrences of above code will be automatically functional again.
> The code should work in following fashion; check for ${paginateSizeField}_paginatorNumber or ${DEFAULT_PAGE_SIZE_FIELD}_paginatorNumber in context, if it is null check for these fields with no paginatorNumber appended.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bilgin Ibryam closed OFBIZ-3254.
--------------------------------

    Resolution: Fixed

Thnaks Mridul.

Your patch is in trunk r885724 and ofbiz9.4 r885732

> Setting viewSize and viewIndex in screen context for List Forms do not work
> ---------------------------------------------------------------------------
>
>                 Key: OFBIZ-3254
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3254
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release Branch 9.04, SVN trunk
>            Reporter: Mridul Pathak
>            Assignee: Bilgin Ibryam
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: OFBIZ-3254.patch
>
>
> With the support of multi pagination in Form Widgets, following piece of code which has several occurrences across the framework is not functional anymore:
> {code:xml}
> <set field="viewIndex" from-field="parameters.VIEW_INDEX" default-value="0">
> <set field="viewSize" from-field="parameters.VIEW_SIZE" default-value="some-value">
> {code}
> The above can be tested at https://demo.ofbiz.org/accounting/control/globalGLSettings, where in screen default viewSize has been set to 50, but the list is rendered with viewSize 20.
> The reason is that when fetching these values from screen context, the paginator number is appended to paginateSizeField and DEFAULT_PAGE_SIZE_FIELD.  To set the default value in screen context, you will need to set viewSize_${paginatorNumber} (for a screen with single list form it would be viewSize_1).
> With multiple list forms in a screen, this becomes more complex to set the global view size multiple times, which is ok in some cases.  But the support to set viewSize and viewIndex globally with no paginator number must exist.  If the support is added back, all the occurrences of above code will be automatically functional again.
> The code should work in following fashion; check for ${paginateSizeField}_paginatorNumber or ${DEFAULT_PAGE_SIZE_FIELD}_paginatorNumber in context, if it is null check for these fields with no paginatorNumber appended.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.