[jira] Created: (OFBIZ-3253) possible bug with adding an item to an order that has a canceled item

[Nicolas Malin (Jira)]

possible bug with adding an item to an order that has a canceled item
---------------------------------------------------------------------

                 Key: OFBIZ-3253
                 URL: https://issues.apache.org/jira/browse/OFBIZ-3253
             Project: OFBiz
          Issue Type: Bug
          Components: order
    Affects Versions: Release Branch 4.0
            Reporter: Albert Mayo


1. I created an order with GZ-1000 and GZ-1004.
2. I canceled the GZ-1004 item.
3. I added GZ-1001 to the order.

Instead of putting GZ-1001 as a new line item, it looks like GZ-1001 replaces the GZ-1004 line item.

I say it is a possible bug because I do not know if this is the functional intent.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12781552#action_12781552 ]

Albert Mayo commented on OFBIZ-3253:
------------------------------------

This happens because because the service "loadCartFromOrder" is called from the function "loadCartForUpdate".  Inside the service loadCartFromOrder, the only items that are loaded into the cart are the "valid" order items with the function OrderReadHelper.getValidOrderItems, which exclude canceled items.

When items are added and the makeOrderItems function is called, it will use the next item sequence number which could be the same number of the canceled item.

> possible bug with adding an item to an order that has a canceled item
> ---------------------------------------------------------------------
>
>                 Key: OFBIZ-3253
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3253
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: Release Branch 4.0
>            Reporter: Albert Mayo
>
> 1. I created an order with GZ-1000 and GZ-1004.
> 2. I canceled the GZ-1004 item.
> 3. I added GZ-1001 to the order.
> Instead of putting GZ-1001 as a new line item, it looks like GZ-1001 replaces the GZ-1004 line item.
> I say it is a possible bug because I do not know if this is the functional intent.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12781600#action_12781600 ]

Albert Mayo commented on OFBIZ-3253:
------------------------------------

I just tried the test outlined above on the public 9.04 DEMO OFBiz and had the same results.  It looks like the error only happens when the last item is canceled.

> possible bug with adding an item to an order that has a canceled item
> ---------------------------------------------------------------------
>
>                 Key: OFBIZ-3253
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3253
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: Release Branch 4.0
>            Reporter: Albert Mayo
>
> 1. I created an order with GZ-1000 and GZ-1004.
> 2. I canceled the GZ-1004 item.
> 3. I added GZ-1001 to the order.
> Instead of putting GZ-1001 as a new line item, it looks like GZ-1001 replaces the GZ-1004 line item.
> I say it is a possible bug because I do not know if this is the functional intent.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Albert Mayo updated OFBIZ-3253:
-------------------------------

    Affects Version/s: Release Branch 9.04

> possible bug with adding an item to an order that has a canceled item
> ---------------------------------------------------------------------
>
>                 Key: OFBIZ-3253
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3253
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: Release Branch 4.0, Release Branch 9.04
>            Reporter: Albert Mayo
>
> 1. I created an order with GZ-1000 and GZ-1004.
> 2. I canceled the GZ-1004 item.
> 3. I added GZ-1001 to the order.
> Instead of putting GZ-1001 as a new line item, it looks like GZ-1001 replaces the GZ-1004 line item.
> I say it is a possible bug because I do not know if this is the functional intent.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12783303#action_12783303 ]

Jacques Le Roux commented on OFBIZ-3253:
----------------------------------------

Hi Albert,

I have tested in trunk no problem so far. But please could you explain more in detail how to reproduce the problem (like an use case). For instance, are you deleting the item when adding to cart or after when the order has been already created ?

Thanks

> possible bug with adding an item to an order that has a canceled item
> ---------------------------------------------------------------------
>
>                 Key: OFBIZ-3253
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3253
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: Release Branch 4.0, Release Branch 9.04
>            Reporter: Albert Mayo
>
> 1. I created an order with GZ-1000 and GZ-1004.
> 2. I canceled the GZ-1004 item.
> 3. I added GZ-1001 to the order.
> Instead of putting GZ-1001 as a new line item, it looks like GZ-1001 replaces the GZ-1004 line item.
> I say it is a possible bug because I do not know if this is the functional intent.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12783668#action_12783668 ]

Albert Mayo commented on OFBIZ-3253:
------------------------------------

At step 1 in the issue description you have already created the order.  So add the 2 items from step 1 to a cart.  Be sure to add GZ-1004 as the 2nd item in the card.  Create the order. Cancel the last item in the order which should be GZ-1004.  Add GZ-1001 to the order.

> possible bug with adding an item to an order that has a canceled item
> ---------------------------------------------------------------------
>
>                 Key: OFBIZ-3253
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3253
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: Release Branch 4.0, Release Branch 9.04
>            Reporter: Albert Mayo
>
> 1. I created an order with GZ-1000 and GZ-1004.
> 2. I canceled the GZ-1004 item.
> 3. I added GZ-1001 to the order.
> Instead of putting GZ-1001 as a new line item, it looks like GZ-1001 replaces the GZ-1004 line item.
> I say it is a possible bug because I do not know if this is the functional intent.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.