[jira] Created: (OFBIZ-3205) We should not allow users to enter thruDate older than related fromDate

[Nicolas Malin (Jira)]

We should not allow users to enter thruDate older than related fromDate
-----------------------------------------------------------------------

                 Key: OFBIZ-3205
                 URL: https://issues.apache.org/jira/browse/OFBIZ-3205
             Project: OFBiz
          Issue Type: Improvement
          Components: ALL APPLICATIONS
    Affects Versions: SVN trunk
            Reporter: Jacques Le Roux
            Priority: Minor
             Fix For: SVN trunk


I can't see any reason why we authorize users to enter a thru date previous to its related from date.
Should we not prevent it in any cases ?


--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12778109#action_12778109 ]

Jacques Le Roux commented on OFBIZ-3205:
----------------------------------------

At large I think we should (begin?) to filter as most as possible errors the user can make. This is the kind of stuff that should not be to hard to do on the UI level (or maybe using some ECA ?) and could save a lot of time to users when such errors are not discovered before a real tragedy occurs.

> We should not allow users to enter thruDate older than related fromDate
> -----------------------------------------------------------------------
>
>                 Key: OFBIZ-3205
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3205
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL APPLICATIONS
>    Affects Versions: SVN trunk
>            Reporter: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>
> I can't see any reason why we authorize users to enter a thru date previous to its related from date.
> Should we not prevent it in any cases ?

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12792464#action_12792464 ]

Bilgin Ibryam commented on OFBIZ-3205:
--------------------------------------

Hi,

I also needed to validate fromDate/thruDate in few places and for that purpose I created a service and used ECAs. It works fine but the error messages generated from ecas are not very user friendly.

I can commit that to the project, but I'd like to hear also other opinions, there might be better solutions than invoking a service with ECA to validate 2 fields.

Any ideas?

Bilgin

> We should not allow users to enter thruDate older than related fromDate
> -----------------------------------------------------------------------
>
>                 Key: OFBIZ-3205
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3205
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL APPLICATIONS
>    Affects Versions: SVN trunk
>            Reporter: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>
> I can't see any reason why we authorize users to enter a thru date previous to its related from date.
> Should we not prevent it in any cases ?

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12792571#action_12792571 ]

Jacques Le Roux commented on OFBIZ-3205:
----------------------------------------

Hi Bilgin,

Apart a generic javascript function to put in each screen, I can't see any other means. More work but more efficient because the problem is taken at the root.
For the moment I can't see any problem to use an ECA though, it's an error and other errors are roll up like this.

> We should not allow users to enter thruDate older than related fromDate
> -----------------------------------------------------------------------
>
>                 Key: OFBIZ-3205
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3205
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL APPLICATIONS
>    Affects Versions: SVN trunk
>            Reporter: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>
> I can't see any reason why we authorize users to enter a thru date previous to its related from date.
> Should we not prevent it in any cases ?

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.