[jira] Created: (OFBIZ-3044) Adding a class style to the Screen Title
Locked
12
12
[jira] Created: (OFBIZ-3044) Adding a class style to the Screen Title
 
|
Adding a class style to the Screen Title
---------------------------------------- Key: OFBIZ-3044 URL: https://issues.apache.org/jira/browse/OFBIZ-3044 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: SVN trunk Reporter: Bruno Busco Attachments: screenTitle.patch, screenTitle1.JPG In the attached patch I added a new class "screen-title" to the screen title rendered by the FindScreenDecorator. This will let the themes to attach a theme defined style different from H1. In the Bluelight theme this is used to completely hide the title because it is already shown in the blue/white bar (you can see how a find screen appears before and after the patch). I left the H1 style also so that the other themes still work the same but it could be removed adding the proper style in all the themes. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-3044) Adding a class style to the Screen Title
|
|
[ https://issues.apache.org/jira/browse/OFBIZ-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Busco updated OFBIZ-3044: ------------------------------- Attachment: screenTitle.patch > Adding a class style to the Screen Title > ---------------------------------------- > > Key: OFBIZ-3044 > URL: https://issues.apache.org/jira/browse/OFBIZ-3044 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Bruno Busco > Attachments: screenTitle.patch, screenTitle1.JPG > > > In the attached patch I added a new class "screen-title" to the screen title rendered by the FindScreenDecorator. > This will let the themes to attach a theme defined style different from H1. > In the Bluelight theme this is used to completely hide the title because it is already shown in the blue/white bar (you can see how a find screen appears before and after the patch). > I left the H1 style also so that the other themes still work the same but it could be removed adding the proper style in all the themes. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-3044) Adding a class style to the Screen Title
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Busco updated OFBIZ-3044: ------------------------------- Attachment: screenTitle1.JPG Find Screen before the patch > Adding a class style to the Screen Title > ---------------------------------------- > > Key: OFBIZ-3044 > URL: https://issues.apache.org/jira/browse/OFBIZ-3044 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Bruno Busco > Attachments: screenTitle.patch, screenTitle1.JPG > > > In the attached patch I added a new class "screen-title" to the screen title rendered by the FindScreenDecorator. > This will let the themes to attach a theme defined style different from H1. > In the Bluelight theme this is used to completely hide the title because it is already shown in the blue/white bar (you can see how a find screen appears before and after the patch). > I left the H1 style also so that the other themes still work the same but it could be removed adding the proper style in all the themes. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-3044) Adding a class style to the Screen Title
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Busco updated OFBIZ-3044: ------------------------------- Attachment: screenTitle2.JPG Find Screen after the patch > Adding a class style to the Screen Title > ---------------------------------------- > > Key: OFBIZ-3044 > URL: https://issues.apache.org/jira/browse/OFBIZ-3044 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Bruno Busco > Attachments: screenTitle.patch, screenTitle1.JPG, screenTitle2.JPG > > > In the attached patch I added a new class "screen-title" to the screen title rendered by the FindScreenDecorator. > This will let the themes to attach a theme defined style different from H1. > In the Bluelight theme this is used to completely hide the title because it is already shown in the blue/white bar (you can see how a find screen appears before and after the patch). > I left the H1 style also so that the other themes still work the same but it could be removed adding the proper style in all the themes. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-3044) Adding a class style to the Screen Title
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Busco updated OFBIZ-3044: ------------------------------- Attachment: (was: screenTitle2.JPG) > Adding a class style to the Screen Title > ---------------------------------------- > > Key: OFBIZ-3044 > URL: https://issues.apache.org/jira/browse/OFBIZ-3044 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Bruno Busco > Attachments: screenTitle.patch, screenTitle1.JPG, screenTitle2.JPG > > > In the attached patch I added a new class "screen-title" to the screen title rendered by the FindScreenDecorator. > This will let the themes to attach a theme defined style different from H1. > In the Bluelight theme this is used to completely hide the title because it is already shown in the blue/white bar (you can see how a find screen appears before and after the patch). > I left the H1 style also so that the other themes still work the same but it could be removed adding the proper style in all the themes. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-3044) Adding a class style to the Screen Title
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Busco updated OFBIZ-3044: ------------------------------- Attachment: screenTitle2.JPG Find screen after the patch > Adding a class style to the Screen Title > ---------------------------------------- > > Key: OFBIZ-3044 > URL: https://issues.apache.org/jira/browse/OFBIZ-3044 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Bruno Busco > Attachments: screenTitle.patch, screenTitle1.JPG, screenTitle2.JPG > > > In the attached patch I added a new class "screen-title" to the screen title rendered by the FindScreenDecorator. > This will let the themes to attach a theme defined style different from H1. > In the Bluelight theme this is used to completely hide the title because it is already shown in the blue/white bar (you can see how a find screen appears before and after the patch). > I left the H1 style also so that the other themes still work the same but it could be removed adding the proper style in all the themes. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-3044) Adding a class style to the Screen Title
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12766120#action_12766120 ] Adrian Crum commented on OFBIZ-3044: ------------------------------------ Why not use a descendant selector instead of a new style? #content-main-section h1 { display: none; } > Adding a class style to the Screen Title > ---------------------------------------- > > Key: OFBIZ-3044 > URL: https://issues.apache.org/jira/browse/OFBIZ-3044 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Bruno Busco > Attachments: screenTitle.patch, screenTitle1.JPG, screenTitle2.JPG > > > In the attached patch I added a new class "screen-title" to the screen title rendered by the FindScreenDecorator. > This will let the themes to attach a theme defined style different from H1. > In the Bluelight theme this is used to completely hide the title because it is already shown in the blue/white bar (you can see how a find screen appears before and after the patch). > I left the H1 style also so that the other themes still work the same but it could be removed adding the proper style in all the themes. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-3044) Adding a class style to the Screen Title
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12766187#action_12766187 ] Bruno Busco commented on OFBIZ-3044: ------------------------------------ Yes we could do this but wouldn't this affect any other "h1" in the content-main-section ? > Adding a class style to the Screen Title > ---------------------------------------- > > Key: OFBIZ-3044 > URL: https://issues.apache.org/jira/browse/OFBIZ-3044 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Bruno Busco > Attachments: screenTitle.patch, screenTitle1.JPG, screenTitle2.JPG > > > In the attached patch I added a new class "screen-title" to the screen title rendered by the FindScreenDecorator. > This will let the themes to attach a theme defined style different from H1. > In the Bluelight theme this is used to completely hide the title because it is already shown in the blue/white bar (you can see how a find screen appears before and after the patch). > I left the H1 style also so that the other themes still work the same but it could be removed adding the proper style in all the themes. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-3044) Adding a class style to the Screen Title
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12766199#action_12766199 ] Adrian Crum commented on OFBIZ-3044: ------------------------------------ There shouldn't be any other h1 elements. > Adding a class style to the Screen Title > ---------------------------------------- > > Key: OFBIZ-3044 > URL: https://issues.apache.org/jira/browse/OFBIZ-3044 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Bruno Busco > Attachments: screenTitle.patch, screenTitle1.JPG, screenTitle2.JPG > > > In the attached patch I added a new class "screen-title" to the screen title rendered by the FindScreenDecorator. > This will let the themes to attach a theme defined style different from H1. > In the Bluelight theme this is used to completely hide the title because it is already shown in the blue/white bar (you can see how a find screen appears before and after the patch). > I left the H1 style also so that the other themes still work the same but it could be removed adding the proper style in all the themes. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Assigned: (OFBIZ-3044) Adding a class style to the Screen Title
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Busco reassigned OFBIZ-3044: ---------------------------------- Assignee: Bruno Busco > Adding a class style to the Screen Title > ---------------------------------------- > > Key: OFBIZ-3044 > URL: https://issues.apache.org/jira/browse/OFBIZ-3044 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Bruno Busco > Assignee: Bruno Busco > Attachments: screenTitle.patch, screenTitle1.JPG, screenTitle2.JPG > > > In the attached patch I added a new class "screen-title" to the screen title rendered by the FindScreenDecorator. > This will let the themes to attach a theme defined style different from H1. > In the Bluelight theme this is used to completely hide the title because it is already shown in the blue/white bar (you can see how a find screen appears before and after the patch). > I left the H1 style also so that the other themes still work the same but it could be removed adding the proper style in all the themes. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Resolved: (OFBIZ-3044) Adding a class style to the Screen Title
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Busco resolved OFBIZ-3044. -------------------------------- Resolution: Fixed Thank you Adrian, I followed your suggestion in Revision: 825634 > Adding a class style to the Screen Title > ---------------------------------------- > > Key: OFBIZ-3044 > URL: https://issues.apache.org/jira/browse/OFBIZ-3044 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Bruno Busco > Assignee: Bruno Busco > Attachments: screenTitle.patch, screenTitle1.JPG, screenTitle2.JPG > > > In the attached patch I added a new class "screen-title" to the screen title rendered by the FindScreenDecorator. > This will let the themes to attach a theme defined style different from H1. > In the Bluelight theme this is used to completely hide the title because it is already shown in the blue/white bar (you can see how a find screen appears before and after the patch). > I left the H1 style also so that the other themes still work the same but it could be removed adding the proper style in all the themes. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-3044) Adding a class style to the Screen Title
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12766248#action_12766248 ] Adrian Crum commented on OFBIZ-3044: ------------------------------------ By the way, please don't get discouraged when I push against new CSS classes. Some time ago, there was very little effort put into reusing existing CSS classes or styling HTML compounds and the end result was we had a HUGE main style sheet. Several years ago we went through the main style sheet and eliminated many redundant and unused classes. So, now I make an effort to prevent the main style sheet from growing again. If a new CSS class is really needed, then that's fine. But let's try to make sure it is really needed. > Adding a class style to the Screen Title > ---------------------------------------- > > Key: OFBIZ-3044 > URL: https://issues.apache.org/jira/browse/OFBIZ-3044 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Bruno Busco > Assignee: Bruno Busco > Attachments: screenTitle.patch, screenTitle1.JPG, screenTitle2.JPG > > > In the attached patch I added a new class "screen-title" to the screen title rendered by the FindScreenDecorator. > This will let the themes to attach a theme defined style different from H1. > In the Bluelight theme this is used to completely hide the title because it is already shown in the blue/white bar (you can see how a find screen appears before and after the patch). > I left the H1 style also so that the other themes still work the same but it could be removed adding the proper style in all the themes. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Closed: (OFBIZ-3044) Adding a class style to the Screen Title
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Busco closed OFBIZ-3044. ------------------------------ > Adding a class style to the Screen Title > ---------------------------------------- > > Key: OFBIZ-3044 > URL: https://issues.apache.org/jira/browse/OFBIZ-3044 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Bruno Busco > Assignee: Bruno Busco > Attachments: screenTitle.patch, screenTitle1.JPG, screenTitle2.JPG > > > In the attached patch I added a new class "screen-title" to the screen title rendered by the FindScreenDecorator. > This will let the themes to attach a theme defined style different from H1. > In the Bluelight theme this is used to completely hide the title because it is already shown in the blue/white bar (you can see how a find screen appears before and after the patch). > I left the H1 style also so that the other themes still work the same but it could be removed adding the proper style in all the themes. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Reopened: (OFBIZ-3044) Adding a class style to the Screen Title
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Busco reopened OFBIZ-3044: -------------------------------- Unfortunately, ss reported by Jacques in the dev ML, simply hiding the #content-main-section h1 is not a good solution because actually there are other H1 elements in the content-main-section. I will write a patch soon and attach to this jira. > Adding a class style to the Screen Title > ---------------------------------------- > > Key: OFBIZ-3044 > URL: https://issues.apache.org/jira/browse/OFBIZ-3044 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Bruno Busco > Assignee: Bruno Busco > Attachments: screenTitle.patch, screenTitle1.JPG, screenTitle2.JPG > > > In the attached patch I added a new class "screen-title" to the screen title rendered by the FindScreenDecorator. > This will let the themes to attach a theme defined style different from H1. > In the Bluelight theme this is used to completely hide the title because it is already shown in the blue/white bar (you can see how a find screen appears before and after the patch). > I left the H1 style also so that the other themes still work the same but it could be removed adding the proper style in all the themes. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-3044) Adding a class style to the Screen Title
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Busco updated OFBIZ-3044: ------------------------------- Attachment: screenTitle.patch It seems that the new "screen-title" style is really needed. Please find attached a new patch. > Adding a class style to the Screen Title > ---------------------------------------- > > Key: OFBIZ-3044 > URL: https://issues.apache.org/jira/browse/OFBIZ-3044 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Bruno Busco > Assignee: Bruno Busco > Attachments: screenTitle.patch, screenTitle.patch, screenTitle1.JPG, screenTitle2.JPG > > > In the attached patch I added a new class "screen-title" to the screen title rendered by the FindScreenDecorator. > This will let the themes to attach a theme defined style different from H1. > In the Bluelight theme this is used to completely hide the title because it is already shown in the blue/white bar (you can see how a find screen appears before and after the patch). > I left the H1 style also so that the other themes still work the same but it could be removed adding the proper style in all the themes. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-3044) Adding a class style to the Screen Title
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12768852#action_12768852 ] Adrian Crum commented on OFBIZ-3044: ------------------------------------ Bruno, Could we change the CSS class name to page-title, and then use that class instead of H1, not in addition to H1? Just make the page-title class a duplicate of H1 in the other themes. > Adding a class style to the Screen Title > ---------------------------------------- > > Key: OFBIZ-3044 > URL: https://issues.apache.org/jira/browse/OFBIZ-3044 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Bruno Busco > Assignee: Bruno Busco > Attachments: screenTitle.patch, screenTitle.patch, screenTitle1.JPG, screenTitle2.JPG > > > In the attached patch I added a new class "screen-title" to the screen title rendered by the FindScreenDecorator. > This will let the themes to attach a theme defined style different from H1. > In the Bluelight theme this is used to completely hide the title because it is already shown in the blue/white bar (you can see how a find screen appears before and after the patch). > I left the H1 style also so that the other themes still work the same but it could be removed adding the proper style in all the themes. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
Re: [jira] Commented: (OFBIZ-3044) Adding a class style to the Screen Title
|
|
OK, agree.
I will do that. -Bruno 2009/10/22 Adrian Crum (JIRA) <[hidden email]>: > > [ https://issues.apache.org/jira/browse/OFBIZ-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12768852#action_12768852 ] > > Adrian Crum commented on OFBIZ-3044: > ------------------------------------ > > Bruno, > > Could we change the CSS class name to page-title, and then use that class instead of H1, not in addition to H1? Just make the page-title class a duplicate of H1 in the other themes. > > > > >> Adding a class style to the Screen Title >> ---------------------------------------- >> >> Key: OFBIZ-3044 >> URL: https://issues.apache.org/jira/browse/OFBIZ-3044 >> Project: OFBiz >> Issue Type: Improvement >> Components: framework >> Affects Versions: SVN trunk >> Reporter: Bruno Busco >> Assignee: Bruno Busco >> Attachments: screenTitle.patch, screenTitle.patch, screenTitle1.JPG, screenTitle2.JPG >> >> >> In the attached patch I added a new class "screen-title" to the screen title rendered by the FindScreenDecorator. >> This will let the themes to attach a theme defined style different from H1. >> In the Bluelight theme this is used to completely hide the title because it is already shown in the blue/white bar (you can see how a find screen appears before and after the patch). >> I left the H1 style also so that the other themes still work the same but it could be removed adding the proper style in all the themes. > > -- > This message is automatically generated by JIRA. > - > You can reply to this email to add a comment to the issue online. > > |
[jira] Updated: (OFBIZ-3044) Adding a class style to the Screen Title
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Busco updated OFBIZ-3044: ------------------------------- Attachment: screenTitle.patch Adrian, please find attached a new patch where I follow your indications. -Bruno > Adding a class style to the Screen Title > ---------------------------------------- > > Key: OFBIZ-3044 > URL: https://issues.apache.org/jira/browse/OFBIZ-3044 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Bruno Busco > Assignee: Bruno Busco > Attachments: screenTitle.patch, screenTitle.patch, screenTitle.patch, screenTitle1.JPG, screenTitle2.JPG > > > In the attached patch I added a new class "screen-title" to the screen title rendered by the FindScreenDecorator. > This will let the themes to attach a theme defined style different from H1. > In the Bluelight theme this is used to completely hide the title because it is already shown in the blue/white bar (you can see how a find screen appears before and after the patch). > I left the H1 style also so that the other themes still work the same but it could be removed adding the proper style in all the themes. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Closed: (OFBIZ-3044) Adding a class style to the Screen Title
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum closed OFBIZ-3044. ------------------------------ Resolution: Fixed Bruno, Your patch has been committed, rev 828882. > Adding a class style to the Screen Title > ---------------------------------------- > > Key: OFBIZ-3044 > URL: https://issues.apache.org/jira/browse/OFBIZ-3044 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Bruno Busco > Assignee: Bruno Busco > Attachments: screenTitle.patch, screenTitle.patch, screenTitle.patch, screenTitle1.JPG, screenTitle2.JPG > > > In the attached patch I added a new class "screen-title" to the screen title rendered by the FindScreenDecorator. > This will let the themes to attach a theme defined style different from H1. > In the Bluelight theme this is used to completely hide the title because it is already shown in the blue/white bar (you can see how a find screen appears before and after the patch). > I left the H1 style also so that the other themes still work the same but it could be removed adding the proper style in all the themes. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-3044) Adding a class style to the Screen Title
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12791304#action_12791304 ] Jens Falsmar Oechsler commented on OFBIZ-3044: ---------------------------------------------- Was this reverted on purpose? In rev 834376 it says "Removed extra container around labels. Apply h1 (or h2, h3) style to label instead. ". If not on purpose, could the page-title class be applied to the label instead of a container? > Adding a class style to the Screen Title > ---------------------------------------- > > Key: OFBIZ-3044 > URL: https://issues.apache.org/jira/browse/OFBIZ-3044 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Bruno Busco > Assignee: Bruno Busco > Attachments: screenTitle.patch, screenTitle.patch, screenTitle.patch, screenTitle1.JPG, screenTitle2.JPG > > > In the attached patch I added a new class "screen-title" to the screen title rendered by the FindScreenDecorator. > This will let the themes to attach a theme defined style different from H1. > In the Bluelight theme this is used to completely hide the title because it is already shown in the blue/white bar (you can see how a find screen appears before and after the patch). > I left the H1 style also so that the other themes still work the same but it could be removed adding the proper style in all the themes. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
«
Return to OFBiz - Dev
|
1 view|%1 views
| Free forum by Nabble | Edit this page |