[jira] Created: (OFBIZ-1935) Allow multi-pagination in a page

[Nicolas Malin (Jira)]

Allow multi-pagination in a page  
-----------------------------------

                 Key: OFBIZ-1935
                 URL: https://issues.apache.org/jira/browse/OFBIZ-1935
             Project: OFBiz
          Issue Type: Bug
          Components: ALL COMPONENTS
    Affects Versions: SVN trunk
            Reporter: Jacques Le Roux


If a page has more than one paginations (fe : view profile has one in "Financial Account Summary " and one in "Shipper Account" ) the pagination numbers become wrong, as both paginations use VIEW_SIZE and VIEW_INDEX parameters from the request.



--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bilgin Ibryam reassigned OFBIZ-1935:
------------------------------------

    Assignee: Bilgin Ibryam

> Allow multi-pagination in a page  
> -----------------------------------
>
>                 Key: OFBIZ-1935
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1935
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Jacques Le Roux
>            Assignee: Bilgin Ibryam
>
> If a page has more than one paginations (fe : view profile has one in "Financial Account Summary " and one in "Shipper Account" ) the pagination numbers become wrong, as both paginations use VIEW_SIZE and VIEW_INDEX parameters from the request.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bilgin Ibryam updated OFBIZ-1935:
---------------------------------

    Attachment: 1935.diff

The attached patch will add paginator numbers  to VIEW_SIZE  and VIEW_INDEX parameters, so every form has different parameters for pagination (form one will use VIEW_SIZE_1,   VIEW_INDEX_1, second form on the same page will use VIEW_SIZE_2,   VIEW_INDEX_2 params....).
The last  paginator number used on a page is stored in globalContext, so every rendered pagination can get next number to use for the parameters.

Also fixed a bug, where iterator-section was not adding existing request parameters to the paginator links.

Any tests and reviews would be appreciated.
Bilgin

> Allow multi-pagination in a page  
> -----------------------------------
>
>                 Key: OFBIZ-1935
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1935
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Jacques Le Roux
>            Assignee: Bilgin Ibryam
>         Attachments: 1935.diff
>
>
> If a page has more than one paginations (fe : view profile has one in "Financial Account Summary " and one in "Shipper Account" ) the pagination numbers become wrong, as both paginations use VIEW_SIZE and VIEW_INDEX parameters from the request.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux updated OFBIZ-1935:
-----------------------------------

    Attachment: 1935.diff

Hi BIlgin,

I reviewed and tested your patch, for me all is ok. I just added a pagination to ListCarrierAccounts and made it comes back to viewprofile. Doing so I tried to use the paginate-target-anchor tag to come back to the right position in the page. But I did not find how to use it. I guess it's not implemented for now. I will have a look later and will open a new issue if needed.

Patch attached

> Allow multi-pagination in a page  
> -----------------------------------
>
>                 Key: OFBIZ-1935
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1935
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Jacques Le Roux
>            Assignee: Bilgin Ibryam
>         Attachments: 1935.diff, 1935.diff
>
>
> If a page has more than one paginations (fe : view profile has one in "Financial Account Summary " and one in "Shipper Account" ) the pagination numbers become wrong, as both paginations use VIEW_SIZE and VIEW_INDEX parameters from the request.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12654761#action_12654761 ]

Bilgin Ibryam commented on OFBIZ-1935:
--------------------------------------

Jacques,

thanks for testing the patch.
In paginate-target-anchor you have to specify a link name, but pagination links don't have names.
You can use also formId, like this:  paginate-target-anchor="ListCarrierAccounts" and the page will be scrolled.

> Allow multi-pagination in a page  
> -----------------------------------
>
>                 Key: OFBIZ-1935
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1935
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Jacques Le Roux
>            Assignee: Bilgin Ibryam
>         Attachments: 1935.diff, 1935.diff
>
>
> If a page has more than one paginations (fe : view profile has one in "Financial Account Summary " and one in "Shipper Account" ) the pagination numbers become wrong, as both paginations use VIEW_SIZE and VIEW_INDEX parameters from the request.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12655167#action_12655167 ]

Jacques Le Roux commented on OFBIZ-1935:
----------------------------------------

Thanks for the tip Bilgin

> Allow multi-pagination in a page  
> -----------------------------------
>
>                 Key: OFBIZ-1935
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1935
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Jacques Le Roux
>            Assignee: Bilgin Ibryam
>         Attachments: 1935.diff, 1935.diff
>
>
> If a page has more than one paginations (fe : view profile has one in "Financial Account Summary " and one in "Shipper Account" ) the pagination numbers become wrong, as both paginations use VIEW_SIZE and VIEW_INDEX parameters from the request.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-1935.
----------------------------------

       Resolution: Fixed
    Fix Version/s: SVN trunk

Thanks Bilgin,

Your (slightly modifiedf) patch is in trunk revision: 725053 .

It's cool to be able to get back to page position using paginate-target-anchor and corresponding form name. I quickly look to see if something like that also exists for forms like EditCarrierAccount (with no pagination) but did not find anything. It would be cool to come back to the place where you made a change instead of top of page. So we might consider introduce an anchor attribute except it already exists and I missed it.

> Allow multi-pagination in a page  
> -----------------------------------
>
>                 Key: OFBIZ-1935
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1935
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Jacques Le Roux
>            Assignee: Bilgin Ibryam
>             Fix For: SVN trunk
>
>         Attachments: 1935.diff, 1935.diff
>
>
> If a page has more than one paginations (fe : view profile has one in "Financial Account Summary " and one in "Shipper Account" ) the pagination numbers become wrong, as both paginations use VIEW_SIZE and VIEW_INDEX parameters from the request.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bruno Busco reopened OFBIZ-1935:
--------------------------------


There is still a wrong behaviour of the pagination when used in Ajax forms.
Please see https://issues.apache.org/jira/browse/OFBIZ-3083 for further details.

> Allow multi-pagination in a page  
> -----------------------------------
>
>                 Key: OFBIZ-1935
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1935
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Jacques Le Roux
>            Assignee: Bilgin Ibryam
>             Fix For: SVN trunk
>
>         Attachments: 1935.diff, 1935.diff
>
>
> If a page has more than one paginations (fe : view profile has one in "Financial Account Summary " and one in "Shipper Account" ) the pagination numbers become wrong, as both paginations use VIEW_SIZE and VIEW_INDEX parameters from the request.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784155#action_12784155 ]

Bilgin Ibryam commented on OFBIZ-1935:
--------------------------------------

In r885709 I did a fix, which should cover most of the ajax forms in the project.

The bug will continues to appear, when there are more than one list or multi forms in a page using ajax pagination. This happens because for the ajax response, the form is rendered alone, in a separate screen where it always gets index 1.

> Allow multi-pagination in a page  
> -----------------------------------
>
>                 Key: OFBIZ-1935
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1935
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Jacques Le Roux
>            Assignee: Bilgin Ibryam
>             Fix For: SVN trunk
>
>         Attachments: 1935.diff, 1935.diff
>
>
> If a page has more than one paginations (fe : view profile has one in "Financial Account Summary " and one in "Shipper Account" ) the pagination numbers become wrong, as both paginations use VIEW_SIZE and VIEW_INDEX parameters from the request.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.