[jira] [Commented] (OFBIZ-9409) Add numeric code for Currency UOM

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-9409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16050996#comment-16050996 ]

Pierre Smits commented on OFBIZ-9409:
-------------------------------------

Hi [~deepak.dixit],

I reviewed your patch file.

Maybe you should consider changing the field type for the numericCode field. The 'short-varchar' field type also allows alpha numeric entries (and in the case of PostgreSQL up to 60 characters). I suspect that also applies for other RDBMSes.

Best regards,

Pierre

> Add numeric code for Currency UOM
> ---------------------------------
>
>                 Key: OFBIZ-9409
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-9409
>             Project: OFBiz
>          Issue Type: Improvement
>    Affects Versions: Trunk
>            Reporter: Deepak Dixit
>            Assignee: Deepak Dixit
>         Attachments: OFBIZ-9409.patch
>
>
> The three-digit numeric code is useful when currency codes need to be understood in countries that do not use Latin scripts and for computerised systems. Where possible the 3 digit numeric code is the same as the numeric country code.
> https://www.iso.org/iso-4217-currency-codes.html
> https://www.currency-iso.org/en/home/tables/table-a1.html

--
This message was sent by Atlassian JIRA
(v6.4.14#64029)