[jira] [Commented] (OFBIZ-9352) Remove unused labels from AccountingUiLabels.xml

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (OFBIZ-9352) Remove unused labels from AccountingUiLabels.xml

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-9352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16006081#comment-16006081 ]

Michael Brohl commented on OFBIZ-9352:
--------------------------------------

I agree with Scott that we should check why labels are obsolete. If we find that they are unused for good reasons, e.g. the were not removed when the corresponding code was removed or they were introduced but never used, they should be deleted.

It's like unused code to stay commented in the code base because one might find it useful some day. It clutters the codebase. If we want to resurrect them, we have the version control for it.

Another way would be to put them in another place outside of the project but I'm not sure if it is worth the effort.

> Remove unused labels from AccountingUiLabels.xml
> ------------------------------------------------
>
>                 Key: OFBIZ-9352
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-9352
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Pierre Smits
>            Assignee: Pierre Smits
>            Priority: Minor
>         Attachments: OFBIZ-9352-AccountingUiLabels.xml.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)