[jira] [Commented] (OFBIZ-9346) Maximise utilisation of common labels in AccountingMenus.xml

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-9346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15999874#comment-15999874 ]

Jacques Le Roux commented on OFBIZ-9346:
----------------------------------------

Pierre,

You are a long time contributor but it seems you still not understand why I asked you so, let me try to explain.

The change I asked you for initially
bq. Your patch is not enough. CommonTerms does not contain as much translations as AccountingAgreementTerms.
was because else we would "loose" information (translations into AccountingAgreementTerms would have no longer been used). Those translations, done by other contributors, are precious because we can't do them ourselves, right?

So I asked you to
bq. check/do the same for AccountingAgreementItems, AccountingAgreementRoles and AccountingAgreementContents
I guess you see why now (did you really miss it?).

Now I have several choices:
# commit your patch as is with OFBIZ-9348 and OFBIZ-9349. This would be wrong w/o checking as explained above in this comment. I'll not do that.
# Do the checking work for you as I did for CommonTerms and AccountingAgreementTerms. And then I could either ask you to fix it if necessary. Or do it by myself as I did for hundreds (yes hundreds, if not thousands) of other issues before. But you know what? I'm weary of that...
# Commit , with OFBIZ-9348 and OFBIZ-9349, only the relevant part of your patch here, ie remove changes for  AccountingAgreementItems, AccountingAgreementRoles and AccountingAgreementContents.

So what do you prefer, 2 or 3?

> Maximise utilisation of common labels in AccountingMenus.xml
> ------------------------------------------------------------
>
>                 Key: OFBIZ-9346
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-9346
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>    Affects Versions: Trunk
>            Reporter: Pierre Smits
>            Assignee: Pierre Smits
>            Priority: Minor
>         Attachments: OFBIZ-9346-AccountingMenus.xml.patch
>
>

--
This message was sent by Atlassian JIRA
(v6.3.15#6346)