[jira] [Commented] (OFBIZ-9346) Maximise utilisation of common labels in AccountingMenus.xml

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-9346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15999755#comment-15999755 ]

Jacques Le Roux commented on OFBIZ-9346:
----------------------------------------

Pierre,

Your patch is not enough. CommonTerms does not contain as much translations as AccountingAgreementTerms. To be really interesting you need to also replace CommonTerms content by AccountingAgreementTerms content. I understand and share your concern about moving as much as possible translation in Common. This is a good thing but depends on cases. Here it's OK if we move the translation in Common. But I remember issues we had with sub tasks of OFBIZ-8110, eg http://svn.apache.org/viewvc?view=revision&revision=1761923

> Maximise utilisation of common labels in AccountingMenus.xml
> ------------------------------------------------------------
>
>                 Key: OFBIZ-9346
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-9346
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>    Affects Versions: Trunk
>            Reporter: Pierre Smits
>            Assignee: Pierre Smits
>            Priority: Minor
>         Attachments: OFBIZ-9346-AccountingMenus.xml.patch
>
>

--
This message was sent by Atlassian JIRA
(v6.3.15#6346)