[jira] [Commented] (OFBIZ-9261) Handle only labels with the "_" separator between languages and countries

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (OFBIZ-9261) Handle only labels with the "_" separator between languages and countries

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-9261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15926220#comment-15926220 ]

Jacques Le Roux commented on OFBIZ-9261:
----------------------------------------

Fixed in
trunk r1787047
R16.11 r1787048
I did not backport in older branches, conflicts and not really needed.

Moreover I notices that there are no longer reasons to bypass the ExampleEntityLabels and ProductPromoUiLabels files. This is a bug and I removed it.

> Handle only labels with the "_" separator between languages and countries
> -------------------------------------------------------------------------
>
>                 Key: OFBIZ-9261
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-9261
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: Trunk
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: Upcoming Release, 16.11.02
>
>
> I explained that in the second message in this dev ML thread https://s.apache.org/S3Ao
> This is handled in LabelManagerFactory.java
> {code}
>                             Element valueElem = (Element) valueNode;
>                             // Support old way of specifying xml:lang value.
>                             // Old way: en_AU, new way: en-AU
>                             String localeName = valueElem.getAttribute("xml:lang");
>                             if( localeName.contains("_")) {
>                                 localeName = localeName.replace('_', '-');
>                             }
> {code}
> I'll replace this snippet by throwing an exception in order to now to automatically detect issues



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)