[
https://issues.apache.org/jira/browse/OFBIZ-8179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15480761#comment-15480761 ]
Scott Gray commented on OFBIZ-8179:
-----------------------------------
Hi Jacopo,
Doesn't this change force users to use geronimo as their transaction manager when using dbcp2? Alternatively, if I want to use a different connection pooling implementation, I would now need to reimplement the TransactionFactory as well?
Could we not just move GeronimoTransactionFactory.java into the entity component and achieve roughly the same result while still maintaining separation between transactions and connections?
> Enhance DBCPConnectionFactory to implement a TransactionFactory and remove the geronimo component
> -------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-8179
> URL:
https://issues.apache.org/jira/browse/OFBIZ-8179> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Affects Versions: Trunk
> Reporter: Jacopo Cappellato
> Assignee: Jacopo Cappellato
> Priority: Minor
> Attachments: OFBIZ-8179.patch, TransactionConnectionFactory-before-after.png
>
>
> Made the DBCPConnectionFactory an implementation of TransactionFactory by moving the code from the GeronimoTransactionFactory.
> With this change the geronimo component is no more required.
> Without any functional change, this design simplifies greatly the calls and component dependencies because it removes a cyclic dependency between entity and geronimo components (see diagram attached that explain the architecture before and after this change).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)