[
https://issues.apache.org/jira/browse/OFBIZ-6291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14508686#comment-14508686 ]
Gareth Carter commented on OFBIZ-6291:
--------------------------------------
Just realised minilang_compare.patch does not apply against latest trunk. Will provide another patch. The patch will apply against 1663617. The patch could ignore compareBigDecimals, though I still think it's irrelevant 2.0 = 2.00 = 2.000 = 2.0000 with compareTo. You will get the same result, all you've done is create a few more lines of code
> Update code to check for types rather than throw ClassCastException
> -------------------------------------------------------------------
>
> Key: OFBIZ-6291
> URL:
https://issues.apache.org/jira/browse/OFBIZ-6291> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Affects Versions: Trunk
> Reporter: Gareth Carter
> Priority: Trivial
> Attachments: LocalizedConverters.patch, minilang_compare.patch
>
>
> framework/minilang/src/org/ofbiz/minilang/method/conditional/Compare.java
> framework/base/src/org/ofbiz/base/util/ObjectType.java
> framework/minilang/src/org/ofbiz/minilang/MiniLangUtil.java
> all throw ClassCastExceptions and are ignored instead of checking types
> This caused issues in debugging when adding a ClassCastException breakpoint
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Locked
