[
https://issues.apache.org/jira/browse/OFBIZ-5241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13787793#comment-13787793 ]
Jacques Le Roux commented on OFBIZ-5241:
----------------------------------------
Pierre,
I have applied all your patches locally. I commited "OFBIZ-5241-ACCTG-Labels.patch" at r1529693 in trunk.
Some points to note (again...)
# Please follow the procedure to create patches from Eclipse in order to remove the 2 1st lines like
{code}
### Eclipse Workspace Patch 1.0
#P ofbiz-trunk
{code}
They are not only useless but can be really annoying in some cases. For instance here you had chinese characters in your patch. If I copy from the browser, where your patches were opened by default in my config, then I have to copy in a text editor and to change the BOM. If I forget this point, I have to do it again, etc.
# Check your changes: you wrote:
{code}
<value xml:lang="it">Transactie #</value>
{code}
# There were other minor issues I don't remember now
> Have PIN payment transactions
> -----------------------------
>
> Key: OFBIZ-5241
> URL:
https://issues.apache.org/jira/browse/OFBIZ-5241> Project: OFBiz
> Issue Type: Improvement
> Components: accounting, specialpurpose/pos, specialpurpose/webpos
> Affects Versions: SVN trunk
> Reporter: Pierre Smits
> Fix For: SVN trunk
>
> Attachments: OFBIZ-5241-ACCTG-Labels.patch, OFBIZ-5241-ACCTG-PaymentType.patch, OFBIZ-5241-WEBPOS-PIN-Payment.patch
>
>
> In the Dutch market space it is customary to pay with pin. This should be incorporated
--
This message was sent by Atlassian JIRA
(v6.1#6144)
Locked
