[
https://issues.apache.org/jira/browse/OFBIZ-5164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13612701#comment-13612701 ]
Christoph Neuroth commented on OFBIZ-5164:
------------------------------------------
I'm not refusing, I'm trying to make a point. I'd like to improve the OfBiz code and I'm happy to follow style guides but I'd also like to see them up for polite discussion as is usual in open source projects. Parsing arguments and caching templates have absolutely nothing in common except for being loosely FreeMarker-related and I think packages are the better way to group functionality like this. Backing this up with a quote from "Clean Code" by Robert C. Martin:
{quote}The first rule of classes is that they should be small. The second rule of classes is that they should be smaller than that."{quote}
I'm happy to move the code (or you could just do it yourself after applying the patch), but I'd like to understand your reasoning.
Also, it should not only be in my interest to get this patch in but also in your own interest if you care about the quality of your project so your comment about my chances of getting it in diminishing is just not very constructive.
> Patch: Refactor Ofbiz*Transform to reduce deduplication
> -------------------------------------------------------
>
> Key: OFBIZ-5164
> URL:
https://issues.apache.org/jira/browse/OFBIZ-5164> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Christoph Neuroth
> Priority: Trivial
> Attachments: OFBIZ-5164.patch
>
>
> Leaving the campground a bit cleaner than I found it, please find attached a patch which removes some duplication from the *Transform classes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:
http://www.atlassian.com/software/jira
Locked
