[jira] [Commented] (OFBIZ-5126) Corrections and improvements to dependent drop-downs

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-5126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13562634#comment-13562634 ]

Jacques Le Roux commented on OFBIZ-5126:
----------------------------------------

Hi Taher,

The [Contributors Best Practices are here|https://cwiki.apache.org/confluence/display/OFBADMIN/OFBiz+Contributors+Best+Practices]

# We release a new version each year around April, and also for security bug fixes, see "Release Information" section at http://ofbiz.apache.org/download.html. You can always checkout the corresponding release branch from repo with lastest bug fixes.
# No features propagate (are backported), only bug fixes
# There are no easy way. You can follow [main new features here|at https://cwiki.apache.org/confluence/display/OFBIZ/Main+New+Features]. For backported bug fixes you need to look at the release branch svn log

Thanks for your patches, I will put them in trunk but all will not be backported, only the bug fix, so only setDependentDropdownValuesJs.ftl
               

> Corrections and improvements to dependent drop-downs
> ----------------------------------------------------
>
>                 Key: OFBIZ-5126
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-5126
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Taher Alkhateeb
>              Labels: dropdownlist, freemarker, javascript
>         Attachments: getDependentDropdownValues.patch, setDependentDropdownValuesJs.patch, setPriceRulesCondEventJs.patch
>
>
> The following items are included in this issue:
> 1) The setDependentDropdownValuesJs.ftl is using an incorrect argument which usually happens to work because it is a duplicate of another. See patch for details
> 2) The getDependentDropdownValues.js is modified with a new argument to allow for empty selections. Therefore, copying the behavior of form widget drop-down's "allow-empty"
> 3) There is only one file affected by item number 2 above, therefore, I fixed it to include the argument in getDependentDropdownValues.js

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira