[
https://issues.apache.org/jira/browse/OFBIZ-5122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13547648#comment-13547648 ]
Jacques Le Roux commented on OFBIZ-5122:
----------------------------------------
Few trivial remarks about your patch (see [OFBiz Contributors Best Practices|
https://cwiki.apache.org/confluence/display/OFBADMIN/OFBiz+Contributors+Best+Practices#OFBizContributorsBestPractices-HowtoSendinYourContributions(orhowtocreateandapplypatches)])
* When using Subclipse select project to avoid the 2 1st line
* Preferably do your patch from root
If this patch is committed it should be applied to trunk and backported to releases branches
More important: could you explain why you changed from PoolableConnectionFactory to PoolableManagedConnectionFactory?
> Memory leak due to transaction management using DBCP and MySQL
> --------------------------------------------------------------
>
> Key: OFBIZ-5122
> URL:
https://issues.apache.org/jira/browse/OFBIZ-5122> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Affects Versions: Release 09.04, Release 09.04.01, Release 10.04
> Environment: Linux, MySQL 5.5.28
> Reporter: Jose Manuel Vivó Arnal
> Priority: Critical
> Attachments: DBCPConnectionFactory-patch.txt
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> After several hours looking for the memory-leak, we found than the problem is the very same that OFBIZ-2599
> This issue has a patch file attached for DBCPConnectionFactory class (patch-DBCPConneectionFactory.txt) which is not applied to specified versions.
> We check that this patch solves the problem.
> Please, apply this patch.
> Thank you in advance.
> --
> Jose Manuel Vivó Arnal
> DiSiD Technologies (
http://www.disid.com)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:
http://www.atlassian.com/software/jira
Locked
