[
https://issues.apache.org/jira/browse/OFBIZ-4940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13598260#comment-13598260 ]
Alexander Reelsen commented on OFBIZ-4940:
------------------------------------------
Hey Paul,
Due to switching companies I no longer work with ofbiz, so I am of little help here. I can definately tell you, that we hit this thing in production and had a doubled tax on products, but maybe the product data was wrong at another point.
I still have the opinion, that filtering by dates should not be an issue and should be done by default at that code point.
But anyway, my involvement with ofbiz is gone, so if you do not consider this a bug, feel free to move on and close this bugreport, as I am not able to give you any more detailed insights from my outside position.
--Alexander
> TaxAuthorityServices try to filter by date without getting date fields
> ----------------------------------------------------------------------
>
> Key: OFBIZ-4940
> URL:
https://issues.apache.org/jira/browse/OFBIZ-4940> Project: OFBiz
> Issue Type: Bug
> Components: accounting
> Affects Versions: SVN trunk
> Reporter: Alexander Reelsen
>
> The TaxAuthorityServices try to get product category members and filter by date. However they do not get the fromDate/thruDate fields and therefore EntityUtil.filterByDate() fails silently. This can lead to accumulated tax when two different tax rates were active on two totally different time ranges.
> Fix is changing line 329 from
> List<GenericValue> pcmList = delegator.findList("ProductCategoryMember", productIdCond, UtilMisc.toSet("productCategoryId"), null, null, true);
> to
> List<GenericValue> pcmList = delegator.findList("ProductCategoryMember", productIdCond, UtilMisc.toSet("productCategoryId", "fromDate", "thruDate"), null, null, true);
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:
http://www.atlassian.com/software/jira
Locked
