[
https://issues.apache.org/jira/browse/OFBIZ-4794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13692910#comment-13692910 ]
Scott Gray commented on OFBIZ-4794:
-----------------------------------
I can't recall what the changes were, but I recall tweaks over the years.
I don't think running two or more instances on the same machine is such a common requirement that it should be a command line argument. When such adjustments are needed I don't think it's a big deal to find the configuration and change it, most devs know how to adjust the ports. The adjustment could also be environment specific depending on the app server being deployed with OFBiz (not necessarily embedded). I'm also not suggesting the use of patches as something for developers to be expected to use, I'm only suggesting them specifically for use within the Apache infrastructure. They don't even need to be kept in svn necessarily, the could just as easily reside in someone's apache home folder. That way no changes are needed within the project itself at all. The deployment environments within Apache infra would simply be no different to any other real world deployment.
I doubt you foresaw this config change either until people started talking about problems with Jenkins so I'm not sure that your argument is valid. I don't see how the port number is any different from any other configuration in OFBiz, they could all arguably be accessible through the command line but where do you draw the line? And how easy will it be for people to adjust these configurations when we support setting them in multiple ways?
I'm in favor of keeping OFBiz as simple as possible and covering the 90% of use cases while making the remainder easily solvable through normal configuration. I think this crosses a line of making things more complicated for a corner case instead of taking a more standard approach to solving a common deployment problem (the need to adjust the system configuration from their defaults).
> set different ports for testing in a CI environment (e.g. Jenkins)
> ------------------------------------------------------------------
>
> Key: OFBIZ-4794
> URL:
https://issues.apache.org/jira/browse/OFBIZ-4794> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Pierre Smits
> Assignee: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: OFBIZ-4794 - test port.patch, OFBIZ-4794-test-ports.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> In order to run test targets in Jenkins we need to change ports for at least ajp, http and https in test-containers.xml as these ports are most likely to be already in use by the CI server.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:
http://www.atlassian.com/software/jira
Locked
