[
https://issues.apache.org/jira/browse/OFBIZ-9346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15999974#comment-15999974 ]
Michael Brohl edited comment on OFBIZ-9346 at 5/7/17 7:22 PM:
--------------------------------------------------------------
It does not help to call review work bike-shedding. The issue for itself might be trivial, the consequences to put this and other patches of this kind to the codebase are not.
I'm still against applying this patch. It introduces unnecessarily generalized translatations. For example, in German "terms" can be translated to "Bedingungen". For the agreements, one might want to translate it into "Vertragsbedingungen", which is not appropriate in other contexts. So you would have to reintroduce the specialized label once again.
I'm not sure why you are insisting on this topic so much (did I hear the word "bike-shedding" from you?).
was (Author: mbrohl):
It does not help to call review work bike-shedding. The issue for itself might be trivial, the consequences to put this and and other patches of this kind to the codebase are not.
I'm still against applying this patch. It introduces unnecessarily generalized translatations. For example, in German "terms" can be translated to "Bedingungen". For the agreements, one might want to translate it into "Vertragsbedingungen", which is not appropriate in other contexts. So you would have to reintroduce the specialized label once again.
I'm not sure why you are insisting on this topic so much (did I hear the word "bike-shedding" from you?).
> Maximise utilisation of common labels in AccountingMenus.xml
> ------------------------------------------------------------
>
> Key: OFBIZ-9346
> URL:
https://issues.apache.org/jira/browse/OFBIZ-9346> Project: OFBiz
> Issue Type: Improvement
> Components: accounting
> Affects Versions: Trunk
> Reporter: Pierre Smits
> Assignee: Pierre Smits
> Priority: Minor
> Attachments: OFBIZ-9346-AccountingMenus-v2.patch, OFBIZ-9346-AccountingMenus.xml.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
Locked
