[
https://issues.apache.org/jira/browse/OFBIZ-5297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13757598#comment-13757598 ]
Taher Alkhateeb edited comment on OFBIZ-5297 at 9/4/13 9:36 AM:
----------------------------------------------------------------
Hi Parimal,
Your suggestion makes sense and feels more intuitive by running validation logic in the screen/form/script. If validation fails, we simply do not call the report .. I really like that!
This suggestion, however, means that we have two sets of code now: inside the report and outside. How do we make sure they both work when you change something?
So this brings a new problem in BIRT inside OFBiz: Testing! you can only call JUnit tests (okay, OFBizTestCase) which cannot call the code inside the reports! and it seems BIRT encapsulates exceptions which means I cannot catch them in my unit tests.
I feel a little stuck, does that mean we should always test manually? can we automate this?
was (Author: taher):
Hi Parimal,
Your suggestion makes sense and feels more intuitiveby running validation logic in the screen/form/script. If validation fails, we simply do not call the report .. I really like that!
This suggestion, however, means that we have two sets of code now: inside the report and outside. How do we make sure they both work when you change something?
So this brings a new problem in BIRT inside OFBiz: Testing! you can only call JUnit tests (okay, OFBizTestCase) which cannot call the code inside the reports! and it seems BIRT encapsulates exceptions which means I cannot catch them in my unit tests.
I feel a little stuck, does that mean we should always test manually? can we automate this?
> Order Report Issue
> ------------------
>
> Key: OFBIZ-5297
> URL:
https://issues.apache.org/jira/browse/OFBIZ-5297> Project: OFBiz
> Issue Type: Sub-task
> Components: order
> Affects Versions: Release Branch 11.04, SVN trunk
> Reporter: Parimal Gain
> Assignee: Jacques Le Roux
> Labels: Birt
> Fix For: SVN trunk
>
> Attachments: Last3MonthSalesReport.PNG, OFBIZ-5297-11.04.patch, OFBIZ-5297-Trunk.patch
>
>
> Reports under Order component has following issues -
> 1. Following reports are not showing any records due some issue
> a. Last three month sales report.
> b. Sales report.
> c. Sales Order discount code report.
> d. Product demand report.
> 2. Inconsistency in opening the pdf report - some reports are opening in new tab window but some are in the same window.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:
http://www.atlassian.com/software/jira
Locked
