[
https://issues.apache.org/jira/browse/OFBIZ-5279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13719320#comment-13719320 ]
Jacques Le Roux edited comment on OFBIZ-5279 at 7/25/13 7:20 AM:
-----------------------------------------------------------------
Thanks Wai Zhang,
I should have taken this fix more seriously (I was focused on smthg else). BTW really next time use a real patch, but yes my bad, thanks for review!
Committed at revision 1506828.
was (Author: jacques.le.roux):
Thanks Wai Zhang,
I should have taken this fix more seriously (I was focused on smthg else). BTW really next time use a real patch, but yes my bad, thanks for review!
> Wrong to use !jQuery('#content-messages') in \framework\images\webapp\images\selectall.js line #354
> ---------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-5279
> URL:
https://issues.apache.org/jira/browse/OFBIZ-5279> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Wei Zhang
> Attachments: patches.zip
>
>
> I think we should use
> if(jQuery('#content-messages').length==0)
> insead of
> if(!jQuery('#content-messages'))
> in framework\images\webapp\images\selectall.js line #354.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:
http://www.atlassian.com/software/jira
Locked
