[jira] [Closed] (OFBIZ-9345) Error viewing tomahawk-themed page when externalLoginKey is not enabled

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Closed] (OFBIZ-9345) Error viewing tomahawk-themed page when externalLoginKey is not enabled

Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-9345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-9345.
----------------------------------
       Resolution: Fixed
    Fix Version/s:     (was: Trunk)
                   16.11.02
                   Upcoming Release

Thanks James,

Your modified patch is in
trunk r1794008  
R16.11 r1794009

We don't need to create  externalKeyParam  in AppBarClose.ftl. It already exists in context.

I updated the  https://cwiki.apache.org/confluence/display/OFBIZ/Variables+always+available+in+screen+context page about that

BTW don't put "Trunk" in "Fix Version/s" field but "Upcoming Release". THiz is explained at https://cwiki.apache.org/confluence/display/OFBADMIN/OFBiz+Committers+Roles+and+Responsibilities#OFBizCommittersRolesandResponsibilities-ManageJIRA%27sissues

> Error viewing tomahawk-themed page when externalLoginKey is not enabled
> -----------------------------------------------------------------------
>
>                 Key: OFBIZ-9345
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-9345
>             Project: OFBiz
>          Issue Type: Bug
>          Components: themes
>    Affects Versions: Upcoming Release
>            Reporter: James Yong
>            Assignee: Jacques Le Roux
>            Priority: Minor
>              Labels: tomahawk
>             Fix For: Upcoming Release, 16.11.02
>
>         Attachments: OFBIZ-9345.patch
>
>
> The following error occurs when the theme is set to *tomahawk* and *security.login.externalLoginKey.enabled=false*:
> {code}
> 2017-05-04 22:57:42,818 |http-nio-8443-exec-8 |FreeMarkerWorker              |E| null
> freemarker.core.InvalidReferenceException: The following has evaluated to null or missing:
> ==> externalLoginKey  [in template "component://tomahawk/template/AppBarClose.ftl" at line 88, column 113]
> ----
> Tip: If the failing expression is known to be legally refer to something that's sometimes null or missing, either specify a default value like myOptionalVar!myDefault, or use <#if myOptionalVar??>when-present<#else>when-missing</#if>. (These only cover the last step of the expression; to cover the whole expression, use parenthesis: (myOptionalVar.foo)!myDefault, (myOptionalVar.foo)??
> ----
> ----
> FTL stack trace ("~" means nesting-related):
> - Failed at: ${externalLoginKey}  [in template "component://tomahawk/template/AppBarClose.ftl" at line 88, column 111]
> ----
> at freemarker.core.InvalidReferenceException.getInstance(InvalidReferenceException.java:134) ~[freemarker-2.3.25-incubating.jar:2.3.25]
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)