Re: svn commit: r911079 - in /ofbiz/trunk: framework/widget/templates/ themes/bizznesstime/webapp/bizznesstime/css/ themes/bluelight/webapp/bluelight/ themes/droppingcrumbs/webapp/droppingcrumbs/css/ themes/flatgrey/webapp/flatgrey/ themes/tomahawk/w

[Bruno Busco]

Adam,
I do not see which other changes I need to do.
I did not remove (yet) the calGif parameter from the macro.

-Bruno

2010/2/17 Adam Heath <[hidden email]>:

> [hidden email] wrote:
>> Author: buscob
>> Date: Wed Feb 17 17:17:52 2010
>> New Revision: 911079
>>
>> URL: http://svn.apache.org/viewvc?rev=911079&view=rev
>> Log:
>> The Visual Theme can now re-define the calendar button icon
>>
>> Modified:
>>     ofbiz/trunk/framework/widget/templates/htmlFormMacroLibrary.ftl
>
> You need to modify the other macro form libraries too, there are 2 others.
>

[Adam Heath-2]

Bruno Busco wrote:
> Adam,
> I do not see which other changes I need to do.
> I did not remove (yet) the calGif parameter from the macro.

When I investigated this, I found several hard-coded matches to
foo.gif stuff; there are 3 implementations of output methods for widgets.

>
> -Bruno
>
> 2010/2/17 Adam Heath <[hidden email]>:
>> [hidden email] wrote:
>>> Author: buscob
>>> Date: Wed Feb 17 17:17:52 2010
>>> New Revision: 911079
>>>
>>> URL: http://svn.apache.org/viewvc?rev=911079&view=rev
>>> Log:
>>> The Visual Theme can now re-define the calendar button icon
>>>
>>> Modified:
>>>     ofbiz/trunk/framework/widget/templates/htmlFormMacroLibrary.ftl
>> You need to modify the other macro form libraries too, there are 2 others.
>>

[Bruno Busco]

OK,
I see what you mean, thank you.
I will remove the calGif parameter from the macro.
It will be better code but the effect will be the same (I mean the
funcionality is already there).

-Bruno


2010/2/17 Adam Heath <[hidden email]>:

> Bruno Busco wrote:
>> Adam,
>> I do not see which other changes I need to do.
>> I did not remove (yet) the calGif parameter from the macro.
>
> When I investigated this, I found several hard-coded matches to
> foo.gif stuff; there are 3 implementations of output methods for widgets.
>
>>
>> -Bruno
>>
>> 2010/2/17 Adam Heath <[hidden email]>:
>>> [hidden email] wrote:
>>>> Author: buscob
>>>> Date: Wed Feb 17 17:17:52 2010
>>>> New Revision: 911079
>>>>
>>>> URL: http://svn.apache.org/viewvc?rev=911079&view=rev
>>>> Log:
>>>> The Visual Theme can now re-define the calendar button icon
>>>>
>>>> Modified:
>>>>     ofbiz/trunk/framework/widget/templates/htmlFormMacroLibrary.ftl
>>> You need to modify the other macro form libraries too, there are 2 others.
>>>
>
>