Re: svn commit: r902226 - /ofbiz/trunk/framework/entity/src/org/ofbiz/entity/jdbc/ConnectionFactory.java

[Adam Heath-2]

[hidden email] wrote:

> Author: lektran
> Date: Fri Jan 22 19:11:18 2010
> New Revision: 902226
>
> URL: http://svn.apache.org/viewvc?rev=902226&view=rev
> Log:
> Removed deprecated method ConnectionFactory.tryGenericConnectionSources(String, Element)
>
> Modified:
>     ofbiz/trunk/framework/entity/src/org/ofbiz/entity/jdbc/ConnectionFactory.java
>
> Modified: ofbiz/trunk/framework/entity/src/org/ofbiz/entity/jdbc/ConnectionFactory.java
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/entity/src/org/ofbiz/entity/jdbc/ConnectionFactory.java?rev=902226&r1=902225&r2=902226&view=diff
> ==============================================================================
> --- ofbiz/trunk/framework/entity/src/org/ofbiz/entity/jdbc/ConnectionFactory.java (original)
> +++ ofbiz/trunk/framework/entity/src/org/ofbiz/entity/jdbc/ConnectionFactory.java Fri Jan 22 19:11:18 2010
> @@ -78,11 +78,6 @@
>          return con;
>      }
>  
> -    @Deprecated
> -    public static Connection tryGenericConnectionSources(String helperName, Element inlineJdbcElement) throws SQLException, GenericEntityException {
> -        return getManagedConnectionFactory().getConnection(helperName, inlineJdbcElement);
> -    }
> -
>      public static ConnectionFactoryInterface getManagedConnectionFactory() {
>          if (_factory == null) { // don't want to block here
>              synchronized (TransactionFactory.class) {
>

If something is deprecated, then it should be in the release notes(for
major releases).  Then, when it finally *is* removed, it should again
be listed in release notes, saying such.

[Scott Gray-2]

On 22/01/2010, at 12:23 PM, Adam Heath wrote:

> [hidden email] wrote:
>> Author: lektran
>> Date: Fri Jan 22 19:11:18 2010
>> New Revision: 902226
>>
>> URL: http://svn.apache.org/viewvc?rev=902226&view=rev
>> Log:
>> Removed deprecated method ConnectionFactory.tryGenericConnectionSources(String, Element)
>>
>> Modified:
>>    ofbiz/trunk/framework/entity/src/org/ofbiz/entity/jdbc/ConnectionFactory.java
>>
>> Modified: ofbiz/trunk/framework/entity/src/org/ofbiz/entity/jdbc/ConnectionFactory.java
>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/entity/src/org/ofbiz/entity/jdbc/ConnectionFactory.java?rev=902226&r1=902225&r2=902226&view=diff
>> ==============================================================================
>> --- ofbiz/trunk/framework/entity/src/org/ofbiz/entity/jdbc/ConnectionFactory.java (original)
>> +++ ofbiz/trunk/framework/entity/src/org/ofbiz/entity/jdbc/ConnectionFactory.java Fri Jan 22 19:11:18 2010
>> @@ -78,11 +78,6 @@
>>         return con;
>>     }
>>
>> -    @Deprecated
>> -    public static Connection tryGenericConnectionSources(String helperName, Element inlineJdbcElement) throws SQLException, GenericEntityException {
>> -        return getManagedConnectionFactory().getConnection(helperName, inlineJdbcElement);
>> -    }
>> -
>>     public static ConnectionFactoryInterface getManagedConnectionFactory() {
>>         if (_factory == null) { // don't want to block here
>>             synchronized (TransactionFactory.class) {
>>
>
> If something is deprecated, then it should be in the release notes(for
> major releases).  Then, when it finally *is* removed, it should again
> be listed in release notes, saying such.

I'm just following what has been done in the past, if you want to setup a new procedure then feel free and I'll be happy to follow it.

Regards
Scott