Re: svn commit: r893313 - in /ofbiz/trunk/framework/base/src/org/ofbiz/base: conversion/DateTimeConverters.java test/BaseUnitTests.java

[Adam Heath-2]

[hidden email] wrote:
> Author: adrianc
> Date: Tue Dec 22 20:54:55 2009
> New Revision: 893313

> +            String target = dateToString.convert(utilDate);
> +            assertTrue(buildConversionMessage("DateToString", utilDate.toString(), target), utilDate.toString().equals(target));

No, do not use assertTrue.  Use assertEquals, so that you get "got
foo, expected bar" message from junit.

[Adrian Crum]

Adam Heath wrote:

> [hidden email] wrote:
>> Author: adrianc
>> Date: Tue Dec 22 20:54:55 2009
>> New Revision: 893313
>
>> +            String target = dateToString.convert(utilDate);
>> +            assertTrue(buildConversionMessage("DateToString", utilDate.toString(), target), utilDate.toString().equals(target));
>
> No, do not use assertTrue.  Use assertEquals, so that you get "got
> foo, expected bar" message from junit.

Cool. Thanks!