Re: svn commit: r892579 - in /ofbiz/trunk/framework: common/webcommon/includes/ common/widget/ example/webapp/example/WEB-INF/ example/widget/example/

[Erwan de FERRIERES-3]

Le 20/12/2009 10:41, [hidden email] a écrit :

> Author: buscob
> Date: Sun Dec 20 09:41:03 2009
> New Revision: 892579
>
> URL: http://svn.apache.org/viewvc?rev=892579&view=rev
> Log:
> Added the geoChart common screen. (OFBIZ-3348)
> This can be used to show a set of geo points on a Google map.
> The screen takes as input a geoChart map containing:
>      * dataSourceId ->  select the map system to be used (google, yahoo etc.)
>      * width ->  map dimensions
>      * height ->  map dimensions
>      * center ->  the center point of the map
>      * points ->  the points array to be showed on the map

Hi Bruno,

why did you created a new geolocation.ftl file, and didn't used the one
in common/webcommon/WEB-INF/ for your new geoChart screen ?

Also, when using the bizness time theme, the maps in example are located
on the button bar, which makes it impossible to select the 4th map. With
the other themes, it's ok. Could you take a look please, I didn't find
the problem easily...

Thanks,

--
Erwan de FERRIERES
www.nereide.biz

[Bruno Busco]

Hi Erwan,
I did not use the exixting geolocation.ftl file because it does
different things of what need to be done with the new screen I
created. In addition the pre-existing geolocation.ftl file does not
seem to be in the proper folder (generally FTL files should not stay
in WEB-INF).
I think, if we agree, we could replace the old geoLocation screen with
the new geoChart and thus removing the geolocation.ftl file in the
WEB-INF folder.

Regarding the wrong display with the bizznesstime theme, I will give a
look as soon as I can.

Thank you for reporting this,
Bruno


2009/12/21 Erwan de FERRIERES <[hidden email]>:

>
>
> Le 20/12/2009 10:41, [hidden email] a écrit :
>>
>> Author: buscob
>> Date: Sun Dec 20 09:41:03 2009
>> New Revision: 892579
>>
>> URL: http://svn.apache.org/viewvc?rev=892579&view=rev
>> Log:
>> Added the geoChart common screen. (OFBIZ-3348)
>> This can be used to show a set of geo points on a Google map.
>> The screen takes as input a geoChart map containing:
>>     * dataSourceId ->  select the map system to be used (google, yahoo
>> etc.)
>>     * width ->  map dimensions
>>     * height ->  map dimensions
>>     * center ->  the center point of the map
>>     * points ->  the points array to be showed on the map
>
> Hi Bruno,
>
> why did you created a new geolocation.ftl file, and didn't used the one in
> common/webcommon/WEB-INF/ for your new geoChart screen ?
>
> Also, when using the bizness time theme, the maps in example are located on
> the button bar, which makes it impossible to select the 4th map. With the
> other themes, it's ok. Could you take a look please, I didn't find the
> problem easily...
>
> Thanks,
>
> --
> Erwan de FERRIERES
> www.nereide.biz
>

[Jacques Le Roux]

Hi Burno, Erwan

I agree the new geolocation.ftl subsumes the former and its place is better as well +1 (I wrote the 1st and put it there definitely
by carelessness)

Thanks

Jacques

From: "Bruno Busco" <[hidden email]>

> Hi Erwan,
> I did not use the exixting geolocation.ftl file because it does
> different things of what need to be done with the new screen I
> created. In addition the pre-existing geolocation.ftl file does not
> seem to be in the proper folder (generally FTL files should not stay
> in WEB-INF).
> I think, if we agree, we could replace the old geoLocation screen with
> the new geoChart and thus removing the geolocation.ftl file in the
> WEB-INF folder.
>
> Regarding the wrong display with the bizznesstime theme, I will give a
> look as soon as I can.
>
> Thank you for reporting this,
> Bruno
>
>
> 2009/12/21 Erwan de FERRIERES <[hidden email]>:
>>
>>
>> Le 20/12/2009 10:41, [hidden email] a écrit :
>>>
>>> Author: buscob
>>> Date: Sun Dec 20 09:41:03 2009
>>> New Revision: 892579
>>>
>>> URL: http://svn.apache.org/viewvc?rev=892579&view=rev
>>> Log:
>>> Added the geoChart common screen. (OFBIZ-3348)
>>> This can be used to show a set of geo points on a Google map.
>>> The screen takes as input a geoChart map containing:
>>> * dataSourceId -> select the map system to be used (google, yahoo
>>> etc.)
>>> * width -> map dimensions
>>> * height -> map dimensions
>>> * center -> the center point of the map
>>> * points -> the points array to be showed on the map
>>
>> Hi Bruno,
>>
>> why did you created a new geolocation.ftl file, and didn't used the one in
>> common/webcommon/WEB-INF/ for your new geoChart screen ?
>>
>> Also, when using the bizness time theme, the maps in example are located on
>> the button bar, which makes it impossible to select the 4th map. With the
>> other themes, it's ok. Could you take a look please, I didn't find the
>> problem easily...
>>
>> Thanks,
>>
>> --
>> Erwan de FERRIERES
>> www.nereide.biz
>>
>

[Erwan de FERRIERES-3]

Le 21/12/2009 12:37, Bruno Busco a écrit :
> Hi Erwan,
> I did not use the exixting geolocation.ftl file because it does
> different things of what need to be done with the new screen I
> created. In addition the pre-existing geolocation.ftl file does not
> seem to be in the proper folder (generally FTL files should not stay
> in WEB-INF).
> I think, if we agree, we could replace the old geoLocation screen with
> the new geoChart and thus removing the geolocation.ftl file in the
> WEB-INF folder.

It's fine with me !

>
> Regarding the wrong display with the bizznesstime theme, I will give a
> look as soon as I can.
>
> Thank you for reporting this,
> Bruno
>
>

--
Erwan de FERRIERES
www.nereide.biz

[Erwan de FERRIERES-3]

Bruno,

I've made a new example based on your geolocaton examples. This one is
using the address for locating the point on the map. I've attached the
patch to this JIRA issue :
https://issues.apache.org/jira/browse/OFBIZ-2930

If it's ok with you I will commit it. I'm waiting for your comments.

Regards,

Le 21/12/2009 12:37, Bruno Busco a écrit :
../..

--
Erwan de FERRIERES
www.nereide.biz