Re: svn commit: r1499918 - in /ofbiz/trunk/applications: marketing/widget/sfa/SfaMenus.xml order/widget/ordermgr/OrderMenus.xml

[Adrian Crum-3]

This doesn't make sense. Why are those two menu items exceptions to the
rule?

-Adrian

On 7/5/2013 7:57 AM, [hidden email] wrote:

> Author: jleroux
> Date: Fri Jul  5 06:57:03 2013
> New Revision: 1499918
>
> URL: http://svn.apache.org/r1499918
> Log:
> A patch from Deepak Dixit for "Application Menu items should be link not hidden form." https://issues.apache.org/jira/browse/OFBIZ-4913
>
> Application menu item should be link not hidden form. As if its hidden form then you can not open it in new tab.
> Default menu item link type auto, and its create an hidden for for link if controller request call an event, but in menu item this should be link.
>
> Modified:
>      ofbiz/trunk/applications/marketing/widget/sfa/SfaMenus.xml
>      ofbiz/trunk/applications/order/widget/ordermgr/OrderMenus.xml
>
> Modified: ofbiz/trunk/applications/marketing/widget/sfa/SfaMenus.xml
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/marketing/widget/sfa/SfaMenus.xml?rev=1499918&r1=1499917&r2=1499918&view=diff
> ==============================================================================
> --- ofbiz/trunk/applications/marketing/widget/sfa/SfaMenus.xml (original)
> +++ ofbiz/trunk/applications/marketing/widget/sfa/SfaMenus.xml Fri Jul  5 06:57:03 2013
> @@ -28,7 +28,7 @@ under the License.
>           <menu-item name="Forecast" title="${uiLabelMap.SfaForecasts}"><link target="FindSalesForecast"/></menu-item>
>           <menu-item name="Opportunities" title="${uiLabelMap.SfaOpportunities}"><link target="FindSalesOpportunity"/></menu-item>
>           <menu-item name="Preferences" title="${uiLabelMap.CommonPreferences}" align-style="opposed">
> -            <link target="ManagePortalPages">
> +            <link target="ManagePortalPages" link-type="anchor">
>                   <parameter param-name="parentPortalPageId" from-field="parameters.parentPortalPageId"/>
>               </link>
>           </menu-item>
>
> Modified: ofbiz/trunk/applications/order/widget/ordermgr/OrderMenus.xml
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/widget/ordermgr/OrderMenus.xml?rev=1499918&r1=1499917&r2=1499918&view=diff
> ==============================================================================
> --- ofbiz/trunk/applications/order/widget/ordermgr/OrderMenus.xml (original)
> +++ ofbiz/trunk/applications/order/widget/ordermgr/OrderMenus.xml Fri Jul  5 06:57:03 2013
> @@ -60,7 +60,7 @@ under the License.
>                       <if-has-permission permission="ORDERMGR" action="_PURCHASE_CREATE"/>
>                   </or>
>               </condition>
> -            <link target="orderentry"/>
> +            <link target="orderentry" link-type="anchor"/>
>           </menu-item>
>  
>           <menu-item name="return" title="${uiLabelMap.OrderOrderReturns}">
>
>

[Deepak Dixit-2]

Hi Adrian,

These controller request has "event", and if an request event attribute is not null then WidgetWorker.determineAutoLinkType() return hidden-form as link type and its create an empty form for the same.
WidgetWorker method convert hyper links to hidden for for service type of event as we allow only post parameter for service.

Thanks & Regards
--
Deepak Dixit
HotWax Media Pvt. Ltd.
www.hotwaxmedia.com
Contact :- [phone]
Skype  :- deepakdixit

On Jul 5, 2013, at 4:32 PM, Adrian Crum wrote:

> This doesn't make sense. Why are those two menu items exceptions to the rule?
>
> -Adrian
>
> On 7/5/2013 7:57 AM, [hidden email] wrote:
>> Author: jleroux
>> Date: Fri Jul  5 06:57:03 2013
>> New Revision: 1499918
>>
>> URL: http://svn.apache.org/r1499918
>> Log:
>> A patch from Deepak Dixit for "Application Menu items should be link not hidden form." https://issues.apache.org/jira/browse/OFBIZ-4913
>>
>> Application menu item should be link not hidden form. As if its hidden form then you can not open it in new tab.
>> Default menu item link type auto, and its create an hidden for for link if controller request call an event, but in menu item this should be link.
>>
>> Modified:
>>     ofbiz/trunk/applications/marketing/widget/sfa/SfaMenus.xml
>>     ofbiz/trunk/applications/order/widget/ordermgr/OrderMenus.xml
>>
>> Modified: ofbiz/trunk/applications/marketing/widget/sfa/SfaMenus.xml
>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/marketing/widget/sfa/SfaMenus.xml?rev=1499918&r1=1499917&r2=1499918&view=diff
>> ==============================================================================
>> --- ofbiz/trunk/applications/marketing/widget/sfa/SfaMenus.xml (original)
>> +++ ofbiz/trunk/applications/marketing/widget/sfa/SfaMenus.xml Fri Jul  5 06:57:03 2013
>> @@ -28,7 +28,7 @@ under the License.
>>          <menu-item name="Forecast" title="${uiLabelMap.SfaForecasts}"><link target="FindSalesForecast"/></menu-item>
>>          <menu-item name="Opportunities" title="${uiLabelMap.SfaOpportunities}"><link target="FindSalesOpportunity"/></menu-item>
>>          <menu-item name="Preferences" title="${uiLabelMap.CommonPreferences}" align-style="opposed">
>> -            <link target="ManagePortalPages">
>> +            <link target="ManagePortalPages" link-type="anchor">
>>                  <parameter param-name="parentPortalPageId" from-field="parameters.parentPortalPageId"/>
>>              </link>
>>          </menu-item>
>>
>> Modified: ofbiz/trunk/applications/order/widget/ordermgr/OrderMenus.xml
>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/widget/ordermgr/OrderMenus.xml?rev=1499918&r1=1499917&r2=1499918&view=diff
>> ==============================================================================
>> --- ofbiz/trunk/applications/order/widget/ordermgr/OrderMenus.xml (original)
>> +++ ofbiz/trunk/applications/order/widget/ordermgr/OrderMenus.xml Fri Jul  5 06:57:03 2013
>> @@ -60,7 +60,7 @@ under the License.
>>                      <if-has-permission permission="ORDERMGR" action="_PURCHASE_CREATE"/>
>>                  </or>
>>              </condition>
>> -            <link target="orderentry"/>
>> +            <link target="orderentry" link-type="anchor"/>
>>          </menu-item>
>>            <menu-item name="return" title="${uiLabelMap.OrderOrderReturns}">
>>
>>
>

[Adrian Crum-3]

On 7/5/2013 12:19 PM, Deepak Dixit wrote:
> Hi Adrian,
>
> These controller request has "event", and if an request event attribute is not null then WidgetWorker.determineAutoLinkType() return hidden-form as link type and its create an empty form for the same.
> WidgetWorker method convert hyper links to hidden for for service type of event as we allow only post parameter for service.
>
> Thanks & Regards

[Adrian Crum-3]

That doesn't answer my question. Why are only two requests being
changed? What makes those two requests the exception to all other
requests that include an event?

-Adrian

On 7/5/2013 12:19 PM, Deepak Dixit wrote:
> Hi Adrian,
>
> These controller request has "event", and if an request event attribute is not null then WidgetWorker.determineAutoLinkType() return hidden-form as link type and its create an empty form for the same.
> WidgetWorker method convert hyper links to hidden for for service type of event as we allow only post parameter for service.
>
> Thanks & Regards

[Deepak Dixit-2]

I found these reported request :)

All the request with event attribute will be render in same way and create hidden form.

Thanks & Regards
--
Deepak Dixit


On Jul 5, 2013, at 5:04 PM, Adrian Crum wrote:

> That doesn't answer my question. Why are only two requests being changed? What makes those two requests the exception to all other requests that include an event?
>
> -Adrian
>
> On 7/5/2013 12:19 PM, Deepak Dixit wrote:
>> Hi Adrian,
>>
>> These controller request has "event", and if an request event attribute is not null then WidgetWorker.determineAutoLinkType() return hidden-form as link type and its create an empty form for the same.
>> WidgetWorker method convert hyper links to hidden for for service type of event as we allow only post parameter for service.
>>
>> Thanks & Regards
>

[Jacques Le Roux]

Yes I wondered about that also, but, from his assertion, thought Deepak checked all others

Deepak?

Jacques

From: "Adrian Crum" <[hidden email]>

> That doesn't answer my question. Why are only two requests being
> changed? What makes those two requests the exception to all other
> requests that include an event?
>
> -Adrian
>
> On 7/5/2013 12:19 PM, Deepak Dixit wrote:
>> Hi Adrian,
>>
>> These controller request has "event", and if an request event attribute is not null then WidgetWorker.determineAutoLinkType() return hidden-form as link type and its create an empty form for the same.
>> WidgetWorker method convert hyper links to hidden for for service type of event as we allow only post parameter for service.
>>
>> Thanks & Regards
>

[Deepak Dixit-2]

I checked all the possible menu items.

Thanks & Regards
--
Deepak Dixit

On Jul 5, 2013, at 7:33 PM, Jacques Le Roux wrote:

> Yes I wondered about that also, but, from his assertion, thought Deepak checked all others
>
> Deepak?
>
> Jacques
>
> From: "Adrian Crum" <[hidden email]>
>> That doesn't answer my question. Why are only two requests being
>> changed? What makes those two requests the exception to all other
>> requests that include an event?
>>
>> -Adrian
>>
>> On 7/5/2013 12:19 PM, Deepak Dixit wrote:
>>> Hi Adrian,
>>>
>>> These controller request has "event", and if an request event attribute is not null then WidgetWorker.determineAutoLinkType() return hidden-form as link type and its create an empty form for the same.
>>> WidgetWorker method convert hyper links to hidden for for service type of event as we allow only post parameter for service.
>>>
>>> Thanks & Regards
>>

[Jacques Le Roux]

Hi Deepak, Adrian,

If I understood well, only menu items are concerned. Because there are no reasons to want a hidden form for a menu item.
In other cases, for security reasons, we want to be sure to have hidden forms.

If we need to check all menus items, we either need to create a tool or rely on manpower

As I don't want to create a tool for that, I checked all the main applications menu items on trunk demo, all correct.

If we could coordonate with some users we could easily check all other sub-menu items (only 17 apps)
I will ask for help on user ML, let's see...

Jacques

Deepak Dixit wrote:

> I found these reported request :)
>
> All the request with event attribute will be render in same way and create hidden form.
>
> Thanks & Regards
>
>> That doesn't answer my question. Why are only two requests being changed? What makes those two requests the exception to all
>> other requests that include an event?
>>
>> -Adrian
>>
>> On 7/5/2013 12:19 PM, Deepak Dixit wrote:
>>> Hi Adrian,
>>>
>>> These controller request has "event", and if an request event attribute is not null then WidgetWorker.determineAutoLinkType()
>>> return hidden-form as link type and its create an empty form for the same. WidgetWorker method convert hyper links to hidden
>>> for for service type of event as we allow only post parameter for service.
>>>
>>> Thanks & Regards

[Jacques Le Roux]

Hoo, thanks Deepak!

Jacques

Deepak Dixit wrote:

> I checked all the possible menu items.
>
> Thanks & Regards
>
>> Yes I wondered about that also, but, from his assertion, thought Deepak checked all others
>>
>> Deepak?
>>
>> Jacques
>>
>> From: "Adrian Crum" <[hidden email]>
>>> That doesn't answer my question. Why are only two requests being
>>> changed? What makes those two requests the exception to all other
>>> requests that include an event?
>>>
>>> -Adrian
>>>
>>> On 7/5/2013 12:19 PM, Deepak Dixit wrote:
>>>> Hi Adrian,
>>>>
>>>> These controller request has "event", and if an request event attribute is not null then WidgetWorker.determineAutoLinkType()
>>>> return hidden-form as link type and its create an empty form for the same. WidgetWorker method convert hyper links to hidden
>>>> for for service type of event as we allow only post parameter for service.
>>>>
>>>> Thanks & Regards

[Scott Gray-2]

IMO the bigger question to consider is why does this link have an event attached to it?  What makes it so special that it needs one when virtually every other navigation link doesn't?

Regards
Scott

On 6/07/2013, at 8:18 PM, Jacques Le Roux wrote:

> Hoo, thanks Deepak!
>
> Jacques
>
> Deepak Dixit wrote:
>> I checked all the possible menu items.
>>
>> Thanks & Regards
>>
>>> Yes I wondered about that also, but, from his assertion, thought Deepak checked all others
>>>
>>> Deepak?
>>>
>>> Jacques
>>>
>>> From: "Adrian Crum" <[hidden email]>
>>>> That doesn't answer my question. Why are only two requests being
>>>> changed? What makes those two requests the exception to all other
>>>> requests that include an event?
>>>>
>>>> -Adrian
>>>>
>>>> On 7/5/2013 12:19 PM, Deepak Dixit wrote:
>>>>> Hi Adrian,
>>>>>
>>>>> These controller request has "event", and if an request event attribute is not null then WidgetWorker.determineAutoLinkType()
>>>>> return hidden-form as link type and its create an empty form for the same. WidgetWorker method convert hyper links to hidden
>>>>> for for service type of event as we allow only post parameter for service.
>>>>>
>>>>> Thanks & Regards

[Jacques Le Roux]

Yes another solution would have been to create services.
But it's more work and need to analyse why it's like that if we don't want to introduce possible regressions
After all, it's just about being able to open a menu-item in a tab

Jacques

From: "Scott Gray" <[hidden email]>

> IMO the bigger question to consider is why does this link have an event attached to it?  What makes it so special that it needs one when virtually every other navigation link doesn't?
>
> Regards
> Scott
>
> On 6/07/2013, at 8:18 PM, Jacques Le Roux wrote:
>
>> Hoo, thanks Deepak!
>>
>> Jacques
>>
>> Deepak Dixit wrote:
>>> I checked all the possible menu items.
>>>
>>> Thanks & Regards
>>>
>>>> Yes I wondered about that also, but, from his assertion, thought Deepak checked all others
>>>>
>>>> Deepak?
>>>>
>>>> Jacques
>>>>
>>>> From: "Adrian Crum" <[hidden email]>
>>>>> That doesn't answer my question. Why are only two requests being
>>>>> changed? What makes those two requests the exception to all other
>>>>> requests that include an event?
>>>>>
>>>>> -Adrian
>>>>>
>>>>> On 7/5/2013 12:19 PM, Deepak Dixit wrote:
>>>>>> Hi Adrian,
>>>>>>
>>>>>> These controller request has "event", and if an request event attribute is not null then WidgetWorker.determineAutoLinkType()
>>>>>> return hidden-form as link type and its create an empty form for the same. WidgetWorker method convert hyper links to hidden
>>>>>> for for service type of event as we allow only post parameter for service.
>>>>>>
>>>>>> Thanks & Regards
>
>