Re: svn commit: r1482796 - /ofbiz/trunk/framework/entity/dtd/entity-config.xsd

[Jacopo Cappellato-4]

Jacques,

please do not remove these settings because they may be used to integrate other XA integrations; for example I have used pool-xa-wrapper-class to integrate Atomikos TX (and hopefully this code will be contributed as soon as we will fix the final issues I am having with it, there is a Jira task for this); in fact I don't think that they are specific to XA Pool.

Jacopo

On May 15, 2013, at 2:50 PM, [hidden email] wrote:

> Author: jleroux
> Date: Wed May 15 12:50:54 2013
> New Revision: 1482796
>
> URL: http://svn.apache.org/r1482796
> Log:
> When I moved XA Pool to the Attic I forgot to remove these XA Pool specific attributes. There were now misleading.
>
> Modified:
>    ofbiz/trunk/framework/entity/dtd/entity-config.xsd
>
> Modified: ofbiz/trunk/framework/entity/dtd/entity-config.xsd
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/entity/dtd/entity-config.xsd?rev=1482796&r1=1482795&r2=1482796&view=diff
> ==============================================================================
> --- ofbiz/trunk/framework/entity/dtd/entity-config.xsd (original)
> +++ ofbiz/trunk/framework/entity/dtd/entity-config.xsd Wed May 15 12:50:54 2013
> @@ -462,12 +462,6 @@ under the License.
>             </xs:annotation>
>         </xs:attribute>
>         <xs:attribute type="xs:nonNegativeInteger" name="time-between-eviction-runs-millis" default="600000"/>
> -        <xs:attribute type="xs:nonNegativeInteger" name="pool-sleeptime" default="300000"/>
> -        <xs:attribute type="xs:nonNegativeInteger" name="pool-lifetime" default="600000"/>
> -        <xs:attribute type="xs:nonNegativeInteger" name="pool-deadlock-maxwait" default="300000"/>
> -        <xs:attribute type="xs:nonNegativeInteger" name="pool-deadlock-retrywait" default="10000"/>
> -        <xs:attribute type="xs:string" name="pool-jdbc-test-stmt"/>
> -        <xs:attribute type="xs:string" name="pool-xa-wrapper-class"/>
>     </xs:attributeGroup>
>     <xs:element name="jndi-jdbc">
>         <xs:complexType>
>
>

[Jacques Le Roux]

Then we should at least put a comment for now, because there are unused OOTB for now and this can be misleading

I will do so

Jacques

From: "Jacopo Cappellato" <[hidden email]>

> Jacques,
>
> please do not remove these settings because they may be used to integrate other XA integrations; for example I have used pool-xa-wrapper-class to integrate Atomikos TX (and hopefully this code will be contributed as soon as we will fix the final issues I am having with it, there is a Jira task for this); in fact I don't think that they are specific to XA Pool.
>
> Jacopo
>
> On May 15, 2013, at 2:50 PM, [hidden email] wrote:
>
>> Author: jleroux
>> Date: Wed May 15 12:50:54 2013
>> New Revision: 1482796
>>
>> URL: http://svn.apache.org/r1482796
>> Log:
>> When I moved XA Pool to the Attic I forgot to remove these XA Pool specific attributes. There were now misleading.
>>
>> Modified:
>>    ofbiz/trunk/framework/entity/dtd/entity-config.xsd
>>
>> Modified: ofbiz/trunk/framework/entity/dtd/entity-config.xsd
>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/entity/dtd/entity-config.xsd?rev=1482796&r1=1482795&r2=1482796&view=diff
>> ==============================================================================
>> --- ofbiz/trunk/framework/entity/dtd/entity-config.xsd (original)
>> +++ ofbiz/trunk/framework/entity/dtd/entity-config.xsd Wed May 15 12:50:54 2013
>> @@ -462,12 +462,6 @@ under the License.
>>             </xs:annotation>
>>         </xs:attribute>
>>         <xs:attribute type="xs:nonNegativeInteger" name="time-between-eviction-runs-millis" default="600000"/>
>> -        <xs:attribute type="xs:nonNegativeInteger" name="pool-sleeptime" default="300000"/>
>> -        <xs:attribute type="xs:nonNegativeInteger" name="pool-lifetime" default="600000"/>
>> -        <xs:attribute type="xs:nonNegativeInteger" name="pool-deadlock-maxwait" default="300000"/>
>> -        <xs:attribute type="xs:nonNegativeInteger" name="pool-deadlock-retrywait" default="10000"/>
>> -        <xs:attribute type="xs:string" name="pool-jdbc-test-stmt"/>
>> -        <xs:attribute type="xs:string" name="pool-xa-wrapper-class"/>
>>     </xs:attributeGroup>
>>     <xs:element name="jndi-jdbc">
>>         <xs:complexType>
>>
>>
>
>

[Adam Heath-2]

Is there code in ofbiz that reads these attributes?  Do they get
stored into some kind of light-weight container class?  If no, then
they *should* be removed.  If such code does exist, then this was just
a pure bug.

However, there should be a new way to 'extend' for downstreams that
want to have non-standard features.  And this goes for *any* set of
feature.

ps: I know this was an xsd, which are hard to plug into with
additional xml elements; some other way would need to be found,
possibly placing these values into a separate file.

pps: Until such an extension can be done, this change should be
reverted.  There are 2 requests to do so(Jacopo is one, I'm another),
which I believe is enough.

On 05/15/2013 10:17 AM, Jacques Le Roux wrote:

> Then we should at least put a comment for now, because there are unused OOTB for now and this can be misleading
>
> I will do so
>
> Jacques
>
> From: "Jacopo Cappellato" <[hidden email]>
>> Jacques,
>>
>> please do not remove these settings because they may be used to integrate other XA integrations; for example I have used pool-xa-wrapper-class to integrate Atomikos TX (and hopefully this code will be contributed as soon as we will fix the final issues I am having with it, there is a Jira task for this); in fact I don't think that they are specific to XA Pool.
>>
>> Jacopo
>>
>> On May 15, 2013, at 2:50 PM, [hidden email] wrote:
>>
>>> Author: jleroux
>>> Date: Wed May 15 12:50:54 2013
>>> New Revision: 1482796
>>>
>>> URL: http://svn.apache.org/r1482796
>>> Log:
>>> When I moved XA Pool to the Attic I forgot to remove these XA Pool specific attributes. There were now misleading.
>>>
>>> Modified:
>>>    ofbiz/trunk/framework/entity/dtd/entity-config.xsd
>>>
>>> Modified: ofbiz/trunk/framework/entity/dtd/entity-config.xsd
>>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/entity/dtd/entity-config.xsd?rev=1482796&r1=1482795&r2=1482796&view=diff
>>> ==============================================================================
>>> --- ofbiz/trunk/framework/entity/dtd/entity-config.xsd (original)
>>> +++ ofbiz/trunk/framework/entity/dtd/entity-config.xsd Wed May 15 12:50:54 2013
>>> @@ -462,12 +462,6 @@ under the License.
>>>             </xs:annotation>
>>>         </xs:attribute>
>>>         <xs:attribute type="xs:nonNegativeInteger" name="time-between-eviction-runs-millis" default="600000"/>
>>> -        <xs:attribute type="xs:nonNegativeInteger" name="pool-sleeptime" default="300000"/>
>>> -        <xs:attribute type="xs:nonNegativeInteger" name="pool-lifetime" default="600000"/>
>>> -        <xs:attribute type="xs:nonNegativeInteger" name="pool-deadlock-maxwait" default="300000"/>
>>> -        <xs:attribute type="xs:nonNegativeInteger" name="pool-deadlock-retrywait" default="10000"/>
>>> -        <xs:attribute type="xs:string" name="pool-jdbc-test-stmt"/>
>>> -        <xs:attribute type="xs:string" name="pool-xa-wrapper-class"/>
>>>     </xs:attributeGroup>
>>>     <xs:element name="jndi-jdbc">
>>>         <xs:complexType>
>>>
>>>
>>
>>

[Jacques Le Roux]

From: "Adam Heath" <[hidden email]>
> Is there code in ofbiz that reads these attributes?  Do they get
> stored into some kind of light-weight container class?  If no, then
> they *should* be removed.  If such code does exist, then this was just
> a pure bug.

I did remove them because they were not referenced anywhere in OFBiz trunk.
But soon Jacopo will need them. So at r1482911 I simply documented that they were not implemented at the moment. Up to Jacopo, and anyone interested actually, to document them when implemented...
 
> However, there should be a new way to 'extend' for downstreams that
> want to have non-standard features.  And this goes for *any* set of
> feature.

Agreed, can be useful, not a current need for me.

> ps: I know this was an xsd, which are hard to plug into with
> additional xml elements; some other way would need to be found,
> possibly placing these values into a separate file.
>
> pps: Until such an extension can be done, this change should be
> reverted.  There are 2 requests to do so(Jacopo is one, I'm another),
> which I believe is enough.

Done

Jacques

> On 05/15/2013 10:17 AM, Jacques Le Roux wrote:
>> Then we should at least put a comment for now, because there are unused OOTB for now and this can be misleading
>>
>> I will do so
>>
>> Jacques
>>
>> From: "Jacopo Cappellato" <[hidden email]>
>>> Jacques,
>>>
>>> please do not remove these settings because they may be used to integrate other XA integrations; for example I have used pool-xa-wrapper-class to integrate Atomikos TX (and hopefully this code will be contributed as soon as we will fix the final issues I am having with it, there is a Jira task for this); in fact I don't think that they are specific to XA Pool.
>>>
>>> Jacopo
>>>
>>> On May 15, 2013, at 2:50 PM, [hidden email] wrote:
>>>
>>>> Author: jleroux
>>>> Date: Wed May 15 12:50:54 2013
>>>> New Revision: 1482796
>>>>
>>>> URL: http://svn.apache.org/r1482796
>>>> Log:
>>>> When I moved XA Pool to the Attic I forgot to remove these XA Pool specific attributes. There were now misleading.
>>>>
>>>> Modified:
>>>>    ofbiz/trunk/framework/entity/dtd/entity-config.xsd
>>>>
>>>> Modified: ofbiz/trunk/framework/entity/dtd/entity-config.xsd
>>>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/entity/dtd/entity-config.xsd?rev=1482796&r1=1482795&r2=1482796&view=diff
>>>> ==============================================================================
>>>> --- ofbiz/trunk/framework/entity/dtd/entity-config.xsd (original)
>>>> +++ ofbiz/trunk/framework/entity/dtd/entity-config.xsd Wed May 15 12:50:54 2013
>>>> @@ -462,12 +462,6 @@ under the License.
>>>>             </xs:annotation>
>>>>         </xs:attribute>
>>>>         <xs:attribute type="xs:nonNegativeInteger" name="time-between-eviction-runs-millis" default="600000"/>
>>>> -        <xs:attribute type="xs:nonNegativeInteger" name="pool-sleeptime" default="300000"/>
>>>> -        <xs:attribute type="xs:nonNegativeInteger" name="pool-lifetime" default="600000"/>
>>>> -        <xs:attribute type="xs:nonNegativeInteger" name="pool-deadlock-maxwait" default="300000"/>
>>>> -        <xs:attribute type="xs:nonNegativeInteger" name="pool-deadlock-retrywait" default="10000"/>
>>>> -        <xs:attribute type="xs:string" name="pool-jdbc-test-stmt"/>
>>>> -        <xs:attribute type="xs:string" name="pool-xa-wrapper-class"/>
>>>>     </xs:attributeGroup>
>>>>     <xs:element name="jndi-jdbc">
>>>>         <xs:complexType>
>>>>
>>>>
>>>
>>>
>