Re: svn commit: r1420019 - /ofbiz/trunk/themes/flatgrey/data/FlatGreyThemeData.xml

[Adam Heath-2]

Er, no.  Please revert.  The correct fix is to update build.xml to
minimise these files.

On 12/11/2012 01:31 AM, [hidden email] wrote:

> Author: jleroux
> Date: Tue Dec 11 07:31:40 2012
> New Revision: 1420019
>
> URL: http://svn.apache.org/viewvc?rev=1420019&view=rev
> Log:
> Fixes "Flatgrey visual theme does not work"  https://issues.apache.org/jira/browse/OFBIZ-5096 reported by Wai and pointed out by Adrian in dev ML
>
> Modified:
>     ofbiz/trunk/themes/flatgrey/data/FlatGreyThemeData.xml
>
> Modified: ofbiz/trunk/themes/flatgrey/data/FlatGreyThemeData.xml
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/themes/flatgrey/data/FlatGreyThemeData.xml?rev=1420019&r1=1420018&r2=1420019&view=diff
> ==============================================================================
> --- ofbiz/trunk/themes/flatgrey/data/FlatGreyThemeData.xml (original)
> +++ ofbiz/trunk/themes/flatgrey/data/FlatGreyThemeData.xml Tue Dec 11 07:31:40 2012
> @@ -21,12 +21,12 @@ under the License.
>  <entity-engine-xml>
>      <VisualTheme visualThemeId="FLAT_GREY" visualThemeSetId="BACKOFFICE" description="Flat Grey - Floating Layout, Sight-Impaired Accessible, Bidirectional"/>
>      <VisualThemeResource visualThemeId="FLAT_GREY" resourceTypeEnumId="VT_NAME" resourceValue="FLAT_GREY" sequenceId="01"/>
> -    <VisualThemeResource visualThemeId="FLAT_GREY" resourceTypeEnumId="VT_STYLESHEET" resourceValue="/flatgrey/maincss-min.css" sequenceId="01"/>
> -    <VisualThemeResource visualThemeId="FLAT_GREY" resourceTypeEnumId="VT_STYLESHEET" resourceValue="/flatgrey/javascript-min.css" sequenceId="02"/>
> +    <VisualThemeResource visualThemeId="FLAT_GREY" resourceTypeEnumId="VT_STYLESHEET" resourceValue="/flatgrey/maincss.css" sequenceId="01"/>
> +    <VisualThemeResource visualThemeId="FLAT_GREY" resourceTypeEnumId="VT_STYLESHEET" resourceValue="/flatgrey/javascript.css" sequenceId="02"/>
>      <VisualThemeResource visualThemeId="FLAT_GREY" resourceTypeEnumId="VT_HELPSTYLESHEET" resourceValue="/flatgrey/help.css" sequenceId="01"/>    
>      <VisualThemeResource visualThemeId="FLAT_GREY" resourceTypeEnumId="VT_DOCBOOKSTYLESHEET" resourceValue="/flatgrey/webapp/flatgrey/docbook.css" sequenceId="01"/>    
> -    <VisualThemeResource visualThemeId="FLAT_GREY" resourceTypeEnumId="VT_RTL_STYLESHEET" resourceValue="/flatgrey/mainrtl-min.css" sequenceId="01"/>
> -    <VisualThemeResource visualThemeId="FLAT_GREY" resourceTypeEnumId="VT_HDR_JAVASCRIPT" resourceValue="/flatgrey/js/application-min.js" sequenceId="01"/>
> +    <VisualThemeResource visualThemeId="FLAT_GREY" resourceTypeEnumId="VT_RTL_STYLESHEET" resourceValue="/flatgrey/mainrtl.css" sequenceId="01"/>
> +    <VisualThemeResource visualThemeId="FLAT_GREY" resourceTypeEnumId="VT_HDR_JAVASCRIPT" resourceValue="/flatgrey/js/application.js" sequenceId="01"/>
>      <VisualThemeResource visualThemeId="FLAT_GREY" resourceTypeEnumId="VT_SHORTCUT_ICON" resourceValue="/images/ofbiz.ico" sequenceId="01"/>
>      <VisualThemeResource visualThemeId="FLAT_GREY" resourceTypeEnumId="VT_HDR_IMAGE_URL" resourceValue="/flatgrey/images/ofbiz_logo.gif" sequenceId="01"/>
>      <VisualThemeResource visualThemeId="FLAT_GREY" resourceTypeEnumId="VT_HDR_TMPLT_LOC" resourceValue="component://flatgrey/includes/header.ftl" sequenceId="01"/>
>
>

[Adrian Crum-3]

Adam,

The tool used to minify CSS and JS files was removed in rev 1416358.
Then the visual theme was partially updated to not use the minify tool.
But that broke the theme, because the original commit to minify the Flat
Grey theme was not completely reverted. This commit was necessary to
complete the the revert.

-Adrian


On 12/11/2012 6:33 PM, Adam Heath wrote:

> Er, no.  Please revert.  The correct fix is to update build.xml to
> minimise these files.
>
> On 12/11/2012 01:31 AM, [hidden email] wrote:
>> Author: jleroux
>> Date: Tue Dec 11 07:31:40 2012
>> New Revision: 1420019
>>
>> URL: http://svn.apache.org/viewvc?rev=1420019&view=rev
>> Log:
>> Fixes "Flatgrey visual theme does not work"  https://issues.apache.org/jira/browse/OFBIZ-5096 reported by Wai and pointed out by Adrian in dev ML
>>
>> Modified:
>>      ofbiz/trunk/themes/flatgrey/data/FlatGreyThemeData.xml
>>
>> Modified: ofbiz/trunk/themes/flatgrey/data/FlatGreyThemeData.xml
>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/themes/flatgrey/data/FlatGreyThemeData.xml?rev=1420019&r1=1420018&r2=1420019&view=diff
>> ==============================================================================
>> --- ofbiz/trunk/themes/flatgrey/data/FlatGreyThemeData.xml (original)
>> +++ ofbiz/trunk/themes/flatgrey/data/FlatGreyThemeData.xml Tue Dec 11 07:31:40 2012
>> @@ -21,12 +21,12 @@ under the License.
>>   <entity-engine-xml>
>>       <VisualTheme visualThemeId="FLAT_GREY" visualThemeSetId="BACKOFFICE" description="Flat Grey - Floating Layout, Sight-Impaired Accessible, Bidirectional"/>
>>       <VisualThemeResource visualThemeId="FLAT_GREY" resourceTypeEnumId="VT_NAME" resourceValue="FLAT_GREY" sequenceId="01"/>
>> -    <VisualThemeResource visualThemeId="FLAT_GREY" resourceTypeEnumId="VT_STYLESHEET" resourceValue="/flatgrey/maincss-min.css" sequenceId="01"/>
>> -    <VisualThemeResource visualThemeId="FLAT_GREY" resourceTypeEnumId="VT_STYLESHEET" resourceValue="/flatgrey/javascript-min.css" sequenceId="02"/>
>> +    <VisualThemeResource visualThemeId="FLAT_GREY" resourceTypeEnumId="VT_STYLESHEET" resourceValue="/flatgrey/maincss.css" sequenceId="01"/>
>> +    <VisualThemeResource visualThemeId="FLAT_GREY" resourceTypeEnumId="VT_STYLESHEET" resourceValue="/flatgrey/javascript.css" sequenceId="02"/>
>>       <VisualThemeResource visualThemeId="FLAT_GREY" resourceTypeEnumId="VT_HELPSTYLESHEET" resourceValue="/flatgrey/help.css" sequenceId="01"/>
>>       <VisualThemeResource visualThemeId="FLAT_GREY" resourceTypeEnumId="VT_DOCBOOKSTYLESHEET" resourceValue="/flatgrey/webapp/flatgrey/docbook.css" sequenceId="01"/>
>> -    <VisualThemeResource visualThemeId="FLAT_GREY" resourceTypeEnumId="VT_RTL_STYLESHEET" resourceValue="/flatgrey/mainrtl-min.css" sequenceId="01"/>
>> -    <VisualThemeResource visualThemeId="FLAT_GREY" resourceTypeEnumId="VT_HDR_JAVASCRIPT" resourceValue="/flatgrey/js/application-min.js" sequenceId="01"/>
>> +    <VisualThemeResource visualThemeId="FLAT_GREY" resourceTypeEnumId="VT_RTL_STYLESHEET" resourceValue="/flatgrey/mainrtl.css" sequenceId="01"/>
>> +    <VisualThemeResource visualThemeId="FLAT_GREY" resourceTypeEnumId="VT_HDR_JAVASCRIPT" resourceValue="/flatgrey/js/application.js" sequenceId="01"/>
>>       <VisualThemeResource visualThemeId="FLAT_GREY" resourceTypeEnumId="VT_SHORTCUT_ICON" resourceValue="/images/ofbiz.ico" sequenceId="01"/>
>>       <VisualThemeResource visualThemeId="FLAT_GREY" resourceTypeEnumId="VT_HDR_IMAGE_URL" resourceValue="/flatgrey/images/ofbiz_logo.gif" sequenceId="01"/>
>>       <VisualThemeResource visualThemeId="FLAT_GREY" resourceTypeEnumId="VT_HDR_TMPLT_LOC" resourceValue="component://flatgrey/includes/header.ftl" sequenceId="01"/>
>>
>>

[Adam Heath-2]

On 12/11/2012 08:25 PM, Adrian Crum wrote:
> The tool used to minify CSS and JS files was removed in rev 1416358.
> Then the visual theme was partially updated to not use the minify
> tool. But that broke the theme, because the original commit to minify
> the Flat Grey theme was not completely reverted. This commit was
> necessary to complete the the revert.

Oh, missed that.  Why don't we want to minify things anymore, if you
don't mind me asking?

[Jacques Le Roux]

Adam Heath wrote:
> On 12/11/2012 08:25 PM, Adrian Crum wrote:
>> The tool used to minify CSS and JS files was removed in rev 1416358.
>> Then the visual theme was partially updated to not use the minify
>> tool. But that broke the theme, because the original commit to minify
>> the Flat Grey theme was not completely reverted. This commit was
>> necessary to complete the the revert.
>
> Oh, missed that.  Why don't we want to minify things anymore, if you
> don't mind me asking?

Because it collides with Birt
http://svn.apache.org/viewvc?view=revision&revision=1416364

Jacques

[Adam Heath-2]

On 12/12/2012 01:34 PM, Jacques Le Roux wrote:

> Adam Heath wrote:
>> On 12/11/2012 08:25 PM, Adrian Crum wrote:
>>> The tool used to minify CSS and JS files was removed in rev 1416358.
>>> Then the visual theme was partially updated to not use the minify
>>> tool. But that broke the theme, because the original commit to minify
>>> the Flat Grey theme was not completely reverted. This commit was
>>> necessary to complete the the revert.
>>
>> Oh, missed that.  Why don't we want to minify things anymore, if you
>> don't mind me asking?
>
> Because it collides with Birt
> http://svn.apache.org/viewvc?view=revision&revision=1416364

Ok, then I disagree.  So what if using yuicompressor on birt causes
birt to break.  That's birt's problem, or yuicompressor's problem.  If
it works fine with ofbiz files(or ofbiz files can be changed to make
it work), then why not use it?  It reduces the size of the files, and
in some cases, makes client-side parsing faster.

I'd remove birt(tbh, it's too big, too intrusive), and re-add
yuicompressor.

[Jacques Le Roux]

From: "Adam Heath" <[hidden email]>

> On 12/12/2012 01:34 PM, Jacques Le Roux wrote:
>> Adam Heath wrote:
>>> On 12/11/2012 08:25 PM, Adrian Crum wrote:
>>>> The tool used to minify CSS and JS files was removed in rev 1416358.
>>>> Then the visual theme was partially updated to not use the minify
>>>> tool. But that broke the theme, because the original commit to minify
>>>> the Flat Grey theme was not completely reverted. This commit was
>>>> necessary to complete the the revert.
>>>
>>> Oh, missed that.  Why don't we want to minify things anymore, if you
>>> don't mind me asking?
>>
>> Because it collides with Birt
>> http://svn.apache.org/viewvc?view=revision&revision=1416364
>
> Ok, then I disagree.  So what if using yuicompressor on birt causes
> birt to break.  That's birt's problem, or yuicompressor's problem.  If
> it works fine with ofbiz files(or ofbiz files can be changed to make
> it work), then why not use it?  It reduces the size of the files, and
> in some cases, makes client-side parsing faster.
>
> I'd remove birt(tbh, it's too big, too intrusive), and re-add
> yuicompressor.

I committed  yuicompressor, so I decided to remove it, because it was added after Birt. Feel free to tackle the problem...

Jacques

[Adam Heath-2]

On 12/12/2012 04:40 PM, Jacques Le Roux wrote:

>> Ok, then I disagree.  So what if using yuicompressor on birt causes
>> birt to break.  That's birt's problem, or yuicompressor's problem.  If
>> it works fine with ofbiz files(or ofbiz files can be changed to make
>> it work), then why not use it?  It reduces the size of the files, and
>> in some cases, makes client-side parsing faster.
>>
>> I'd remove birt(tbh, it's too big, too intrusive), and re-add
>> yuicompressor.
>
> I committed  yuicompressor, so I decided to remove it, because it was added after Birt. Feel free to tackle the problem...

I had a feeling you'd say that.  Someone always has to be willing to
do the work.  I like the idea of yuicompressor, but am busy enough
unfortunately to not be able to finish/perfect/watch the integration.