Re: svn commit: r1355863 - /ofbiz/trunk/build.xml

[Jacopo Cappellato-4]

Please revert this: all the descriptions are using the imperative mood and it doesn't make any sense to change two of them to use another form.

Jacopo

On Jul 1, 2012, at 10:46 AM, [hidden email] wrote:

> Author: jleroux
> Date: Sun Jul  1 08:46:59 2012
> New Revision: 1355863
>
> URL: http://svn.apache.org/viewvc?rev=1355863&view=rev
> Log:
> No functionall changes, just some targets comments improvements
>
> Modified:
>    ofbiz/trunk/build.xml
>
> Modified: ofbiz/trunk/build.xml
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/build.xml?rev=1355863&r1=1355862&r2=1355863&view=diff
> ==============================================================================
> --- ofbiz/trunk/build.xml (original)
> +++ ofbiz/trunk/build.xml Sun Jul  1 08:46:59 2012
> @@ -839,7 +839,7 @@ under the License.
>         </java>
>     </target>
>     <target name="load-admin-user-login"
> -            description="Create a user login with admin privileges and a temporary password equal to 'ofbiz'; after a successful login the user will be prompted for a new password. Example command for the userLogin 'admin': ./ant load-admin-user-login -DuserLoginId=admin">
> +            description="Creates a user login with admin privileges and a temporary password equal to 'ofbiz'. After a successful login the user will be prompted for a new password. Example command for the userLogin 'admin': ./ant load-admin-user-login -DuserLoginId=admin">
>         <fail message="userLoginId parameter is required. To add the parameter to the command for user admin: -DuserLoginId=admin">
>             <condition>
>                 <not><isset property="userLoginId"/></not>
> @@ -856,7 +856,7 @@ under the License.
>         <delete file="runtime/tmp/tmpUserLogin.xml"/>
>     </target>
>     <target name="create-admin-user-login"
> -            description="Prompt for a user name, then create a user login with admin privileges and a temporary password equal to 'ofbiz'. After a successful login the user will be prompted for a new password.">
> +            description="Prompts for a user name, then creates a user login with admin privileges and a temporary password equal to 'ofbiz'. After a successful login the user will be prompted for a new password. Note: this beneath uses load-admin-user-login target">
>         <input addproperty="userLoginId" message="Enter user name (log in with the temporary password 'ofbiz'):"/>
>         <antcall target="load-admin-user-login"/>
>     </target>
>
>

[Jacques Le Roux]

Done at r1355901

It seems to me that it would be better to not use the imperative there. Because targets are actions, anyway not a big deal and it
would need to change all of them. I have not enough time for such details.

Jacques

From: "Jacopo Cappellato" <[hidden email]>

> Please revert this: all the descriptions are using the imperative mood and it doesn't make any sense to change two of them to use
> another form.
>
> Jacopo
>
> On Jul 1, 2012, at 10:46 AM, [hidden email] wrote:
>
>> Author: jleroux
>> Date: Sun Jul  1 08:46:59 2012
>> New Revision: 1355863
>>
>> URL: http://svn.apache.org/viewvc?rev=1355863&view=rev
>> Log:
>> No functionall changes, just some targets comments improvements
>>
>> Modified:
>>    ofbiz/trunk/build.xml
>>
>> Modified: ofbiz/trunk/build.xml
>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/build.xml?rev=1355863&r1=1355862&r2=1355863&view=diff
>> ==============================================================================
>> --- ofbiz/trunk/build.xml (original)
>> +++ ofbiz/trunk/build.xml Sun Jul  1 08:46:59 2012
>> @@ -839,7 +839,7 @@ under the License.
>>         </java>
>>     </target>
>>     <target name="load-admin-user-login"
>> -            description="Create a user login with admin privileges and a temporary password equal to 'ofbiz'; after a successful
>> login the user will be prompted for a new password. Example command for the userLogin 'admin': ./ant
>> load-admin-user-login -DuserLoginId=admin">
>> +            description="Creates a user login with admin privileges and a temporary password equal to 'ofbiz'. After a
>> successful login the user will be prompted for a new password. Example command for the userLogin 'admin': ./ant
>> load-admin-user-login -DuserLoginId=admin">
>>         <fail message="userLoginId parameter is required. To add the parameter to the command for user
>> admin: -DuserLoginId=admin">
>>             <condition>
>>                 <not><isset property="userLoginId"/></not>
>> @@ -856,7 +856,7 @@ under the License.
>>         <delete file="runtime/tmp/tmpUserLogin.xml"/>
>>     </target>
>>     <target name="create-admin-user-login"
>> -            description="Prompt for a user name, then create a user login with admin privileges and a temporary password equal
>> to 'ofbiz'. After a successful login the user will be prompted for a new password.">
>> +            description="Prompts for a user name, then creates a user login with admin privileges and a temporary password equal
>> to 'ofbiz'. After a successful login the user will be prompted for a new password. Note: this beneath uses load-admin-user-login
>> target">
>>         <input addproperty="userLoginId" message="Enter user name (log in with the temporary password 'ofbiz'):"/>
>>         <antcall target="load-admin-user-login"/>
>>     </target>
>>
>>
>
>