Re: svn commit: r1352768 - in /ofbiz/trunk/applications/accounting: data/AccountingSecurityPermissionSeedData.xml src/org/ofbiz/accounting/payment/PaymentGatewayServices.java webapp/accounting/payment/manualTx.ftl widget/AccountingMenus.xml

[Jacopo Cappellato-4]

On Jun 22, 2012, at 6:04 AM, [hidden email] wrote:

>         // security check
> -        if (!security.hasEntityPermission("MANUAL", "_PAYMENT", userLogin)) {
> +        if (!security.hasEntityPermission("MANUAL", "_PAYMENT", userLogin) && !security.hasEntityPermission("MANUAL", "_PAYMENT", userLogin)) {

Hans,

there's a bug in the above line.

Regards,

Jacopo

[hans_bakker]

Thanks for spotting this, corrected in r 1352774

The reason for these changes is that ACCOUNTING_ADMIN really can do
everything in the accounting manager and that not many different
permissions are required.

Regards,
Hans


On 06/22/2012 11:43 AM, Jacopo Cappellato wrote:

> On Jun 22, 2012, at 6:04 AM, [hidden email] wrote:
>
>>          // security check
>> -        if (!security.hasEntityPermission("MANUAL", "_PAYMENT", userLogin)) {
>> +        if (!security.hasEntityPermission("MANUAL", "_PAYMENT", userLogin)&&  !security.hasEntityPermission("MANUAL", "_PAYMENT", userLogin)) {
> Hans,
>
> there's a bug in the above line.
>
> Regards,
>
> Jacopo